breaking: Change the fetcher argument to be consistent with the passed key #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6ba30ea:
|
This was referenced Apr 11, 2022
Merged
himanshiLt
pushed a commit
to himanshiLt/swr
that referenced
this pull request
Jun 10, 2022
…d key (vercel#1864) * change the fetcher argument to be consistent with the key * fix test cases * fix type checks
This was referenced Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
useSWR([1, 2, 3], fetcher)will use the fetcher signaturefetcher(a, b, c) => data. With this PR it changes tofetcher([a, b, c]) => data, which makes the argument consistent, and unblocks other features we want to add in the future.This also simplifies the type definitions and inference a lot.
Planned as a breaking change in 2.0.