Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: import with-selector with extension from useESE #1967

Merged
merged 2 commits into from
May 14, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 14, 2022

useESE 1.1.0 is missing exports field which will break esm module resolution

  • add extension
  • ./shim/with-selector and ./with-selector references the same file

@huozhi huozhi requested a review from shuding as a code owner May 14, 2022 09:16
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 106d2b0:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@shuding
Copy link
Member

shuding commented May 14, 2022

@huozhi swr/infinite uses the shim as well, could you also update that? Thanks!

@huozhi
Copy link
Member Author

huozhi commented May 14, 2022

@shuding the use-sync-external-store/shim/with-selector is ambiguous for esm loader but use-sync-external-store/shim import works well since it's a folder with index.js inside. So I only changed with-selector

@shuding
Copy link
Member

shuding commented May 14, 2022

@huozhi I am running into a problem with that:

CleanShot 2022-05-14 at 13 21 16@2x

@huozhi
Copy link
Member Author

huozhi commented May 14, 2022

oh I see I changed the exports field in node_modules....

@shuding shuding merged commit e81d22f into main May 14, 2022
@shuding shuding deleted the use-ese-imports branch May 14, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants