Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix missing husky warning #2160

Merged
merged 3 commits into from
Sep 14, 2022
Merged

chore: fix missing husky warning #2160

merged 3 commits into from
Sep 14, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Sep 14, 2022

Seeing error Can't find Husky, skipping post-checkout hook when you commit.

Fix it by adding the .husky precommit and remove the legacy config in package.json according to the new tutorial in husky

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit adcf015:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

Copy link
Collaborator

@promer94 promer94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need also add prepare script for husky https://typicode.github.io/husky/#/?id=install

{
  "scripts": {
    "prepare": "husky install"
  }
}

Otherwise _/husky.sh will be not be generated

@huozhi huozhi merged commit 4c90499 into main Sep 14, 2022
@huozhi huozhi deleted the passing-serialized-key branch September 14, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants