Share TaskInputs between task cache and task #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
|
sokra
force-pushed
the
sokra/web-211-share-taskinputs-with-cache-key
branch
from
6cde25b
to
1ae23e0
Compare
Benchmark for 9f13a64Click to view benchmark
|
sokra
force-pushed
the
sokra/web-211-share-taskinputs-with-cache-key
branch
from
1ae23e0
to
804fbe0
Compare
Benchmark for e66b54bClick to view benchmark
|
alexkirsz
approved these changes
Dec 5, 2022
| @@ -508,7 +463,49 @@ impl Task { | |||
| ) | |||
| } | |||
| }; | |||
| true | |||
| let future = match &self.ty { | |||
There was a problem hiding this comment.
This makes the execution_started even larger and harder to parse. Move this to a TaskType::execute method instead. It no longer uses self, everything is in TaskType.
There was a problem hiding this comment.
It uses state from self, but I can move it into some different method in Task
Move bound task function into TaskState to allow unloading
sokra
force-pushed
the
sokra/web-211-share-taskinputs-with-cache-key
branch
from
804fbe0
to
67ff541
Compare
sokra
added
the
pr: automerge
Benchmark for b36124d
Click to view full benchmark
|
Benchmark for 19da795Click to view benchmark
|
NicholasLYang
added a commit
to NicholasLYang/turbo
that referenced
this pull request
Dec 5, 2022
commit 096b8b8 Author: David Barrat <david@barrat.io> Date: Mon Dec 5 15:29:41 2022 +0100 Docs: Add Authdog to Turbo Showcase page (vercel#2921) [Authdog](https://www.authdog.com/) is an Identity and Access Management as a Service platform, built upon Serverless technologies (AWS Lambda, Vercel, Fastly and Cloudflare Workers). I started looking for alternatives to Nx, some times ago and experimented with Turbo, decided to migrate some projects to this tool, awesome stuff! commit e39d65e Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:23:40 2022 +0100 enable id reusing (vercel#2895) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 6b99818 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:53 2022 +0100 Reduce wrapper tasks by eagerly resolving Vcs (vercel#2933) * resolve codegenerateable before calling it * eagerly resolve some constructors to avoid creating many wrapper tasks Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit ce4c445 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:32 2022 +0100 Share TaskInputs between task cache and task (vercel#2923) Move bound task function into TaskState to allow unloading Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit e1bf5e2 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 14:32:24 2022 +0100 make sure that removing collectibles will cleanup helper entries (vercel#2872) commit 532eff7 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 13:27:22 2022 +0100 Reduce the number of Strings and wrapper tasks (vercel#2834) * use Cow to avoid creating Strings for trait function names * trait calls avoid the resolve trait wrapper task when called on a resolved VC * eagerly resolve some Vc that would otherwise create a lot of wrapper tasks Depends on vercel#2416 commit dc36fc4 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 11:00:10 2022 +0100 reduce number of allocations (vercel#2833) VecDeque::new always allocates 7 elements commit 4f247be Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Mon Dec 5 15:39:15 2022 +0800 Upgrade to Next.js 13 (vercel#2906) This gets our site updated to Next.js 13 and Nextra 2. As a bonus, this should help prevent some of the issues we're seeing in Sentry. commit 1e81806 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 07:42:19 2022 +0100 shrink lists and sets that are stored in Tasks (vercel#2873) Reduces memory usage by 14% commit cac79bb Author: Ahab <ahabhgk@gmail.com> Date: Sun Dec 4 13:23:26 2022 +0800 make lazy bundling for dynamic import more lazy (vercel#2918) For example: ```js // index.js setTimeout(() => { import('./async.js').then(() => console.log('async.js loaded')) }, 1000) ``` ```js // async.js import './async.css'; console.log('async.js content') ``` For now the graph generated by above code will be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 22 24" src="https://user-images.githubusercontent.com/42857895/205442932-ebfd5126-ef3d-4205-b5b5-434126ad46f7.png"> The `ChunkGroup_async` will be a async chunk group of `ChunkGroup_index`, pushed at [turbopack-core/src/chunk/mod.rs#L462](https://github.com/vercel/turbo/blob/b7bcfc312e41367e2ec7f5fb37a6ee88a6b6545a/crates/turbopack-core/src/chunk/mod.rs#L462), and it will have a reference between `ChunkGroup_index` and `ChunkGroup_async`, but `ChunkGroup_async` will also be a chunk group of `ChunkGroup_async-manifest-chunk` created at [turbopack-ecmascript/src/chunk/loader.rs#L165](https://github.com/vercel/turbo/blob/b7bcfc312e41367e2ec7f5fb37a6ee88a6b6545a/crates/turbopack-ecmascript/src/chunk/loader.rs#L165), and will have a reference between `ChunkGroup_async-manifest-chunk` and `ChunkGroup_async`. This leads to when the browser request '/_a8a837.js', turbopack will compile chunks in `ChunkGroup_index` ('/_a8a837.js'), `ChunkGroup_async-manifest-chunk` ('/src_async.js_manifest-chunk.js'), and also chunks in `ChunkGroup_async` ('/src_async.js', '/src_async.css'), because of the reference between `ChunkGroup_index` and `ChunkGroup_async`. But the expected behavior is only compile chunks in `ChunkGroup_index` and `ChunkGroup_async-manifest-chunk`, so this PR deleted the reference between `ChunkGroup_index` and `ChunkGroup_async`, makes the graph be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 50 29" src="https://user-images.githubusercontent.com/42857895/205444165-7b266dce-9aa6-4829-b8dc-d2bf74642aff.png"> And makes chunks in `ChunkGroup_async` to be compiled only when the browser request '/src_async.js_manifest-chunk.js'. commit fd09f2e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 4 03:26:37 2022 +0000 chore(deps): update dependency @types/node to v18.11.10 (vercel#2928) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit 429e91e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 22:21:26 2022 -0500 chore(deps): update dependency @babel/core to v7.20.5 (vercel#2919) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 6478d61 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Sat Dec 3 22:11:10 2022 +0100 update chromiumoxide (vercel#2916) updating in hope that this fixes the random errors in test runs commit b7bcfc3 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 08:54:50 2022 +0000 chore(deps): update rust crate futures to 0.3.25 (vercel#2915) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dev-dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.24` -> `0.3.25` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rust-lang/futures-rs</summary> ### [`v0.3.25`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0325---2022-10-20) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.24...0.3.25) - Fix soundness issue in `join!` and `try_join!` macros ([#&vercel#8203;2649](https://togithub.com/rust-lang/futures-rs/issues/2649)) - Implement `Clone` for `sink::Drain` ([#&vercel#8203;2650](https://togithub.com/rust-lang/futures-rs/issues/2650)) ### [`v0.3.24`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0324---2022-08-29) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.23...0.3.24) - Fix incorrect termination of `select_with_strategy` streams ([#&vercel#8203;2635](https://togithub.com/rust-lang/futures-rs/issues/2635)) ### [`v0.3.23`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0323---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.22...0.3.23) - Work around MSRV increase due to a cargo bug. ### [`v0.3.22`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0322---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.21...0.3.22) - Fix `Sync` impl of `BiLockGuard` ([#&vercel#8203;2570](https://togithub.com/rust-lang/futures-rs/issues/2570)) - Fix partial iteration in `FuturesUnordered` ([#&vercel#8203;2574](https://togithub.com/rust-lang/futures-rs/issues/2574)) - Fix false detection of inner panics in `Shared` ([#&vercel#8203;2576](https://togithub.com/rust-lang/futures-rs/issues/2576)) - Add `Mutex::lock_owned` and `Mutex::try_lock_owned` ([#&vercel#8203;2571](https://togithub.com/rust-lang/futures-rs/issues/2571)) - Add `io::copy_buf_abortable` ([#&vercel#8203;2507](https://togithub.com/rust-lang/futures-rs/issues/2507)) - Remove `Unpin` bound from `TryStreamExt::into_async_read` ([#&vercel#8203;2599](https://togithub.com/rust-lang/futures-rs/issues/2599)) - Make `run_until_stalled` handle self-waking futures ([#&vercel#8203;2593](https://togithub.com/rust-lang/futures-rs/issues/2593)) - Use `FuturesOrdered` in `try_join_all` ([#&vercel#8203;2556](https://togithub.com/rust-lang/futures-rs/issues/2556)) - Fix orderings in `LocalPool` waker ([#&vercel#8203;2608](https://togithub.com/rust-lang/futures-rs/issues/2608)) - Fix `stream::Chunk` adapters size hints ([#&vercel#8203;2611](https://togithub.com/rust-lang/futures-rs/issues/2611)) - Add `push_front` and `push_back` to `FuturesOrdered` ([#&vercel#8203;2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Deprecate `FuturesOrdered::push` in favor of `FuturesOrdered::push_back` ([#&vercel#8203;2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Performance improvements ([#&vercel#8203;2583](https://togithub.com/rust-lang/futures-rs/issues/2583), [#&vercel#8203;2626](https://togithub.com/rust-lang/futures-rs/issues/2626)) - Documentation improvements ([#&vercel#8203;2579](https://togithub.com/rust-lang/futures-rs/issues/2579), [#&vercel#8203;2604](https://togithub.com/rust-lang/futures-rs/issues/2604), [#&vercel#8203;2613](https://togithub.com/rust-lang/futures-rs/issues/2613)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/vercel/turbo). commit 93222f2 Author: Anthony Shew <anthony.shew@vercel.com> Date: Fri Dec 2 16:36:55 2022 -0800 feat(docs): document topology outside of a task (vercel#2879) * Docs for topology outside of a task Documentation for behavior in vercel#2855! * Minor cleanup. * Some copy updates and add image. Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit f8aaf81 Author: Will Binns-Smith <wbinnssmith@gmail.com> Date: Fri Dec 2 16:32:35 2022 -0800 Link to Turbopack's architecture.md from CONTRIBUTING.md (vercel#2913) commit 0723170 Author: Thomas Knickman <tom.knickman@vercel.com> Date: Fri Dec 2 16:40:08 2022 -0500 feat(docs): add github (vercel#2912) commit c69298c Author: OJ Kwon <1210596+kwonoj@users.noreply.github.com> Date: Fri Dec 2 11:58:55 2022 -0800 build(cargo): update swc_core, dependencies to resolve circular deps (vercel#2869) * build(cargo): bump up swc_core * build(cargo): unpin indexmap * build(cargo): update dependencies * style(cargo): adjust format commit 6965cb8 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 19:42:05 2022 +0100 set correct cwd for server renderer (vercel#2886) commit 4a3cb94 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 18:27:02 2022 +0100 fix dynamic paths (vercel#2884) commit eead906 Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 16:09:08 2022 +0800 Fix the missing links. (vercel#2707) This PR does three things: 1. Prevents double redirects by setting the correct destination the first time. 2. Redirects URLs accidentally recreated in the new scope. 🤦♂️ 3. Removes a catch-all to trigger any additional missing links to appear. Changes are easy to review commit-by-commit. commit b8c0c3c Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 14:37:03 2022 +0800 Update lint-staged behavior. (vercel#2904) Before vercel#2859: `eslint --quiet --fix` After vercel#2859: `pnpm run lint --quiet --fix --` => `eslint . --ext js,jsx,ts,tsx --quiet --fix --` After this: `eslint --ext js,jsx,ts,tsx --quiet --fix --` Removes the sneaky `.`. commit 336ea22 Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 08:33:21 2022 +0800 Add additional detailed warning message if no tasks were run. (vercel#2778) This is a quality of life improvement output log so that you don't have to tease it out from the overall run summary and the situation is more-apparent. commit 9359c46 Author: Leah <github.leah@hrmny.sh> Date: Thu Dec 1 21:02:33 2022 +0100 simplify `next-binding` (vercel#2899) commit 22c1440 Author: Justin Ridgewell <justin@ridgewell.name> Date: Thu Dec 1 13:55:15 2022 -0500 Implement import.meta (vercel#2816) I chose to have the `import.meta.url` to have the relative project path on disk. Webpack makes it the absolute system path, but that would make the JS output system dependent and I didn't like that. Vite doesn't bundle and uses the browser's behavior, which is the dev server path. I'm splitting this from the in-progress PR to implement `new URL(…, import.meta.url)` support. That requires a bunch of changes to the analysis code and a new FS content source, so it's taking longer to ship. Fixes WEB-137. commit 75a7d1e Author: Thomas Knickman <tom.knickman@vercel.com> Date: Thu Dec 1 11:40:15 2022 -0500 fix(examples): cra pnpm fix (vercel#2897)
elitan
pushed a commit
to elitan/turbo
that referenced
this pull request
Dec 6, 2022
Move bound task function into TaskState to allow unloading Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
chris-olszewski
added a commit
that referenced
this pull request
Dec 8, 2022
](https://renovatebot.com){kind=link}
* Created two separate chains for executing commands: One that uses the parsed arguments from clap that are serialized to json, the other that still uses Cobra. Now to test to ensure that both do the same thing * Adjusted json serialization. Now debugging * Hooked up new CLI to commands * Fixing compile error * fixing lint error * Fixing more Go lint errors * Fixing lint errors * fixing up tests * Only using turbo state with link, login, and logout commands * Reverting changes * Removing more changes * Deleting code and fixing lints * Removed unlink command * Fixing bugs * Reverting more changes * fixed all tests * Refactored away duplicates using CLIConfigProvider interface * Lint fixes * Minor order tweak * Added error if command is not handled * PR feedback * Minor fixes. Adding --__test-run flag * Added workaround for subcommand help * Moved logic around to accomodate login/logout/link/unlink * Added some documentation, removed some printf * Adding more tests. * Hooked up link/login/unlink to --__test-run flag. Also added prysk tests for it. * Split up derive into multiple lines * Added comment explaining clap v3 in Cargo.toml * Ported daemon * Cleaning up code. Removed imports * Fix lints * Fixing lints * Ported prune to Rust CLI * Going all the way. Porting run to Rust CLI and upgrading back to clap v4 * Always gotta be testing * Always be testing. Always. Be. Testing. * Added tests for each singular flag. Now for combination tests * WIP: Hooking up Rust CLI to Go run logic * Disable color * Removed root inference from Go side * Fixing compile errors * Update cli/cmd/turbo/main.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Patching up code for run * PR changes * Restored labeler * Restore og.tsx * Reverted run changes that somehow made it in here * Fix run * Update cli/internal/turbostate/turbostate.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * feat: polyfill `global` with `globalThis` (#2666) This PR changes the ecmascript chunk logic to polyfill `global` with `globalThis`. A more complex and less performant solution (but with the benefit of us knowing the runtime environment) would be to add an effect for simple identifier expressions. * delete IsYarn util (#2668) * feat(docs): new authors & consistent filesnames (#2680) * Added caveat to environment variables docs (#2703) Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> * Fix publish workflow (#2681) * change from yarn to pnpm (#2686) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Reverted workflow changes * Fixing tests. Added run args to base * Trying to fix tests * Rewrote some logic around run args handling * Fixing up tests by adding flags and fixing parsing bugs * Hooked up RepoState to Go code * Fixing e2e tests * Fixing e2e * Gotta build shim, not turbo in package.json * Patched integration test * Reverted Cargo.toml * Cargo.lock too * Fixing tests * Moving turbo binary to shim * Fixed tests and CI * Check for TURBO_BINARY_PATH * Ported shell completions to Rust * Fixed logic issue with TURBO_BINARY_PATH * Created .gitignore file with generated rust and header files * Second try on cleaning up generated files * More CI fixes * Realized we still need some inference * Removed files that are edited by run-examples.sh * Switched order of `cargo fmt --check` and `cargo clippy` because `cargo clippy` generates files needed for `cargo fmt --check`. * Cleaning up changes. * Fix one thing break another * Accept integration changes * Deleting more unused code * Test fixes * No longer need this line now that src/ffi.rs is gitignored * PR feedback * Update cli/internal/run/run.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Fixing typo * Merged main * PR feedback * PR feedback * Merge main * Reverted workflow change * add build turbo GH action to use across workflows * use correct build target * Error on invalid unicode instead of lossy conversion * PR feedback * Squashed commit of the following: commit 096b8b8 Author: David Barrat <david@barrat.io> Date: Mon Dec 5 15:29:41 2022 +0100 Docs: Add Authdog to Turbo Showcase page (#2921) [Authdog](https://www.authdog.com/) is an Identity and Access Management as a Service platform, built upon Serverless technologies (AWS Lambda, Vercel, Fastly and Cloudflare Workers). I started looking for alternatives to Nx, some times ago and experimented with Turbo, decided to migrate some projects to this tool, awesome stuff! commit e39d65e Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:23:40 2022 +0100 enable id reusing (#2895) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 6b99818 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:53 2022 +0100 Reduce wrapper tasks by eagerly resolving Vcs (#2933) * resolve codegenerateable before calling it * eagerly resolve some constructors to avoid creating many wrapper tasks Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit ce4c445 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:32 2022 +0100 Share TaskInputs between task cache and task (#2923) Move bound task function into TaskState to allow unloading Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit e1bf5e2 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 14:32:24 2022 +0100 make sure that removing collectibles will cleanup helper entries (#2872) commit 532eff7 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 13:27:22 2022 +0100 Reduce the number of Strings and wrapper tasks (#2834) * use Cow to avoid creating Strings for trait function names * trait calls avoid the resolve trait wrapper task when called on a resolved VC * eagerly resolve some Vc that would otherwise create a lot of wrapper tasks Depends on #2416 commit dc36fc4 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 11:00:10 2022 +0100 reduce number of allocations (#2833) VecDeque::new always allocates 7 elements commit 4f247be Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Mon Dec 5 15:39:15 2022 +0800 Upgrade to Next.js 13 (#2906) This gets our site updated to Next.js 13 and Nextra 2. As a bonus, this should help prevent some of the issues we're seeing in Sentry. commit 1e81806 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 07:42:19 2022 +0100 shrink lists and sets that are stored in Tasks (#2873) Reduces memory usage by 14% commit cac79bb Author: Ahab <ahabhgk@gmail.com> Date: Sun Dec 4 13:23:26 2022 +0800 make lazy bundling for dynamic import more lazy (#2918) For example: ```js // index.js setTimeout(() => { import('./async.js').then(() => console.log('async.js loaded')) }, 1000) ``` ```js // async.js import './async.css'; console.log('async.js content') ``` For now the graph generated by above code will be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 22 24" src="https://user-images.githubusercontent.com/42857895/205442932-ebfd5126-ef3d-4205-b5b5-434126ad46f7.png"> The `ChunkGroup_async` will be a async chunk group of `ChunkGroup_index`, pushed at [turbopack-core/src/chunk/mod.rs#L462](https://github.com/vercel/turbo/blob/b7bcfc312e41367e2ec7f5fb37a6ee88a6b6545a/crates/turbopack-core/src/chunk/mod.rs#L462), and it will have a reference between `ChunkGroup_index` and `ChunkGroup_async`, but `ChunkGroup_async` will also be a chunk group of `ChunkGroup_async-manifest-chunk` created at [turbopack-ecmascript/src/chunk/loader.rs#L165](https://github.com/vercel/turbo/blob/b7bcfc312e41367e2ec7f5fb37a6ee88a6b6545a/crates/turbopack-ecmascript/src/chunk/loader.rs#L165), and will have a reference between `ChunkGroup_async-manifest-chunk` and `ChunkGroup_async`. This leads to when the browser request '/_a8a837.js', turbopack will compile chunks in `ChunkGroup_index` ('/_a8a837.js'), `ChunkGroup_async-manifest-chunk` ('/src_async.js_manifest-chunk.js'), and also chunks in `ChunkGroup_async` ('/src_async.js', '/src_async.css'), because of the reference between `ChunkGroup_index` and `ChunkGroup_async`. But the expected behavior is only compile chunks in `ChunkGroup_index` and `ChunkGroup_async-manifest-chunk`, so this PR deleted the reference between `ChunkGroup_index` and `ChunkGroup_async`, makes the graph be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 50 29" src="https://user-images.githubusercontent.com/42857895/205444165-7b266dce-9aa6-4829-b8dc-d2bf74642aff.png"> And makes chunks in `ChunkGroup_async` to be compiled only when the browser request '/src_async.js_manifest-chunk.js'. commit fd09f2e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 4 03:26:37 2022 +0000 chore(deps): update dependency @types/node to v18.11.10 (#2928) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit 429e91e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 22:21:26 2022 -0500 chore(deps): update dependency @babel/core to v7.20.5 (#2919) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 6478d61 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Sat Dec 3 22:11:10 2022 +0100 update chromiumoxide (#2916) updating in hope that this fixes the random errors in test runs commit b7bcfc3 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 08:54:50 2022 +0000 chore(deps): update rust crate futures to 0.3.25 (#2915) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dev-dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.24` -> `0.3.25` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rust-lang/futures-rs</summary> ### [`v0.3.25`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0325---2022-10-20) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.24...0.3.25) - Fix soundness issue in `join!` and `try_join!` macros ([#​2649](https://togithub.com/rust-lang/futures-rs/issues/2649)) - Implement `Clone` for `sink::Drain` ([#​2650](https://togithub.com/rust-lang/futures-rs/issues/2650)) ### [`v0.3.24`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0324---2022-08-29) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.23...0.3.24) - Fix incorrect termination of `select_with_strategy` streams ([#​2635](https://togithub.com/rust-lang/futures-rs/issues/2635)) ### [`v0.3.23`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0323---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.22...0.3.23) - Work around MSRV increase due to a cargo bug. ### [`v0.3.22`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0322---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.21...0.3.22) - Fix `Sync` impl of `BiLockGuard` ([#​2570](https://togithub.com/rust-lang/futures-rs/issues/2570)) - Fix partial iteration in `FuturesUnordered` ([#​2574](https://togithub.com/rust-lang/futures-rs/issues/2574)) - Fix false detection of inner panics in `Shared` ([#​2576](https://togithub.com/rust-lang/futures-rs/issues/2576)) - Add `Mutex::lock_owned` and `Mutex::try_lock_owned` ([#​2571](https://togithub.com/rust-lang/futures-rs/issues/2571)) - Add `io::copy_buf_abortable` ([#​2507](https://togithub.com/rust-lang/futures-rs/issues/2507)) - Remove `Unpin` bound from `TryStreamExt::into_async_read` ([#​2599](https://togithub.com/rust-lang/futures-rs/issues/2599)) - Make `run_until_stalled` handle self-waking futures ([#​2593](https://togithub.com/rust-lang/futures-rs/issues/2593)) - Use `FuturesOrdered` in `try_join_all` ([#​2556](https://togithub.com/rust-lang/futures-rs/issues/2556)) - Fix orderings in `LocalPool` waker ([#​2608](https://togithub.com/rust-lang/futures-rs/issues/2608)) - Fix `stream::Chunk` adapters size hints ([#​2611](https://togithub.com/rust-lang/futures-rs/issues/2611)) - Add `push_front` and `push_back` to `FuturesOrdered` ([#​2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Deprecate `FuturesOrdered::push` in favor of `FuturesOrdered::push_back` ([#​2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Performance improvements ([#​2583](https://togithub.com/rust-lang/futures-rs/issues/2583), [#​2626](https://togithub.com/rust-lang/futures-rs/issues/2626)) - Documentation improvements ([#​2579](https://togithub.com/rust-lang/futures-rs/issues/2579), [#​2604](https://togithub.com/rust-lang/futures-rs/issues/2604), [#​2613](https://togithub.com/rust-lang/futures-rs/issues/2613)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/vercel/turbo). commit 93222f2 Author: Anthony Shew <anthony.shew@vercel.com> Date: Fri Dec 2 16:36:55 2022 -0800 feat(docs): document topology outside of a task (#2879) * Docs for topology outside of a task Documentation for behavior in #2855! * Minor cleanup. * Some copy updates and add image. Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit f8aaf81 Author: Will Binns-Smith <wbinnssmith@gmail.com> Date: Fri Dec 2 16:32:35 2022 -0800 Link to Turbopack's architecture.md from CONTRIBUTING.md (#2913) commit 0723170 Author: Thomas Knickman <tom.knickman@vercel.com> Date: Fri Dec 2 16:40:08 2022 -0500 feat(docs): add github (#2912) commit c69298c Author: OJ Kwon <1210596+kwonoj@users.noreply.github.com> Date: Fri Dec 2 11:58:55 2022 -0800 build(cargo): update swc_core, dependencies to resolve circular deps (#2869) * build(cargo): bump up swc_core * build(cargo): unpin indexmap * build(cargo): update dependencies * style(cargo): adjust format commit 6965cb8 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 19:42:05 2022 +0100 set correct cwd for server renderer (#2886) commit 4a3cb94 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 18:27:02 2022 +0100 fix dynamic paths (#2884) commit eead906 Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 16:09:08 2022 +0800 Fix the missing links. (#2707) This PR does three things: 1. Prevents double redirects by setting the correct destination the first time. 2. Redirects URLs accidentally recreated in the new scope. 🤦♂️ 3. Removes a catch-all to trigger any additional missing links to appear. Changes are easy to review commit-by-commit. commit b8c0c3c Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 14:37:03 2022 +0800 Update lint-staged behavior. (#2904) Before #2859: `eslint --quiet --fix` After #2859: `pnpm run lint --quiet --fix --` => `eslint . --ext js,jsx,ts,tsx --quiet --fix --` After this: `eslint --ext js,jsx,ts,tsx --quiet --fix --` Removes the sneaky `.`. commit 336ea22 Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 08:33:21 2022 +0800 Add additional detailed warning message if no tasks were run. (#2778) This is a quality of life improvement output log so that you don't have to tease it out from the overall run summary and the situation is more-apparent. commit 9359c46 Author: Leah <github.leah@hrmny.sh> Date: Thu Dec 1 21:02:33 2022 +0100 simplify `next-binding` (#2899) commit 22c1440 Author: Justin Ridgewell <justin@ridgewell.name> Date: Thu Dec 1 13:55:15 2022 -0500 Implement import.meta (#2816) I chose to have the `import.meta.url` to have the relative project path on disk. Webpack makes it the absolute system path, but that would make the JS output system dependent and I didn't like that. Vite doesn't bundle and uses the browser's behavior, which is the dev server path. I'm splitting this from the in-progress PR to implement `new URL(…, import.meta.url)` support. That requires a bunch of changes to the analysis code and a new FS content source, so it's taking longer to ship. Fixes WEB-137. commit 75a7d1e Author: Thomas Knickman <tom.knickman@vercel.com> Date: Thu Dec 1 11:40:15 2022 -0500 fix(examples): cra pnpm fix (#2897) * Merged main * Reverting changes that snuck in * Fixing tests * Final fixes for tests * bump timeout on jobs that need to build turborepo * use prebuilt turbo for e2e tests * change when turbo is built * add turbo_tasks State (#2935) add mark_stateful() method to make tasks with state * @next/font [1/n] Add query structure to module requests (#2743) * Add query structure to module requests * Update crates/next-dev/src/lib.rs Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * add memory usage tracking (#2865) * @next/font [2/n] Apply next/font swc transform (#2742) * Check in next-font transform from Next.js repo * Use next-font transform * Run transform via custom rule * Place next/font transform behind cargo feature * Remove unused dependencies (#2934) * Remove unused dependencies * Add back lazy static as a dev dep * Add back bench dependencies * skip enabling corepack when building turborepo * Disabled corepack on other node setup action * explicitly disable corepack for examples * nvm * bump timemout for go unit * I am once again trying to get CI to work * force gnu compiler on windows * fix shim build script * fix lockfile * use gcc on windows instead of clang * fix shim * first pass at splitting out shim to library crate * change rust test workflow to not run turbo tests * replace module tests with integration tests * add readme and docs * normalize paths in integration test * Update crates/turborepo-lib/README.md Co-authored-by: Nicholas Yang <nick@nicholasyang.com> * Fix Cargo.lock * fix clippy warnings * extend timeout for running examples * Set installed toolchain as default Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> Co-authored-by: Florentin / 珞辰 <ecklf@icloud.com> Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> Co-authored-by: Matt Pocock <mattpocockvoice@gmail.com> Co-authored-by: Mehul Kar <mehul.kar@vercel.com> Co-authored-by: Yota Hada <hadayota33@gmail.com> Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
tknickman
added a commit
that referenced
this pull request
Dec 13, 2022
* Created two separate chains for executing commands: One that uses the parsed arguments from clap that are serialized to json, the other that still uses Cobra. Now to test to ensure that both do the same thing * Adjusted json serialization. Now debugging * Hooked up new CLI to commands * Fixing compile error * fixing lint error * Fixing more Go lint errors * Fixing lint errors * fixing up tests * Only using turbo state with link, login, and logout commands * Reverting changes * Removing more changes * Deleting code and fixing lints * Removed unlink command * Fixing bugs * Reverting more changes * fixed all tests * Refactored away duplicates using CLIConfigProvider interface * Lint fixes * Minor order tweak * Added error if command is not handled * PR feedback * Minor fixes. Adding --__test-run flag * Added workaround for subcommand help * Moved logic around to accomodate login/logout/link/unlink * Added some documentation, removed some printf * Adding more tests. * Hooked up link/login/unlink to --__test-run flag. Also added prysk tests for it. * Split up derive into multiple lines * Added comment explaining clap v3 in Cargo.toml * Ported daemon * Cleaning up code. Removed imports * Fix lints * Fixing lints * Ported prune to Rust CLI * Going all the way. Porting run to Rust CLI and upgrading back to clap v4 * Always gotta be testing * Always be testing. Always. Be. Testing. * Added tests for each singular flag. Now for combination tests * WIP: Hooking up Rust CLI to Go run logic * Disable color * Removed root inference from Go side * Fixing compile errors * Update cli/cmd/turbo/main.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Patching up code for run * PR changes * Restored labeler * Restore og.tsx * Reverted run changes that somehow made it in here * Fix run * Update cli/internal/turbostate/turbostate.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * feat: polyfill `global` with `globalThis` (#2666) This PR changes the ecmascript chunk logic to polyfill `global` with `globalThis`. A more complex and less performant solution (but with the benefit of us knowing the runtime environment) would be to add an effect for simple identifier expressions. * delete IsYarn util (#2668) * feat(docs): new authors & consistent filesnames (#2680) * Added caveat to environment variables docs (#2703) Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> * Fix publish workflow (#2681) * change from yarn to pnpm (#2686) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Reverted workflow changes * Fixing tests. Added run args to base * Trying to fix tests * Rewrote some logic around run args handling * Fixing up tests by adding flags and fixing parsing bugs * Hooked up RepoState to Go code * Fixing e2e tests * Fixing e2e * Gotta build shim, not turbo in package.json * Patched integration test * Reverted Cargo.toml * Cargo.lock too * Fixing tests * Moving turbo binary to shim * Fixed tests and CI * Check for TURBO_BINARY_PATH * Ported shell completions to Rust * Fixed logic issue with TURBO_BINARY_PATH * Created .gitignore file with generated rust and header files * Second try on cleaning up generated files * More CI fixes * Realized we still need some inference * Removed files that are edited by run-examples.sh * Switched order of `cargo fmt --check` and `cargo clippy` because `cargo clippy` generates files needed for `cargo fmt --check`. * Cleaning up changes. * Fix one thing break another * Accept integration changes * Deleting more unused code * Test fixes * No longer need this line now that src/ffi.rs is gitignored * PR feedback * Update cli/internal/run/run.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Fixing typo * Merged main * PR feedback * PR feedback * Merge main * Reverted workflow change * Error on invalid unicode instead of lossy conversion * PR feedback * Squashed commit of the following: commit 096b8b8 Author: David Barrat <david@barrat.io> Date: Mon Dec 5 15:29:41 2022 +0100 Docs: Add Authdog to Turbo Showcase page (#2921) [Authdog](https://www.authdog.com/) is an Identity and Access Management as a Service platform, built upon Serverless technologies (AWS Lambda, Vercel, Fastly and Cloudflare Workers). I started looking for alternatives to Nx, some times ago and experimented with Turbo, decided to migrate some projects to this tool, awesome stuff! commit e39d65e Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:23:40 2022 +0100 enable id reusing (#2895) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 6b99818 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:53 2022 +0100 Reduce wrapper tasks by eagerly resolving Vcs (#2933) * resolve codegenerateable before calling it * eagerly resolve some constructors to avoid creating many wrapper tasks Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit ce4c445 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:32 2022 +0100 Share TaskInputs between task cache and task (#2923) Move bound task function into TaskState to allow unloading Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit e1bf5e2 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 14:32:24 2022 +0100 make sure that removing collectibles will cleanup helper entries (#2872) commit 532eff7 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 13:27:22 2022 +0100 Reduce the number of Strings and wrapper tasks (#2834) * use Cow to avoid creating Strings for trait function names * trait calls avoid the resolve trait wrapper task when called on a resolved VC * eagerly resolve some Vc that would otherwise create a lot of wrapper tasks Depends on #2416 commit dc36fc4 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 11:00:10 2022 +0100 reduce number of allocations (#2833) VecDeque::new always allocates 7 elements commit 4f247be Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Mon Dec 5 15:39:15 2022 +0800 Upgrade to Next.js 13 (#2906) This gets our site updated to Next.js 13 and Nextra 2. As a bonus, this should help prevent some of the issues we're seeing in Sentry. commit 1e81806 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 07:42:19 2022 +0100 shrink lists and sets that are stored in Tasks (#2873) Reduces memory usage by 14% commit cac79bb Author: Ahab <ahabhgk@gmail.com> Date: Sun Dec 4 13:23:26 2022 +0800 make lazy bundling for dynamic import more lazy (#2918) For example: ```js // index.js setTimeout(() => { import('./async.js').then(() => console.log('async.js loaded')) }, 1000) ``` ```js // async.js import './async.css'; console.log('async.js content') ``` For now the graph generated by above code will be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 22 24" src="https://user-images.githubusercontent.com/42857895/205442932-ebfd5126-ef3d-4205-b5b5-434126ad46f7.png"> The `ChunkGroup_async` will be a async chunk group of `ChunkGroup_index`, pushed at [turbopack-core/src/chunk/mod.rs#L462](https://github.com/vercel/turbo/blob/b7bcfc312e41367e2ec7f5fb37a6ee88a6b6545a/crates/turbopack-core/src/chunk/mod.rs#L462), and it will have a reference between `ChunkGroup_index` and `ChunkGroup_async`, but `ChunkGroup_async` will also be a chunk group of `ChunkGroup_async-manifest-chunk` created at [turbopack-ecmascript/src/chunk/loader.rs#L165](https://github.com/vercel/turbo/blob/b7bcfc312e41367e2ec7f5fb37a6ee88a6b6545a/crates/turbopack-ecmascript/src/chunk/loader.rs#L165), and will have a reference between `ChunkGroup_async-manifest-chunk` and `ChunkGroup_async`. This leads to when the browser request '/_a8a837.js', turbopack will compile chunks in `ChunkGroup_index` ('/_a8a837.js'), `ChunkGroup_async-manifest-chunk` ('/src_async.js_manifest-chunk.js'), and also chunks in `ChunkGroup_async` ('/src_async.js', '/src_async.css'), because of the reference between `ChunkGroup_index` and `ChunkGroup_async`. But the expected behavior is only compile chunks in `ChunkGroup_index` and `ChunkGroup_async-manifest-chunk`, so this PR deleted the reference between `ChunkGroup_index` and `ChunkGroup_async`, makes the graph be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 50 29" src="https://user-images.githubusercontent.com/42857895/205444165-7b266dce-9aa6-4829-b8dc-d2bf74642aff.png"> And makes chunks in `ChunkGroup_async` to be compiled only when the browser request '/src_async.js_manifest-chunk.js'. commit fd09f2e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 4 03:26:37 2022 +0000 chore(deps): update dependency @types/node to v18.11.10 (#2928) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit 429e91e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 22:21:26 2022 -0500 chore(deps): update dependency @babel/core to v7.20.5 (#2919) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 6478d61 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Sat Dec 3 22:11:10 2022 +0100 update chromiumoxide (#2916) updating in hope that this fixes the random errors in test runs commit b7bcfc3 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 08:54:50 2022 +0000 chore(deps): update rust crate futures to 0.3.25 (#2915) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dev-dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.24` -> `0.3.25` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rust-lang/futures-rs</summary> ### [`v0.3.25`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0325---2022-10-20) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.24...0.3.25) - Fix soundness issue in `join!` and `try_join!` macros ([#​2649](https://togithub.com/rust-lang/futures-rs/issues/2649)) - Implement `Clone` for `sink::Drain` ([#​2650](https://togithub.com/rust-lang/futures-rs/issues/2650)) ### [`v0.3.24`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0324---2022-08-29) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.23...0.3.24) - Fix incorrect termination of `select_with_strategy` streams ([#​2635](https://togithub.com/rust-lang/futures-rs/issues/2635)) ### [`v0.3.23`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0323---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.22...0.3.23) - Work around MSRV increase due to a cargo bug. ### [`v0.3.22`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0322---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.21...0.3.22) - Fix `Sync` impl of `BiLockGuard` ([#​2570](https://togithub.com/rust-lang/futures-rs/issues/2570)) - Fix partial iteration in `FuturesUnordered` ([#​2574](https://togithub.com/rust-lang/futures-rs/issues/2574)) - Fix false detection of inner panics in `Shared` ([#​2576](https://togithub.com/rust-lang/futures-rs/issues/2576)) - Add `Mutex::lock_owned` and `Mutex::try_lock_owned` ([#​2571](https://togithub.com/rust-lang/futures-rs/issues/2571)) - Add `io::copy_buf_abortable` ([#​2507](https://togithub.com/rust-lang/futures-rs/issues/2507)) - Remove `Unpin` bound from `TryStreamExt::into_async_read` ([#​2599](https://togithub.com/rust-lang/futures-rs/issues/2599)) - Make `run_until_stalled` handle self-waking futures ([#​2593](https://togithub.com/rust-lang/futures-rs/issues/2593)) - Use `FuturesOrdered` in `try_join_all` ([#​2556](https://togithub.com/rust-lang/futures-rs/issues/2556)) - Fix orderings in `LocalPool` waker ([#​2608](https://togithub.com/rust-lang/futures-rs/issues/2608)) - Fix `stream::Chunk` adapters size hints ([#​2611](https://togithub.com/rust-lang/futures-rs/issues/2611)) - Add `push_front` and `push_back` to `FuturesOrdered` ([#​2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Deprecate `FuturesOrdered::push` in favor of `FuturesOrdered::push_back` ([#​2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Performance improvements ([#​2583](https://togithub.com/rust-lang/futures-rs/issues/2583), [#​2626](https://togithub.com/rust-lang/futures-rs/issues/2626)) - Documentation improvements ([#​2579](https://togithub.com/rust-lang/futures-rs/issues/2579), [#​2604](https://togithub.com/rust-lang/futures-rs/issues/2604), [#​2613](https://togithub.com/rust-lang/futures-rs/issues/2613)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/vercel/turbo). commit 93222f2 Author: Anthony Shew <anthony.shew@vercel.com> Date: Fri Dec 2 16:36:55 2022 -0800 feat(docs): document topology outside of a task (#2879) * Docs for topology outside of a task Documentation for behavior in #2855! * Minor cleanup. * Some copy updates and add image. Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit f8aaf81 Author: Will Binns-Smith <wbinnssmith@gmail.com> Date: Fri Dec 2 16:32:35 2022 -0800 Link to Turbopack's architecture.md from CONTRIBUTING.md (#2913) commit 0723170 Author: Thomas Knickman <tom.knickman@vercel.com> Date: Fri Dec 2 16:40:08 2022 -0500 feat(docs): add github (#2912) commit c69298c Author: OJ Kwon <1210596+kwonoj@users.noreply.github.com> Date: Fri Dec 2 11:58:55 2022 -0800 build(cargo): update swc_core, dependencies to resolve circular deps (#2869) * build(cargo): bump up swc_core * build(cargo): unpin indexmap * build(cargo): update dependencies * style(cargo): adjust format commit 6965cb8 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 19:42:05 2022 +0100 set correct cwd for server renderer (#2886) commit 4a3cb94 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 18:27:02 2022 +0100 fix dynamic paths (#2884) commit eead906 Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 16:09:08 2022 +0800 Fix the missing links. (#2707) This PR does three things: 1. Prevents double redirects by setting the correct destination the first time. 2. Redirects URLs accidentally recreated in the new scope. 🤦♂️ 3. Removes a catch-all to trigger any additional missing links to appear. Changes are easy to review commit-by-commit. commit b8c0c3c Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 14:37:03 2022 +0800 Update lint-staged behavior. (#2904) Before #2859: `eslint --quiet --fix` After #2859: `pnpm run lint --quiet --fix --` => `eslint . --ext js,jsx,ts,tsx --quiet --fix --` After this: `eslint --ext js,jsx,ts,tsx --quiet --fix --` Removes the sneaky `.`. commit 336ea22 Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 08:33:21 2022 +0800 Add additional detailed warning message if no tasks were run. (#2778) This is a quality of life improvement output log so that you don't have to tease it out from the overall run summary and the situation is more-apparent. commit 9359c46 Author: Leah <github.leah@hrmny.sh> Date: Thu Dec 1 21:02:33 2022 +0100 simplify `next-binding` (#2899) commit 22c1440 Author: Justin Ridgewell <justin@ridgewell.name> Date: Thu Dec 1 13:55:15 2022 -0500 Implement import.meta (#2816) I chose to have the `import.meta.url` to have the relative project path on disk. Webpack makes it the absolute system path, but that would make the JS output system dependent and I didn't like that. Vite doesn't bundle and uses the browser's behavior, which is the dev server path. I'm splitting this from the in-progress PR to implement `new URL(…, import.meta.url)` support. That requires a bunch of changes to the analysis code and a new FS content source, so it's taking longer to ship. Fixes WEB-137. commit 75a7d1e Author: Thomas Knickman <tom.knickman@vercel.com> Date: Thu Dec 1 11:40:15 2022 -0500 fix(examples): cra pnpm fix (#2897) * Merged main * Reverting changes that snuck in * Fixing tests * Final fixes for tests * Moving shim to crates/turborepo * More refactoring * First pass at splitting up shim and cli * Fixing tests * Added detection for help flag so users can get help outside of a valid repo * Update crates/turborepo-lib/src/shim.rs Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Update crates/turborepo/Cargo.toml Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * PR feedback and test fixing * Set process's cwd * Have to do inference even with TURBO_BINARY_PATH * Comments * PR feedback * Moved single_package back to RunArgs * Removed print * Fixing bugs * Fixing rust tests * fixing bug with verbosity and Go tests * add local turbo version checking * remove ffi inclusion * Fixed integration tests * Linting fixes * Integrated local_turbo_supports_skip_shim * Fixed bug with cwd and restored yarn.lock * Okay back to setting current_dir * Fixed bug with canonicalization * Removed print starting Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> Co-authored-by: Florentin / 珞辰 <ecklf@icloud.com> Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> Co-authored-by: Matt Pocock <mattpocockvoice@gmail.com> Co-authored-by: Mehul Kar <mehul.kar@vercel.com> Co-authored-by: Yota Hada <hadayota33@gmail.com> Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
chris-olszewski
added a commit
that referenced
this pull request
Dec 13, 2022
* Created two separate chains for executing commands: One that uses the parsed arguments from clap that are serialized to json, the other that still uses Cobra. Now to test to ensure that both do the same thing * Adjusted json serialization. Now debugging * Hooked up new CLI to commands * Fixing compile error * fixing lint error * Fixing more Go lint errors * Fixing lint errors * fixing up tests * Only using turbo state with link, login, and logout commands * Reverting changes * Removing more changes * Deleting code and fixing lints * Removed unlink command * Fixing bugs * Reverting more changes * fixed all tests * Refactored away duplicates using CLIConfigProvider interface * Lint fixes * Minor order tweak * Added error if command is not handled * PR feedback * Minor fixes. Adding --__test-run flag * Added workaround for subcommand help * Moved logic around to accomodate login/logout/link/unlink * Added some documentation, removed some printf * Adding more tests. * Hooked up link/login/unlink to --__test-run flag. Also added prysk tests for it. * Split up derive into multiple lines * Added comment explaining clap v3 in Cargo.toml * Ported daemon * Cleaning up code. Removed imports * Fix lints * Fixing lints * Ported prune to Rust CLI * Going all the way. Porting run to Rust CLI and upgrading back to clap v4 * Always gotta be testing * Always be testing. Always. Be. Testing. * Added tests for each singular flag. Now for combination tests * WIP: Hooking up Rust CLI to Go run logic * Disable color * Removed root inference from Go side * Fixing compile errors * Update cli/cmd/turbo/main.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Patching up code for run * PR changes * Restored labeler * Restore og.tsx * Reverted run changes that somehow made it in here * Fix run * Update cli/internal/turbostate/turbostate.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * feat: polyfill `global` with `globalThis` (#2666) This PR changes the ecmascript chunk logic to polyfill `global` with `globalThis`. A more complex and less performant solution (but with the benefit of us knowing the runtime environment) would be to add an effect for simple identifier expressions. * delete IsYarn util (#2668) * feat(docs): new authors & consistent filesnames (#2680) * Added caveat to environment variables docs (#2703) Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> * Fix publish workflow (#2681) * change from yarn to pnpm (#2686) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Reverted workflow changes * Fixing tests. Added run args to base * Trying to fix tests * Rewrote some logic around run args handling * Fixing up tests by adding flags and fixing parsing bugs * Hooked up RepoState to Go code * Fixing e2e tests * Fixing e2e * Gotta build shim, not turbo in package.json * Patched integration test * Reverted Cargo.toml * Cargo.lock too * Fixing tests * Moving turbo binary to shim * Fixed tests and CI * Check for TURBO_BINARY_PATH * Ported shell completions to Rust * Fixed logic issue with TURBO_BINARY_PATH * Created .gitignore file with generated rust and header files * Second try on cleaning up generated files * More CI fixes * Realized we still need some inference * Removed files that are edited by run-examples.sh * Switched order of `cargo fmt --check` and `cargo clippy` because `cargo clippy` generates files needed for `cargo fmt --check`. * Cleaning up changes. * Fix one thing break another * Accept integration changes * Deleting more unused code * Test fixes * No longer need this line now that src/ffi.rs is gitignored * PR feedback * Update cli/internal/run/run.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Fixing typo * Merged main * PR feedback * PR feedback * Merge main * Reverted workflow change * Error on invalid unicode instead of lossy conversion * PR feedback * Squashed commit of the following: commit 096b8b8 Author: David Barrat <david@barrat.io> Date: Mon Dec 5 15:29:41 2022 +0100 Docs: Add Authdog to Turbo Showcase page (#2921) [Authdog](https://www.authdog.com/) is an Identity and Access Management as a Service platform, built upon Serverless technologies (AWS Lambda, Vercel, Fastly and Cloudflare Workers). I started looking for alternatives to Nx, some times ago and experimented with Turbo, decided to migrate some projects to this tool, awesome stuff! commit e39d65e Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:23:40 2022 +0100 enable id reusing (#2895) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 6b99818 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:53 2022 +0100 Reduce wrapper tasks by eagerly resolving Vcs (#2933) * resolve codegenerateable before calling it * eagerly resolve some constructors to avoid creating many wrapper tasks Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit ce4c445 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:32 2022 +0100 Share TaskInputs between task cache and task (#2923) Move bound task function into TaskState to allow unloading Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit e1bf5e2 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 14:32:24 2022 +0100 make sure that removing collectibles will cleanup helper entries (#2872) commit 532eff7 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 13:27:22 2022 +0100 Reduce the number of Strings and wrapper tasks (#2834) * use Cow to avoid creating Strings for trait function names * trait calls avoid the resolve trait wrapper task when called on a resolved VC * eagerly resolve some Vc that would otherwise create a lot of wrapper tasks Depends on #2416 commit dc36fc4 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 11:00:10 2022 +0100 reduce number of allocations (#2833) VecDeque::new always allocates 7 elements commit 4f247be Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Mon Dec 5 15:39:15 2022 +0800 Upgrade to Next.js 13 (#2906) This gets our site updated to Next.js 13 and Nextra 2. As a bonus, this should help prevent some of the issues we're seeing in Sentry. commit 1e81806 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 07:42:19 2022 +0100 shrink lists and sets that are stored in Tasks (#2873) Reduces memory usage by 14% commit cac79bb Author: Ahab <ahabhgk@gmail.com> Date: Sun Dec 4 13:23:26 2022 +0800 make lazy bundling for dynamic import more lazy (#2918) For example: ```js // index.js setTimeout(() => { import('./async.js').then(() => console.log('async.js loaded')) }, 1000) ``` ```js // async.js import './async.css'; console.log('async.js content') ``` For now the graph generated by above code will be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 22 24" src="https://user-images.githubusercontent.com/42857895/205442932-ebfd5126-ef3d-4205-b5b5-434126ad46f7.png"> The `ChunkGroup_async` will be a async chunk group of `ChunkGroup_index`, pushed at [turbopack-core/src/chunk/mod.rs#L462](https://github.com/vercel/turbo/blob/b7bcfc312e41367e2ec7f5fb37a6ee88a6b6545a/crates/turbopack-core/src/chunk/mod.rs#L462), and it will have a reference between `ChunkGroup_index` and `ChunkGroup_async`, but `ChunkGroup_async` will also be a chunk group of `ChunkGroup_async-manifest-chunk` created at [turbopack-ecmascript/src/chunk/loader.rs#L165](https://github.com/vercel/turbo/blob/b7bcfc312e41367e2ec7f5fb37a6ee88a6b6545a/crates/turbopack-ecmascript/src/chunk/loader.rs#L165), and will have a reference between `ChunkGroup_async-manifest-chunk` and `ChunkGroup_async`. This leads to when the browser request '/_a8a837.js', turbopack will compile chunks in `ChunkGroup_index` ('/_a8a837.js'), `ChunkGroup_async-manifest-chunk` ('/src_async.js_manifest-chunk.js'), and also chunks in `ChunkGroup_async` ('/src_async.js', '/src_async.css'), because of the reference between `ChunkGroup_index` and `ChunkGroup_async`. But the expected behavior is only compile chunks in `ChunkGroup_index` and `ChunkGroup_async-manifest-chunk`, so this PR deleted the reference between `ChunkGroup_index` and `ChunkGroup_async`, makes the graph be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 50 29" src="https://user-images.githubusercontent.com/42857895/205444165-7b266dce-9aa6-4829-b8dc-d2bf74642aff.png"> And makes chunks in `ChunkGroup_async` to be compiled only when the browser request '/src_async.js_manifest-chunk.js'. commit fd09f2e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 4 03:26:37 2022 +0000 chore(deps): update dependency @types/node to v18.11.10 (#2928) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit 429e91e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 22:21:26 2022 -0500 chore(deps): update dependency @babel/core to v7.20.5 (#2919) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 6478d61 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Sat Dec 3 22:11:10 2022 +0100 update chromiumoxide (#2916) updating in hope that this fixes the random errors in test runs commit b7bcfc3 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 08:54:50 2022 +0000 chore(deps): update rust crate futures to 0.3.25 (#2915) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dev-dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.24` -> `0.3.25` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rust-lang/futures-rs</summary> ### [`v0.3.25`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0325---2022-10-20) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.24...0.3.25) - Fix soundness issue in `join!` and `try_join!` macros ([#​2649](https://togithub.com/rust-lang/futures-rs/issues/2649)) - Implement `Clone` for `sink::Drain` ([#​2650](https://togithub.com/rust-lang/futures-rs/issues/2650)) ### [`v0.3.24`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0324---2022-08-29) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.23...0.3.24) - Fix incorrect termination of `select_with_strategy` streams ([#​2635](https://togithub.com/rust-lang/futures-rs/issues/2635)) ### [`v0.3.23`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0323---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.22...0.3.23) - Work around MSRV increase due to a cargo bug. ### [`v0.3.22`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0322---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.21...0.3.22) - Fix `Sync` impl of `BiLockGuard` ([#​2570](https://togithub.com/rust-lang/futures-rs/issues/2570)) - Fix partial iteration in `FuturesUnordered` ([#​2574](https://togithub.com/rust-lang/futures-rs/issues/2574)) - Fix false detection of inner panics in `Shared` ([#​2576](https://togithub.com/rust-lang/futures-rs/issues/2576)) - Add `Mutex::lock_owned` and `Mutex::try_lock_owned` ([#​2571](https://togithub.com/rust-lang/futures-rs/issues/2571)) - Add `io::copy_buf_abortable` ([#​2507](https://togithub.com/rust-lang/futures-rs/issues/2507)) - Remove `Unpin` bound from `TryStreamExt::into_async_read` ([#​2599](https://togithub.com/rust-lang/futures-rs/issues/2599)) - Make `run_until_stalled` handle self-waking futures ([#​2593](https://togithub.com/rust-lang/futures-rs/issues/2593)) - Use `FuturesOrdered` in `try_join_all` ([#​2556](https://togithub.com/rust-lang/futures-rs/issues/2556)) - Fix orderings in `LocalPool` waker ([#​2608](https://togithub.com/rust-lang/futures-rs/issues/2608)) - Fix `stream::Chunk` adapters size hints ([#​2611](https://togithub.com/rust-lang/futures-rs/issues/2611)) - Add `push_front` and `push_back` to `FuturesOrdered` ([#​2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Deprecate `FuturesOrdered::push` in favor of `FuturesOrdered::push_back` ([#​2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Performance improvements ([#​2583](https://togithub.com/rust-lang/futures-rs/issues/2583), [#​2626](https://togithub.com/rust-lang/futures-rs/issues/2626)) - Documentation improvements ([#​2579](https://togithub.com/rust-lang/futures-rs/issues/2579), [#​2604](https://togithub.com/rust-lang/futures-rs/issues/2604), [#​2613](https://togithub.com/rust-lang/futures-rs/issues/2613)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/vercel/turbo). commit 93222f2 Author: Anthony Shew <anthony.shew@vercel.com> Date: Fri Dec 2 16:36:55 2022 -0800 feat(docs): document topology outside of a task (#2879) * Docs for topology outside of a task Documentation for behavior in #2855! * Minor cleanup. * Some copy updates and add image. Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit f8aaf81 Author: Will Binns-Smith <wbinnssmith@gmail.com> Date: Fri Dec 2 16:32:35 2022 -0800 Link to Turbopack's architecture.md from CONTRIBUTING.md (#2913) commit 0723170 Author: Thomas Knickman <tom.knickman@vercel.com> Date: Fri Dec 2 16:40:08 2022 -0500 feat(docs): add github (#2912) commit c69298c Author: OJ Kwon <1210596+kwonoj@users.noreply.github.com> Date: Fri Dec 2 11:58:55 2022 -0800 build(cargo): update swc_core, dependencies to resolve circular deps (#2869) * build(cargo): bump up swc_core * build(cargo): unpin indexmap * build(cargo): update dependencies * style(cargo): adjust format commit 6965cb8 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 19:42:05 2022 +0100 set correct cwd for server renderer (#2886) commit 4a3cb94 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 18:27:02 2022 +0100 fix dynamic paths (#2884) commit eead906 Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 16:09:08 2022 +0800 Fix the missing links. (#2707) This PR does three things: 1. Prevents double redirects by setting the correct destination the first time. 2. Redirects URLs accidentally recreated in the new scope. 🤦♂️ 3. Removes a catch-all to trigger any additional missing links to appear. Changes are easy to review commit-by-commit. commit b8c0c3c Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 14:37:03 2022 +0800 Update lint-staged behavior. (#2904) Before #2859: `eslint --quiet --fix` After #2859: `pnpm run lint --quiet --fix --` => `eslint . --ext js,jsx,ts,tsx --quiet --fix --` After this: `eslint --ext js,jsx,ts,tsx --quiet --fix --` Removes the sneaky `.`. commit 336ea22 Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 08:33:21 2022 +0800 Add additional detailed warning message if no tasks were run. (#2778) This is a quality of life improvement output log so that you don't have to tease it out from the overall run summary and the situation is more-apparent. commit 9359c46 Author: Leah <github.leah@hrmny.sh> Date: Thu Dec 1 21:02:33 2022 +0100 simplify `next-binding` (#2899) commit 22c1440 Author: Justin Ridgewell <justin@ridgewell.name> Date: Thu Dec 1 13:55:15 2022 -0500 Implement import.meta (#2816) I chose to have the `import.meta.url` to have the relative project path on disk. Webpack makes it the absolute system path, but that would make the JS output system dependent and I didn't like that. Vite doesn't bundle and uses the browser's behavior, which is the dev server path. I'm splitting this from the in-progress PR to implement `new URL(…, import.meta.url)` support. That requires a bunch of changes to the analysis code and a new FS content source, so it's taking longer to ship. Fixes WEB-137. commit 75a7d1e Author: Thomas Knickman <tom.knickman@vercel.com> Date: Thu Dec 1 11:40:15 2022 -0500 fix(examples): cra pnpm fix (#2897) * Merged main * Reverting changes that snuck in * Fixing tests * Final fixes for tests * Moving shim to crates/turborepo * More refactoring * First pass at splitting up shim and cli * Fixing tests * Added detection for help flag so users can get help outside of a valid repo * Update crates/turborepo-lib/src/shim.rs Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Update crates/turborepo/Cargo.toml Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * PR feedback and test fixing * Set process's cwd * Have to do inference even with TURBO_BINARY_PATH * Comments * PR feedback * Moved single_package back to RunArgs * Removed print * Fixing bugs * Fixing rust tests * fixing bug with verbosity and Go tests * add local turbo version checking * remove ffi inclusion * Fixed integration tests * Linting fixes * Integrated local_turbo_supports_skip_shim * Fixed bug with cwd and restored yarn.lock * Okay back to setting current_dir * Fixed bug with canonicalization * Removed print starting * match existing turbo exit codes * pr feedback Co-authored-by: Nicholas Yang <nicholas.yang@vercel.com> Co-authored-by: Nicholas Yang <nick@nicholasyang.com> Co-authored-by: Florentin / 珞辰 <ecklf@icloud.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> Co-authored-by: Matt Pocock <mattpocockvoice@gmail.com> Co-authored-by: Mehul Kar <mehul.kar@vercel.com> Co-authored-by: Yota Hada <hadayota33@gmail.com> Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
* Created two separate chains for executing commands: One that uses the parsed arguments from clap that are serialized to json, the other that still uses Cobra. Now to test to ensure that both do the same thing * Adjusted json serialization. Now debugging * Hooked up new CLI to commands * Fixing compile error * fixing lint error * Fixing more Go lint errors * Fixing lint errors * fixing up tests * Only using turbo state with link, login, and logout commands * Reverting changes * Removing more changes * Deleting code and fixing lints * Removed unlink command * Fixing bugs * Reverting more changes * fixed all tests * Refactored away duplicates using CLIConfigProvider interface * Lint fixes * Minor order tweak * Added error if command is not handled * PR feedback * Minor fixes. Adding --__test-run flag * Added workaround for subcommand help * Moved logic around to accomodate login/logout/link/unlink * Added some documentation, removed some printf * Adding more tests. * Hooked up link/login/unlink to --__test-run flag. Also added prysk tests for it. * Split up derive into multiple lines * Added comment explaining clap v3 in Cargo.toml * Ported daemon * Cleaning up code. Removed imports * Fix lints * Fixing lints * Ported prune to Rust CLI * Going all the way. Porting run to Rust CLI and upgrading back to clap v4 * Always gotta be testing * Always be testing. Always. Be. Testing. * Added tests for each singular flag. Now for combination tests * WIP: Hooking up Rust CLI to Go run logic * Disable color * Removed root inference from Go side * Fixing compile errors * Update cli/cmd/turbo/main.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Patching up code for run * PR changes * Restored labeler * Restore og.tsx * Reverted run changes that somehow made it in here * Fix run * Update cli/internal/turbostate/turbostate.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * feat: polyfill `global` with `globalThis` (vercel/turborepo#2666) This PR changes the ecmascript chunk logic to polyfill `global` with `globalThis`. A more complex and less performant solution (but with the benefit of us knowing the runtime environment) would be to add an effect for simple identifier expressions. * delete IsYarn util (vercel/turborepo#2668) * feat(docs): new authors & consistent filesnames (vercel/turborepo#2680) * Added caveat to environment variables docs (vercel/turborepo#2703) Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> * Fix publish workflow (vercel/turborepo#2681) * change from yarn to pnpm (vercel/turborepo#2686) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Reverted workflow changes * Fixing tests. Added run args to base * Trying to fix tests * Rewrote some logic around run args handling * Fixing up tests by adding flags and fixing parsing bugs * Hooked up RepoState to Go code * Fixing e2e tests * Fixing e2e * Gotta build shim, not turbo in package.json * Patched integration test * Reverted Cargo.toml * Cargo.lock too * Fixing tests * Moving turbo binary to shim * Fixed tests and CI * Check for TURBO_BINARY_PATH * Ported shell completions to Rust * Fixed logic issue with TURBO_BINARY_PATH * Created .gitignore file with generated rust and header files * Second try on cleaning up generated files * More CI fixes * Realized we still need some inference * Removed files that are edited by run-examples.sh * Switched order of `cargo fmt --check` and `cargo clippy` because `cargo clippy` generates files needed for `cargo fmt --check`. * Cleaning up changes. * Fix one thing break another * Accept integration changes * Deleting more unused code * Test fixes * No longer need this line now that src/ffi.rs is gitignored * PR feedback * Update cli/internal/run/run.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Fixing typo * Merged main * PR feedback * PR feedback * Merge main * Reverted workflow change * Error on invalid unicode instead of lossy conversion * PR feedback * Squashed commit of the following: commit 096b8b8b357abe985e4116108af8a87aaba968cb Author: David Barrat <david@barrat.io> Date: Mon Dec 5 15:29:41 2022 +0100 Docs: Add Authdog to Turbo Showcase page (vercel/turborepo#2921) [Authdog](https://www.authdog.com/) is an Identity and Access Management as a Service platform, built upon Serverless technologies (AWS Lambda, Vercel, Fastly and Cloudflare Workers). I started looking for alternatives to Nx, some times ago and experimented with Turbo, decided to migrate some projects to this tool, awesome stuff! commit e39d65eb5b97140fe6338dabfbd0ac3be2987d8f Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:23:40 2022 +0100 enable id reusing (vercel/turborepo#2895) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 6b99818abd358ebb4fa3506b493e2fae34372d25 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:53 2022 +0100 Reduce wrapper tasks by eagerly resolving Vcs (vercel/turborepo#2933) * resolve codegenerateable before calling it * eagerly resolve some constructors to avoid creating many wrapper tasks Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit ce4c445cd2c17021b4397c8e3cf93d91921146ef Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:32 2022 +0100 Share TaskInputs between task cache and task (vercel/turborepo#2923) Move bound task function into TaskState to allow unloading Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit e1bf5e2cde7ca2006c8a4c3455dec38e971aa3eb Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 14:32:24 2022 +0100 make sure that removing collectibles will cleanup helper entries (vercel/turborepo#2872) commit 532eff76326fb9237a450345b45073c1061e5a37 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 13:27:22 2022 +0100 Reduce the number of Strings and wrapper tasks (vercel/turborepo#2834) * use Cow to avoid creating Strings for trait function names * trait calls avoid the resolve trait wrapper task when called on a resolved VC * eagerly resolve some Vc that would otherwise create a lot of wrapper tasks Depends on vercel/turborepo#2416 commit dc36fc41586e5763520b4a16d249cdd6779bc902 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 11:00:10 2022 +0100 reduce number of allocations (vercel/turborepo#2833) VecDeque::new always allocates 7 elements commit 4f247be94b03f44765ac8bd334194545cd992b9b Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Mon Dec 5 15:39:15 2022 +0800 Upgrade to Next.js 13 (vercel/turborepo#2906) This gets our site updated to Next.js 13 and Nextra 2. As a bonus, this should help prevent some of the issues we're seeing in Sentry. commit 1e818068241c308cd3260bd83eba294d890a6151 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 07:42:19 2022 +0100 shrink lists and sets that are stored in Tasks (vercel/turborepo#2873) Reduces memory usage by 14% commit cac79bbe35c5ee7d2bf14625bb709dff8010b8ad Author: Ahab <ahabhgk@gmail.com> Date: Sun Dec 4 13:23:26 2022 +0800 make lazy bundling for dynamic import more lazy (vercel/turborepo#2918) For example: ```js // index.js setTimeout(() => { import('./async.js').then(() => console.log('async.js loaded')) }, 1000) ``` ```js // async.js import './async.css'; console.log('async.js content') ``` For now the graph generated by above code will be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 22 24" src="https://user-images.githubusercontent.com/42857895/205442932-ebfd5126-ef3d-4205-b5b5-434126ad46f7.png"> The `ChunkGroup_async` will be a async chunk group of `ChunkGroup_index`, pushed at [turbopack-core/src/chunk/mod.rs#L462](https://github.com/vercel/turbo/blob/e1a9bcb94d439856982fd7edb522ba3122699f2d/crates/turbopack-core/src/chunk/mod.rs#L462), and it will have a reference between `ChunkGroup_index` and `ChunkGroup_async`, but `ChunkGroup_async` will also be a chunk group of `ChunkGroup_async-manifest-chunk` created at [turbopack-ecmascript/src/chunk/loader.rs#L165](https://github.com/vercel/turbo/blob/e1a9bcb94d439856982fd7edb522ba3122699f2d/crates/turbopack-ecmascript/src/chunk/loader.rs#L165), and will have a reference between `ChunkGroup_async-manifest-chunk` and `ChunkGroup_async`. This leads to when the browser request '/_a8a837.js', turbopack will compile chunks in `ChunkGroup_index` ('/_a8a837.js'), `ChunkGroup_async-manifest-chunk` ('/src_async.js_manifest-chunk.js'), and also chunks in `ChunkGroup_async` ('/src_async.js', '/src_async.css'), because of the reference between `ChunkGroup_index` and `ChunkGroup_async`. But the expected behavior is only compile chunks in `ChunkGroup_index` and `ChunkGroup_async-manifest-chunk`, so this PR deleted the reference between `ChunkGroup_index` and `ChunkGroup_async`, makes the graph be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 50 29" src="https://user-images.githubusercontent.com/42857895/205444165-7b266dce-9aa6-4829-b8dc-d2bf74642aff.png"> And makes chunks in `ChunkGroup_async` to be compiled only when the browser request '/src_async.js_manifest-chunk.js'. commit fd09f2e7cba7bcff030c1f10f31fc0155dd055fe Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 4 03:26:37 2022 +0000 chore(deps): update dependency @types/node to v18.11.10 (vercel/turborepo#2928) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit 429e91eae5c313556fe8cb0bde87ab521e28d7cf Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 22:21:26 2022 -0500 chore(deps): update dependency @babel/core to v7.20.5 (vercel/turborepo#2919) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit c2d5a07dc58a57434cf2aed00a1ce428215f585e Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Sat Dec 3 22:11:10 2022 +0100 update chromiumoxide (vercel/turborepo#2916) updating in hope that this fixes the random errors in test runs commit e1a9bcb94d439856982fd7edb522ba3122699f2d Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 08:54:50 2022 +0000 chore(deps): update rust crate futures to 0.3.25 (vercel/turborepo#2915) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dev-dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.24` -> `0.3.25` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rust-lang/futures-rs</summary> ### [`v0.3.25`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&vercel/turbo#8203;0325---2022-10-20) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.24...0.3.25) - Fix soundness issue in `join!` and `try_join!` macros ([#&vercel/turborepo#8203;2649](https://togithub.com/rust-lang/futures-rs/issues/2649)) - Implement `Clone` for `sink::Drain` ([#&vercel/turborepo#8203;2650](https://togithub.com/rust-lang/futures-rs/issues/2650)) ### [`v0.3.24`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&vercel/turbo#8203;0324---2022-08-29) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.23...0.3.24) - Fix incorrect termination of `select_with_strategy` streams ([#&vercel/turborepo#8203;2635](https://togithub.com/rust-lang/futures-rs/issues/2635)) ### [`v0.3.23`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&vercel/turbo#8203;0323---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.22...0.3.23) - Work around MSRV increase due to a cargo bug. ### [`v0.3.22`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&vercel/turbo#8203;0322---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.21...0.3.22) - Fix `Sync` impl of `BiLockGuard` ([#&vercel/turborepo#8203;2570](https://togithub.com/rust-lang/futures-rs/issues/2570)) - Fix partial iteration in `FuturesUnordered` ([#&vercel/turborepo#8203;2574](https://togithub.com/rust-lang/futures-rs/issues/2574)) - Fix false detection of inner panics in `Shared` ([#&vercel/turborepo#8203;2576](https://togithub.com/rust-lang/futures-rs/issues/2576)) - Add `Mutex::lock_owned` and `Mutex::try_lock_owned` ([#&vercel/turborepo#8203;2571](https://togithub.com/rust-lang/futures-rs/issues/2571)) - Add `io::copy_buf_abortable` ([#&vercel/turborepo#8203;2507](https://togithub.com/rust-lang/futures-rs/issues/2507)) - Remove `Unpin` bound from `TryStreamExt::into_async_read` ([#&vercel/turborepo#8203;2599](https://togithub.com/rust-lang/futures-rs/issues/2599)) - Make `run_until_stalled` handle self-waking futures ([#&vercel/turborepo#8203;2593](https://togithub.com/rust-lang/futures-rs/issues/2593)) - Use `FuturesOrdered` in `try_join_all` ([#&vercel/turborepo#8203;2556](https://togithub.com/rust-lang/futures-rs/issues/2556)) - Fix orderings in `LocalPool` waker ([#&vercel/turborepo#8203;2608](https://togithub.com/rust-lang/futures-rs/issues/2608)) - Fix `stream::Chunk` adapters size hints ([#&vercel/turborepo#8203;2611](https://togithub.com/rust-lang/futures-rs/issues/2611)) - Add `push_front` and `push_back` to `FuturesOrdered` ([#&vercel/turborepo#8203;2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Deprecate `FuturesOrdered::push` in favor of `FuturesOrdered::push_back` ([#&vercel/turborepo#8203;2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Performance improvements ([#&vercel/turborepo#8203;2583](https://togithub.com/rust-lang/futures-rs/issues/2583), [#&vercel/turborepo#8203;2626](https://togithub.com/rust-lang/futures-rs/issues/2626)) - Documentation improvements ([#&vercel/turborepo#8203;2579](https://togithub.com/rust-lang/futures-rs/issues/2579), [#&vercel/turborepo#8203;2604](https://togithub.com/rust-lang/futures-rs/issues/2604), [#&vercel/turborepo#8203;2613](https://togithub.com/rust-lang/futures-rs/issues/2613)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/vercel/turbo). commit 93222f2b22d43bd9c1d917350f810e5398ca9d49 Author: Anthony Shew <anthony.shew@vercel.com> Date: Fri Dec 2 16:36:55 2022 -0800 feat(docs): document topology outside of a task (vercel/turborepo#2879) * Docs for topology outside of a task Documentation for behavior in vercel/turborepo#2855! * Minor cleanup. * Some copy updates and add image. Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit f8aaf81cb7c833f672001eb36d30d700e1cf6cc9 Author: Will Binns-Smith <wbinnssmith@gmail.com> Date: Fri Dec 2 16:32:35 2022 -0800 Link to Turbopack's architecture.md from CONTRIBUTING.md (vercel/turborepo#2913) commit 07231701892cbca7b73e35bfb490f2514770628e Author: Thomas Knickman <tom.knickman@vercel.com> Date: Fri Dec 2 16:40:08 2022 -0500 feat(docs): add github (vercel/turborepo#2912) commit c69298c4a31516129bb62263f163a1da9c5614da Author: OJ Kwon <1210596+kwonoj@users.noreply.github.com> Date: Fri Dec 2 11:58:55 2022 -0800 build(cargo): update swc_core, dependencies to resolve circular deps (vercel/turborepo#2869) * build(cargo): bump up swc_core * build(cargo): unpin indexmap * build(cargo): update dependencies * style(cargo): adjust format commit 6965cb81ef5693b3e7a23e6a999be04d6590fad5 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 19:42:05 2022 +0100 set correct cwd for server renderer (vercel/turborepo#2886) commit 934567015bc99eb8aa80311623e52ea924cbc424 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 18:27:02 2022 +0100 fix dynamic paths (vercel/turborepo#2884) commit eead9063968a3b8571e3ba2c7a897522f890e2fc Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 16:09:08 2022 +0800 Fix the missing links. (vercel/turborepo#2707) This PR does three things: 1. Prevents double redirects by setting the correct destination the first time. 2. Redirects URLs accidentally recreated in the new scope. 🤦♂️ 3. Removes a catch-all to trigger any additional missing links to appear. Changes are easy to review commit-by-commit. commit b8c0c3c74636fd4b0586951011919bc05e1f651d Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 14:37:03 2022 +0800 Update lint-staged behavior. (vercel/turborepo#2904) Before vercel/turborepo#2859: `eslint --quiet --fix` After vercel/turborepo#2859: `pnpm run lint --quiet --fix --` => `eslint . --ext js,jsx,ts,tsx --quiet --fix --` After this: `eslint --ext js,jsx,ts,tsx --quiet --fix --` Removes the sneaky `.`. commit 336ea22098ff8825e83baa2561d8ec0acf5b52af Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 08:33:21 2022 +0800 Add additional detailed warning message if no tasks were run. (vercel/turborepo#2778) This is a quality of life improvement output log so that you don't have to tease it out from the overall run summary and the situation is more-apparent. commit dcb1ab33d1f9571177b9db51e3e0cbbbe8e021e1 Author: Leah <github.leah@hrmny.sh> Date: Thu Dec 1 21:02:33 2022 +0100 simplify `next-binding` (vercel/turborepo#2899) commit 22c1440283ed4dfd1e310210108244c4c12d4c56 Author: Justin Ridgewell <justin@ridgewell.name> Date: Thu Dec 1 13:55:15 2022 -0500 Implement import.meta (vercel/turborepo#2816) I chose to have the `import.meta.url` to have the relative project path on disk. Webpack makes it the absolute system path, but that would make the JS output system dependent and I didn't like that. Vite doesn't bundle and uses the browser's behavior, which is the dev server path. I'm splitting this from the in-progress PR to implement `new URL(…, import.meta.url)` support. That requires a bunch of changes to the analysis code and a new FS content source, so it's taking longer to ship. Fixes WEB-137. commit 75a7d1ea450cdaa629920464b509f3098997ae06 Author: Thomas Knickman <tom.knickman@vercel.com> Date: Thu Dec 1 11:40:15 2022 -0500 fix(examples): cra pnpm fix (vercel/turborepo#2897) * Merged main * Reverting changes that snuck in * Fixing tests * Final fixes for tests * Moving shim to crates/turborepo * More refactoring * First pass at splitting up shim and cli * Fixing tests * Added detection for help flag so users can get help outside of a valid repo * Update crates/turborepo-lib/src/shim.rs Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Update crates/turborepo/Cargo.toml Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * PR feedback and test fixing * Set process's cwd * Have to do inference even with TURBO_BINARY_PATH * Comments * PR feedback * Moved single_package back to RunArgs * Removed print * Fixing bugs * Fixing rust tests * fixing bug with verbosity and Go tests * add local turbo version checking * remove ffi inclusion * Fixed integration tests * Linting fixes * Integrated local_turbo_supports_skip_shim * Fixed bug with cwd and restored yarn.lock * Okay back to setting current_dir * Fixed bug with canonicalization * Removed print starting Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> Co-authored-by: Florentin / 珞辰 <ecklf@icloud.com> Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> Co-authored-by: Matt Pocock <mattpocockvoice@gmail.com> Co-authored-by: Mehul Kar <mehul.kar@vercel.com> Co-authored-by: Yota Hada <hadayota33@gmail.com> Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
* Created two separate chains for executing commands: One that uses the parsed arguments from clap that are serialized to json, the other that still uses Cobra. Now to test to ensure that both do the same thing * Adjusted json serialization. Now debugging * Hooked up new CLI to commands * Fixing compile error * fixing lint error * Fixing more Go lint errors * Fixing lint errors * fixing up tests * Only using turbo state with link, login, and logout commands * Reverting changes * Removing more changes * Deleting code and fixing lints * Removed unlink command * Fixing bugs * Reverting more changes * fixed all tests * Refactored away duplicates using CLIConfigProvider interface * Lint fixes * Minor order tweak * Added error if command is not handled * PR feedback * Minor fixes. Adding --__test-run flag * Added workaround for subcommand help * Moved logic around to accomodate login/logout/link/unlink * Added some documentation, removed some printf * Adding more tests. * Hooked up link/login/unlink to --__test-run flag. Also added prysk tests for it. * Split up derive into multiple lines * Added comment explaining clap v3 in Cargo.toml * Ported daemon * Cleaning up code. Removed imports * Fix lints * Fixing lints * Ported prune to Rust CLI * Going all the way. Porting run to Rust CLI and upgrading back to clap v4 * Always gotta be testing * Always be testing. Always. Be. Testing. * Added tests for each singular flag. Now for combination tests * WIP: Hooking up Rust CLI to Go run logic * Disable color * Removed root inference from Go side * Fixing compile errors * Update cli/cmd/turbo/main.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Patching up code for run * PR changes * Restored labeler * Restore og.tsx * Reverted run changes that somehow made it in here * Fix run * Update cli/internal/turbostate/turbostate.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * feat: polyfill `global` with `globalThis` (vercel/turborepo#2666) This PR changes the ecmascript chunk logic to polyfill `global` with `globalThis`. A more complex and less performant solution (but with the benefit of us knowing the runtime environment) would be to add an effect for simple identifier expressions. * delete IsYarn util (vercel/turborepo#2668) * feat(docs): new authors & consistent filesnames (vercel/turborepo#2680) * Added caveat to environment variables docs (vercel/turborepo#2703) Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> * Fix publish workflow (vercel/turborepo#2681) * change from yarn to pnpm (vercel/turborepo#2686) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Reverted workflow changes * Fixing tests. Added run args to base * Trying to fix tests * Rewrote some logic around run args handling * Fixing up tests by adding flags and fixing parsing bugs * Hooked up RepoState to Go code * Fixing e2e tests * Fixing e2e * Gotta build shim, not turbo in package.json * Patched integration test * Reverted Cargo.toml * Cargo.lock too * Fixing tests * Moving turbo binary to shim * Fixed tests and CI * Check for TURBO_BINARY_PATH * Ported shell completions to Rust * Fixed logic issue with TURBO_BINARY_PATH * Created .gitignore file with generated rust and header files * Second try on cleaning up generated files * More CI fixes * Realized we still need some inference * Removed files that are edited by run-examples.sh * Switched order of `cargo fmt --check` and `cargo clippy` because `cargo clippy` generates files needed for `cargo fmt --check`. * Cleaning up changes. * Fix one thing break another * Accept integration changes * Deleting more unused code * Test fixes * No longer need this line now that src/ffi.rs is gitignored * PR feedback * Update cli/internal/run/run.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Fixing typo * Merged main * PR feedback * PR feedback * Merge main * Reverted workflow change * Error on invalid unicode instead of lossy conversion * PR feedback * Squashed commit of the following: commit 096b8b8b357abe985e4116108af8a87aaba968cb Author: David Barrat <david@barrat.io> Date: Mon Dec 5 15:29:41 2022 +0100 Docs: Add Authdog to Turbo Showcase page (vercel/turborepo#2921) [Authdog](https://www.authdog.com/) is an Identity and Access Management as a Service platform, built upon Serverless technologies (AWS Lambda, Vercel, Fastly and Cloudflare Workers). I started looking for alternatives to Nx, some times ago and experimented with Turbo, decided to migrate some projects to this tool, awesome stuff! commit e39d65eb5b97140fe6338dabfbd0ac3be2987d8f Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:23:40 2022 +0100 enable id reusing (vercel/turborepo#2895) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 6b99818abd358ebb4fa3506b493e2fae34372d25 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:53 2022 +0100 Reduce wrapper tasks by eagerly resolving Vcs (vercel/turborepo#2933) * resolve codegenerateable before calling it * eagerly resolve some constructors to avoid creating many wrapper tasks Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit ce4c445cd2c17021b4397c8e3cf93d91921146ef Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:32 2022 +0100 Share TaskInputs between task cache and task (vercel/turborepo#2923) Move bound task function into TaskState to allow unloading Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit e1bf5e2cde7ca2006c8a4c3455dec38e971aa3eb Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 14:32:24 2022 +0100 make sure that removing collectibles will cleanup helper entries (vercel/turborepo#2872) commit 532eff76326fb9237a450345b45073c1061e5a37 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 13:27:22 2022 +0100 Reduce the number of Strings and wrapper tasks (vercel/turborepo#2834) * use Cow to avoid creating Strings for trait function names * trait calls avoid the resolve trait wrapper task when called on a resolved VC * eagerly resolve some Vc that would otherwise create a lot of wrapper tasks Depends on vercel/turborepo#2416 commit dc36fc41586e5763520b4a16d249cdd6779bc902 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 11:00:10 2022 +0100 reduce number of allocations (vercel/turborepo#2833) VecDeque::new always allocates 7 elements commit 4f247be94b03f44765ac8bd334194545cd992b9b Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Mon Dec 5 15:39:15 2022 +0800 Upgrade to Next.js 13 (vercel/turborepo#2906) This gets our site updated to Next.js 13 and Nextra 2. As a bonus, this should help prevent some of the issues we're seeing in Sentry. commit 1e818068241c308cd3260bd83eba294d890a6151 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 07:42:19 2022 +0100 shrink lists and sets that are stored in Tasks (vercel/turborepo#2873) Reduces memory usage by 14% commit cac79bbe35c5ee7d2bf14625bb709dff8010b8ad Author: Ahab <ahabhgk@gmail.com> Date: Sun Dec 4 13:23:26 2022 +0800 make lazy bundling for dynamic import more lazy (vercel/turborepo#2918) For example: ```js // index.js setTimeout(() => { import('./async.js').then(() => console.log('async.js loaded')) }, 1000) ``` ```js // async.js import './async.css'; console.log('async.js content') ``` For now the graph generated by above code will be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 22 24" src="https://user-images.githubusercontent.com/42857895/205442932-ebfd5126-ef3d-4205-b5b5-434126ad46f7.png"> The `ChunkGroup_async` will be a async chunk group of `ChunkGroup_index`, pushed at [turbopack-core/src/chunk/mod.rs#L462](https://github.com/vercel/turbo/blob/e1a9bcb94d439856982fd7edb522ba3122699f2d/crates/turbopack-core/src/chunk/mod.rs#L462), and it will have a reference between `ChunkGroup_index` and `ChunkGroup_async`, but `ChunkGroup_async` will also be a chunk group of `ChunkGroup_async-manifest-chunk` created at [turbopack-ecmascript/src/chunk/loader.rs#L165](https://github.com/vercel/turbo/blob/e1a9bcb94d439856982fd7edb522ba3122699f2d/crates/turbopack-ecmascript/src/chunk/loader.rs#L165), and will have a reference between `ChunkGroup_async-manifest-chunk` and `ChunkGroup_async`. This leads to when the browser request '/_a8a837.js', turbopack will compile chunks in `ChunkGroup_index` ('/_a8a837.js'), `ChunkGroup_async-manifest-chunk` ('/src_async.js_manifest-chunk.js'), and also chunks in `ChunkGroup_async` ('/src_async.js', '/src_async.css'), because of the reference between `ChunkGroup_index` and `ChunkGroup_async`. But the expected behavior is only compile chunks in `ChunkGroup_index` and `ChunkGroup_async-manifest-chunk`, so this PR deleted the reference between `ChunkGroup_index` and `ChunkGroup_async`, makes the graph be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 50 29" src="https://user-images.githubusercontent.com/42857895/205444165-7b266dce-9aa6-4829-b8dc-d2bf74642aff.png"> And makes chunks in `ChunkGroup_async` to be compiled only when the browser request '/src_async.js_manifest-chunk.js'. commit fd09f2e7cba7bcff030c1f10f31fc0155dd055fe Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 4 03:26:37 2022 +0000 chore(deps): update dependency @types/node to v18.11.10 (vercel/turborepo#2928) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit 429e91eae5c313556fe8cb0bde87ab521e28d7cf Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 22:21:26 2022 -0500 chore(deps): update dependency @babel/core to v7.20.5 (vercel/turborepo#2919) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit c2d5a07dc58a57434cf2aed00a1ce428215f585e Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Sat Dec 3 22:11:10 2022 +0100 update chromiumoxide (vercel/turborepo#2916) updating in hope that this fixes the random errors in test runs commit e1a9bcb94d439856982fd7edb522ba3122699f2d Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 08:54:50 2022 +0000 chore(deps): update rust crate futures to 0.3.25 (vercel/turborepo#2915) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dev-dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.24` -> `0.3.25` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rust-lang/futures-rs</summary> ### [`v0.3.25`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&vercel/turbo#8203;0325---2022-10-20) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.24...0.3.25) - Fix soundness issue in `join!` and `try_join!` macros ([#&vercel/turborepo#8203;2649](https://togithub.com/rust-lang/futures-rs/issues/2649)) - Implement `Clone` for `sink::Drain` ([#&vercel/turborepo#8203;2650](https://togithub.com/rust-lang/futures-rs/issues/2650)) ### [`v0.3.24`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&vercel/turbo#8203;0324---2022-08-29) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.23...0.3.24) - Fix incorrect termination of `select_with_strategy` streams ([#&vercel/turborepo#8203;2635](https://togithub.com/rust-lang/futures-rs/issues/2635)) ### [`v0.3.23`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&vercel/turbo#8203;0323---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.22...0.3.23) - Work around MSRV increase due to a cargo bug. ### [`v0.3.22`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&vercel/turbo#8203;0322---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.21...0.3.22) - Fix `Sync` impl of `BiLockGuard` ([#&vercel/turborepo#8203;2570](https://togithub.com/rust-lang/futures-rs/issues/2570)) - Fix partial iteration in `FuturesUnordered` ([#&vercel/turborepo#8203;2574](https://togithub.com/rust-lang/futures-rs/issues/2574)) - Fix false detection of inner panics in `Shared` ([#&vercel/turborepo#8203;2576](https://togithub.com/rust-lang/futures-rs/issues/2576)) - Add `Mutex::lock_owned` and `Mutex::try_lock_owned` ([#&vercel/turborepo#8203;2571](https://togithub.com/rust-lang/futures-rs/issues/2571)) - Add `io::copy_buf_abortable` ([#&vercel/turborepo#8203;2507](https://togithub.com/rust-lang/futures-rs/issues/2507)) - Remove `Unpin` bound from `TryStreamExt::into_async_read` ([#&vercel/turborepo#8203;2599](https://togithub.com/rust-lang/futures-rs/issues/2599)) - Make `run_until_stalled` handle self-waking futures ([#&vercel/turborepo#8203;2593](https://togithub.com/rust-lang/futures-rs/issues/2593)) - Use `FuturesOrdered` in `try_join_all` ([#&vercel/turborepo#8203;2556](https://togithub.com/rust-lang/futures-rs/issues/2556)) - Fix orderings in `LocalPool` waker ([#&vercel/turborepo#8203;2608](https://togithub.com/rust-lang/futures-rs/issues/2608)) - Fix `stream::Chunk` adapters size hints ([#&vercel/turborepo#8203;2611](https://togithub.com/rust-lang/futures-rs/issues/2611)) - Add `push_front` and `push_back` to `FuturesOrdered` ([#&vercel/turborepo#8203;2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Deprecate `FuturesOrdered::push` in favor of `FuturesOrdered::push_back` ([#&vercel/turborepo#8203;2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Performance improvements ([#&vercel/turborepo#8203;2583](https://togithub.com/rust-lang/futures-rs/issues/2583), [#&vercel/turborepo#8203;2626](https://togithub.com/rust-lang/futures-rs/issues/2626)) - Documentation improvements ([#&vercel/turborepo#8203;2579](https://togithub.com/rust-lang/futures-rs/issues/2579), [#&vercel/turborepo#8203;2604](https://togithub.com/rust-lang/futures-rs/issues/2604), [#&vercel/turborepo#8203;2613](https://togithub.com/rust-lang/futures-rs/issues/2613)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/vercel/turbo). commit 93222f2b22d43bd9c1d917350f810e5398ca9d49 Author: Anthony Shew <anthony.shew@vercel.com> Date: Fri Dec 2 16:36:55 2022 -0800 feat(docs): document topology outside of a task (vercel/turborepo#2879) * Docs for topology outside of a task Documentation for behavior in vercel/turborepo#2855! * Minor cleanup. * Some copy updates and add image. Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit f8aaf81cb7c833f672001eb36d30d700e1cf6cc9 Author: Will Binns-Smith <wbinnssmith@gmail.com> Date: Fri Dec 2 16:32:35 2022 -0800 Link to Turbopack's architecture.md from CONTRIBUTING.md (vercel/turborepo#2913) commit 07231701892cbca7b73e35bfb490f2514770628e Author: Thomas Knickman <tom.knickman@vercel.com> Date: Fri Dec 2 16:40:08 2022 -0500 feat(docs): add github (vercel/turborepo#2912) commit c69298c4a31516129bb62263f163a1da9c5614da Author: OJ Kwon <1210596+kwonoj@users.noreply.github.com> Date: Fri Dec 2 11:58:55 2022 -0800 build(cargo): update swc_core, dependencies to resolve circular deps (vercel/turborepo#2869) * build(cargo): bump up swc_core * build(cargo): unpin indexmap * build(cargo): update dependencies * style(cargo): adjust format commit 6965cb81ef5693b3e7a23e6a999be04d6590fad5 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 19:42:05 2022 +0100 set correct cwd for server renderer (vercel/turborepo#2886) commit 934567015bc99eb8aa80311623e52ea924cbc424 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 18:27:02 2022 +0100 fix dynamic paths (vercel/turborepo#2884) commit eead9063968a3b8571e3ba2c7a897522f890e2fc Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 16:09:08 2022 +0800 Fix the missing links. (vercel/turborepo#2707) This PR does three things: 1. Prevents double redirects by setting the correct destination the first time. 2. Redirects URLs accidentally recreated in the new scope. 🤦♂️ 3. Removes a catch-all to trigger any additional missing links to appear. Changes are easy to review commit-by-commit. commit b8c0c3c74636fd4b0586951011919bc05e1f651d Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 14:37:03 2022 +0800 Update lint-staged behavior. (vercel/turborepo#2904) Before vercel/turborepo#2859: `eslint --quiet --fix` After vercel/turborepo#2859: `pnpm run lint --quiet --fix --` => `eslint . --ext js,jsx,ts,tsx --quiet --fix --` After this: `eslint --ext js,jsx,ts,tsx --quiet --fix --` Removes the sneaky `.`. commit 336ea22098ff8825e83baa2561d8ec0acf5b52af Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 08:33:21 2022 +0800 Add additional detailed warning message if no tasks were run. (vercel/turborepo#2778) This is a quality of life improvement output log so that you don't have to tease it out from the overall run summary and the situation is more-apparent. commit dcb1ab33d1f9571177b9db51e3e0cbbbe8e021e1 Author: Leah <github.leah@hrmny.sh> Date: Thu Dec 1 21:02:33 2022 +0100 simplify `next-binding` (vercel/turborepo#2899) commit 22c1440283ed4dfd1e310210108244c4c12d4c56 Author: Justin Ridgewell <justin@ridgewell.name> Date: Thu Dec 1 13:55:15 2022 -0500 Implement import.meta (vercel/turborepo#2816) I chose to have the `import.meta.url` to have the relative project path on disk. Webpack makes it the absolute system path, but that would make the JS output system dependent and I didn't like that. Vite doesn't bundle and uses the browser's behavior, which is the dev server path. I'm splitting this from the in-progress PR to implement `new URL(…, import.meta.url)` support. That requires a bunch of changes to the analysis code and a new FS content source, so it's taking longer to ship. Fixes WEB-137. commit 75a7d1ea450cdaa629920464b509f3098997ae06 Author: Thomas Knickman <tom.knickman@vercel.com> Date: Thu Dec 1 11:40:15 2022 -0500 fix(examples): cra pnpm fix (vercel/turborepo#2897) * Merged main * Reverting changes that snuck in * Fixing tests * Final fixes for tests * Moving shim to crates/turborepo * More refactoring * First pass at splitting up shim and cli * Fixing tests * Added detection for help flag so users can get help outside of a valid repo * Update crates/turborepo-lib/src/shim.rs Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Update crates/turborepo/Cargo.toml Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * PR feedback and test fixing * Set process's cwd * Have to do inference even with TURBO_BINARY_PATH * Comments * PR feedback * Moved single_package back to RunArgs * Removed print * Fixing bugs * Fixing rust tests * fixing bug with verbosity and Go tests * add local turbo version checking * remove ffi inclusion * Fixed integration tests * Linting fixes * Integrated local_turbo_supports_skip_shim * Fixed bug with cwd and restored yarn.lock * Okay back to setting current_dir * Fixed bug with canonicalization * Removed print starting Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> Co-authored-by: Florentin / 珞辰 <ecklf@icloud.com> Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> Co-authored-by: Matt Pocock <mattpocockvoice@gmail.com> Co-authored-by: Mehul Kar <mehul.kar@vercel.com> Co-authored-by: Yota Hada <hadayota33@gmail.com> Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
Move bound task function into TaskState to allow unloading Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
* Created two separate chains for executing commands: One that uses the parsed arguments from clap that are serialized to json, the other that still uses Cobra. Now to test to ensure that both do the same thing * Adjusted json serialization. Now debugging * Hooked up new CLI to commands * Fixing compile error * fixing lint error * Fixing more Go lint errors * Fixing lint errors * fixing up tests * Only using turbo state with link, login, and logout commands * Reverting changes * Removing more changes * Deleting code and fixing lints * Removed unlink command * Fixing bugs * Reverting more changes * fixed all tests * Refactored away duplicates using CLIConfigProvider interface * Lint fixes * Minor order tweak * Added error if command is not handled * PR feedback * Minor fixes. Adding --__test-run flag * Added workaround for subcommand help * Moved logic around to accomodate login/logout/link/unlink * Added some documentation, removed some printf * Adding more tests. * Hooked up link/login/unlink to --__test-run flag. Also added prysk tests for it. * Split up derive into multiple lines * Added comment explaining clap v3 in Cargo.toml * Ported daemon * Cleaning up code. Removed imports * Fix lints * Fixing lints * Ported prune to Rust CLI * Going all the way. Porting run to Rust CLI and upgrading back to clap v4 * Always gotta be testing * Always be testing. Always. Be. Testing. * Added tests for each singular flag. Now for combination tests * WIP: Hooking up Rust CLI to Go run logic * Disable color * Removed root inference from Go side * Fixing compile errors * Update cli/cmd/turbo/main.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Patching up code for run * PR changes * Restored labeler * Restore og.tsx * Reverted run changes that somehow made it in here * Fix run * Update cli/internal/turbostate/turbostate.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * feat: polyfill `global` with `globalThis` (vercel/turborepo#2666) This PR changes the ecmascript chunk logic to polyfill `global` with `globalThis`. A more complex and less performant solution (but with the benefit of us knowing the runtime environment) would be to add an effect for simple identifier expressions. * delete IsYarn util (vercel/turborepo#2668) * feat(docs): new authors & consistent filesnames (vercel/turborepo#2680) * Added caveat to environment variables docs (vercel/turborepo#2703) Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> * Fix publish workflow (vercel/turborepo#2681) * change from yarn to pnpm (vercel/turborepo#2686) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Reverted workflow changes * Fixing tests. Added run args to base * Trying to fix tests * Rewrote some logic around run args handling * Fixing up tests by adding flags and fixing parsing bugs * Hooked up RepoState to Go code * Fixing e2e tests * Fixing e2e * Gotta build shim, not turbo in package.json * Patched integration test * Reverted Cargo.toml * Cargo.lock too * Fixing tests * Moving turbo binary to shim * Fixed tests and CI * Check for TURBO_BINARY_PATH * Ported shell completions to Rust * Fixed logic issue with TURBO_BINARY_PATH * Created .gitignore file with generated rust and header files * Second try on cleaning up generated files * More CI fixes * Realized we still need some inference * Removed files that are edited by run-examples.sh * Switched order of `cargo fmt --check` and `cargo clippy` because `cargo clippy` generates files needed for `cargo fmt --check`. * Cleaning up changes. * Fix one thing break another * Accept integration changes * Deleting more unused code * Test fixes * No longer need this line now that src/ffi.rs is gitignored * PR feedback * Update cli/internal/run/run.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Fixing typo * Merged main * PR feedback * PR feedback * Merge main * Reverted workflow change * Error on invalid unicode instead of lossy conversion * PR feedback * Squashed commit of the following: commit 096b8b8b357abe985e4116108af8a87aaba968cb Author: David Barrat <david@barrat.io> Date: Mon Dec 5 15:29:41 2022 +0100 Docs: Add Authdog to Turbo Showcase page (vercel/turborepo#2921) [Authdog](https://www.authdog.com/) is an Identity and Access Management as a Service platform, built upon Serverless technologies (AWS Lambda, Vercel, Fastly and Cloudflare Workers). I started looking for alternatives to Nx, some times ago and experimented with Turbo, decided to migrate some projects to this tool, awesome stuff! commit 1a95850 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:23:40 2022 +0100 enable id reusing (vercel/turborepo#2895) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 5bbdedf Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:53 2022 +0100 Reduce wrapper tasks by eagerly resolving Vcs (vercel/turborepo#2933) * resolve codegenerateable before calling it * eagerly resolve some constructors to avoid creating many wrapper tasks Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit ac46ee9 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:32 2022 +0100 Share TaskInputs between task cache and task (vercel/turborepo#2923) Move bound task function into TaskState to allow unloading Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 3940ec1 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 14:32:24 2022 +0100 make sure that removing collectibles will cleanup helper entries (vercel/turborepo#2872) commit a5b70b1 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 13:27:22 2022 +0100 Reduce the number of Strings and wrapper tasks (vercel/turborepo#2834) * use Cow to avoid creating Strings for trait function names * trait calls avoid the resolve trait wrapper task when called on a resolved VC * eagerly resolve some Vc that would otherwise create a lot of wrapper tasks Depends on vercel/turborepo#2416 commit fb3fb5d Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 11:00:10 2022 +0100 reduce number of allocations (vercel/turborepo#2833) VecDeque::new always allocates 7 elements commit 4f247be94b03f44765ac8bd334194545cd992b9b Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Mon Dec 5 15:39:15 2022 +0800 Upgrade to Next.js 13 (vercel/turborepo#2906) This gets our site updated to Next.js 13 and Nextra 2. As a bonus, this should help prevent some of the issues we're seeing in Sentry. commit 8a7051a Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 07:42:19 2022 +0100 shrink lists and sets that are stored in Tasks (vercel/turborepo#2873) Reduces memory usage by 14% commit c4ab57d Author: Ahab <ahabhgk@gmail.com> Date: Sun Dec 4 13:23:26 2022 +0800 make lazy bundling for dynamic import more lazy (vercel/turborepo#2918) For example: ```js // index.js setTimeout(() => { import('./async.js').then(() => console.log('async.js loaded')) }, 1000) ``` ```js // async.js import './async.css'; console.log('async.js content') ``` For now the graph generated by above code will be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 22 24" src="https://user-images.githubusercontent.com/42857895/205442932-ebfd5126-ef3d-4205-b5b5-434126ad46f7.png"> The `ChunkGroup_async` will be a async chunk group of `ChunkGroup_index`, pushed at [turbopack-core/src/chunk/mod.rs#L462](https://github.com/vercel/turbo/blob/9b66fa301aeedd94a4fabc152432904a2ba0e82b/crates/turbopack-core/src/chunk/mod.rs#L462), and it will have a reference between `ChunkGroup_index` and `ChunkGroup_async`, but `ChunkGroup_async` will also be a chunk group of `ChunkGroup_async-manifest-chunk` created at [turbopack-ecmascript/src/chunk/loader.rs#L165](https://github.com/vercel/turbo/blob/9b66fa301aeedd94a4fabc152432904a2ba0e82b/crates/turbopack-ecmascript/src/chunk/loader.rs#L165), and will have a reference between `ChunkGroup_async-manifest-chunk` and `ChunkGroup_async`. This leads to when the browser request '/_a8a837.js', turbopack will compile chunks in `ChunkGroup_index` ('/_a8a837.js'), `ChunkGroup_async-manifest-chunk` ('/src_async.js_manifest-chunk.js'), and also chunks in `ChunkGroup_async` ('/src_async.js', '/src_async.css'), because of the reference between `ChunkGroup_index` and `ChunkGroup_async`. But the expected behavior is only compile chunks in `ChunkGroup_index` and `ChunkGroup_async-manifest-chunk`, so this PR deleted the reference between `ChunkGroup_index` and `ChunkGroup_async`, makes the graph be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 50 29" src="https://user-images.githubusercontent.com/42857895/205444165-7b266dce-9aa6-4829-b8dc-d2bf74642aff.png"> And makes chunks in `ChunkGroup_async` to be compiled only when the browser request '/src_async.js_manifest-chunk.js'. commit fd09f2e7cba7bcff030c1f10f31fc0155dd055fe Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 4 03:26:37 2022 +0000 chore(deps): update dependency @types/node to v18.11.10 (vercel/turborepo#2928) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit 429e91eae5c313556fe8cb0bde87ab521e28d7cf Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 22:21:26 2022 -0500 chore(deps): update dependency @babel/core to v7.20.5 (vercel/turborepo#2919) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 54069b7 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Sat Dec 3 22:11:10 2022 +0100 update chromiumoxide (vercel/turborepo#2916) updating in hope that this fixes the random errors in test runs commit 9b66fa3 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 08:54:50 2022 +0000 chore(deps): update rust crate futures to 0.3.25 (vercel/turborepo#2915) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dev-dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.24` -> `0.3.25` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rust-lang/futures-rs</summary> ### [`v0.3.25`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0325---2022-10-20) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.24...0.3.25) - Fix soundness issue in `join!` and `try_join!` macros ([#​2649](https://togithub.com/rust-lang/futures-rs/issues/2649)) - Implement `Clone` for `sink::Drain` ([#​2650](https://togithub.com/rust-lang/futures-rs/issues/2650)) ### [`v0.3.24`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0324---2022-08-29) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.23...0.3.24) - Fix incorrect termination of `select_with_strategy` streams ([#​2635](https://togithub.com/rust-lang/futures-rs/issues/2635)) ### [`v0.3.23`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0323---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.22...0.3.23) - Work around MSRV increase due to a cargo bug. ### [`v0.3.22`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0322---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.21...0.3.22) - Fix `Sync` impl of `BiLockGuard` ([#​2570](https://togithub.com/rust-lang/futures-rs/issues/2570)) - Fix partial iteration in `FuturesUnordered` ([#​2574](https://togithub.com/rust-lang/futures-rs/issues/2574)) - Fix false detection of inner panics in `Shared` ([#​2576](https://togithub.com/rust-lang/futures-rs/issues/2576)) - Add `Mutex::lock_owned` and `Mutex::try_lock_owned` ([#​2571](https://togithub.com/rust-lang/futures-rs/issues/2571)) - Add `io::copy_buf_abortable` ([#​2507](https://togithub.com/rust-lang/futures-rs/issues/2507)) - Remove `Unpin` bound from `TryStreamExt::into_async_read` ([#​2599](https://togithub.com/rust-lang/futures-rs/issues/2599)) - Make `run_until_stalled` handle self-waking futures ([#​2593](https://togithub.com/rust-lang/futures-rs/issues/2593)) - Use `FuturesOrdered` in `try_join_all` ([#​2556](https://togithub.com/rust-lang/futures-rs/issues/2556)) - Fix orderings in `LocalPool` waker ([#​2608](https://togithub.com/rust-lang/futures-rs/issues/2608)) - Fix `stream::Chunk` adapters size hints ([#​2611](https://togithub.com/rust-lang/futures-rs/issues/2611)) - Add `push_front` and `push_back` to `FuturesOrdered` ([#​2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Deprecate `FuturesOrdered::push` in favor of `FuturesOrdered::push_back` ([#​2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Performance improvements ([#​2583](https://togithub.com/rust-lang/futures-rs/issues/2583), [#​2626](https://togithub.com/rust-lang/futures-rs/issues/2626)) - Documentation improvements ([#​2579](https://togithub.com/rust-lang/futures-rs/issues/2579), [#​2604](https://togithub.com/rust-lang/futures-rs/issues/2604), [#​2613](https://togithub.com/rust-lang/futures-rs/issues/2613)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/vercel/turbo). commit 93222f2b22d43bd9c1d917350f810e5398ca9d49 Author: Anthony Shew <anthony.shew@vercel.com> Date: Fri Dec 2 16:36:55 2022 -0800 feat(docs): document topology outside of a task (vercel/turborepo#2879) * Docs for topology outside of a task Documentation for behavior in #2855! * Minor cleanup. * Some copy updates and add image. Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit f8aaf81cb7c833f672001eb36d30d700e1cf6cc9 Author: Will Binns-Smith <wbinnssmith@gmail.com> Date: Fri Dec 2 16:32:35 2022 -0800 Link to Turbopack's architecture.md from CONTRIBUTING.md (vercel/turborepo#2913) commit 07231701892cbca7b73e35bfb490f2514770628e Author: Thomas Knickman <tom.knickman@vercel.com> Date: Fri Dec 2 16:40:08 2022 -0500 feat(docs): add github (vercel/turborepo#2912) commit 3bff42b Author: OJ Kwon <1210596+kwonoj@users.noreply.github.com> Date: Fri Dec 2 11:58:55 2022 -0800 build(cargo): update swc_core, dependencies to resolve circular deps (vercel/turborepo#2869) * build(cargo): bump up swc_core * build(cargo): unpin indexmap * build(cargo): update dependencies * style(cargo): adjust format commit 1628544 Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 19:42:05 2022 +0100 set correct cwd for server renderer (vercel/turborepo#2886) commit ee21f7f Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 18:27:02 2022 +0100 fix dynamic paths (vercel/turborepo#2884) commit eead9063968a3b8571e3ba2c7a897522f890e2fc Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 16:09:08 2022 +0800 Fix the missing links. (vercel/turborepo#2707) This PR does three things: 1. Prevents double redirects by setting the correct destination the first time. 2. Redirects URLs accidentally recreated in the new scope. 🤦♂️ 3. Removes a catch-all to trigger any additional missing links to appear. Changes are easy to review commit-by-commit. commit b8c0c3c74636fd4b0586951011919bc05e1f651d Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 14:37:03 2022 +0800 Update lint-staged behavior. (vercel/turborepo#2904) Before #2859: `eslint --quiet --fix` After #2859: `pnpm run lint --quiet --fix --` => `eslint . --ext js,jsx,ts,tsx --quiet --fix --` After this: `eslint --ext js,jsx,ts,tsx --quiet --fix --` Removes the sneaky `.`. commit 336ea22098ff8825e83baa2561d8ec0acf5b52af Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 08:33:21 2022 +0800 Add additional detailed warning message if no tasks were run. (vercel/turborepo#2778) This is a quality of life improvement output log so that you don't have to tease it out from the overall run summary and the situation is more-apparent. commit d246dc9 Author: Leah <github.leah@hrmny.sh> Date: Thu Dec 1 21:02:33 2022 +0100 simplify `next-binding` (vercel/turborepo#2899) commit eb93ca6 Author: Justin Ridgewell <justin@ridgewell.name> Date: Thu Dec 1 13:55:15 2022 -0500 Implement import.meta (vercel/turborepo#2816) I chose to have the `import.meta.url` to have the relative project path on disk. Webpack makes it the absolute system path, but that would make the JS output system dependent and I didn't like that. Vite doesn't bundle and uses the browser's behavior, which is the dev server path. I'm splitting this from the in-progress PR to implement `new URL(…, import.meta.url)` support. That requires a bunch of changes to the analysis code and a new FS content source, so it's taking longer to ship. Fixes WEB-137. commit 75a7d1ea450cdaa629920464b509f3098997ae06 Author: Thomas Knickman <tom.knickman@vercel.com> Date: Thu Dec 1 11:40:15 2022 -0500 fix(examples): cra pnpm fix (vercel/turborepo#2897) * Merged main * Reverting changes that snuck in * Fixing tests * Final fixes for tests * Moving shim to crates/turborepo * More refactoring * First pass at splitting up shim and cli * Fixing tests * Added detection for help flag so users can get help outside of a valid repo * Update crates/turborepo-lib/src/shim.rs Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Update crates/turborepo/Cargo.toml Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * PR feedback and test fixing * Set process's cwd * Have to do inference even with TURBO_BINARY_PATH * Comments * PR feedback * Moved single_package back to RunArgs * Removed print * Fixing bugs * Fixing rust tests * fixing bug with verbosity and Go tests * add local turbo version checking * remove ffi inclusion * Fixed integration tests * Linting fixes * Integrated local_turbo_supports_skip_shim * Fixed bug with cwd and restored yarn.lock * Okay back to setting current_dir * Fixed bug with canonicalization * Removed print starting Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> Co-authored-by: Florentin / 珞辰 <ecklf@icloud.com> Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> Co-authored-by: Matt Pocock <mattpocockvoice@gmail.com> Co-authored-by: Mehul Kar <mehul.kar@vercel.com> Co-authored-by: Yota Hada <hadayota33@gmail.com> Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
Move bound task function into TaskState to allow unloading Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
* Created two separate chains for executing commands: One that uses the parsed arguments from clap that are serialized to json, the other that still uses Cobra. Now to test to ensure that both do the same thing * Adjusted json serialization. Now debugging * Hooked up new CLI to commands * Fixing compile error * fixing lint error * Fixing more Go lint errors * Fixing lint errors * fixing up tests * Only using turbo state with link, login, and logout commands * Reverting changes * Removing more changes * Deleting code and fixing lints * Removed unlink command * Fixing bugs * Reverting more changes * fixed all tests * Refactored away duplicates using CLIConfigProvider interface * Lint fixes * Minor order tweak * Added error if command is not handled * PR feedback * Minor fixes. Adding --__test-run flag * Added workaround for subcommand help * Moved logic around to accomodate login/logout/link/unlink * Added some documentation, removed some printf * Adding more tests. * Hooked up link/login/unlink to --__test-run flag. Also added prysk tests for it. * Split up derive into multiple lines * Added comment explaining clap v3 in Cargo.toml * Ported daemon * Cleaning up code. Removed imports * Fix lints * Fixing lints * Ported prune to Rust CLI * Going all the way. Porting run to Rust CLI and upgrading back to clap v4 * Always gotta be testing * Always be testing. Always. Be. Testing. * Added tests for each singular flag. Now for combination tests * WIP: Hooking up Rust CLI to Go run logic * Disable color * Removed root inference from Go side * Fixing compile errors * Update cli/cmd/turbo/main.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Patching up code for run * PR changes * Restored labeler * Restore og.tsx * Reverted run changes that somehow made it in here * Fix run * Update cli/internal/turbostate/turbostate.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * feat: polyfill `global` with `globalThis` (vercel/turborepo#2666) This PR changes the ecmascript chunk logic to polyfill `global` with `globalThis`. A more complex and less performant solution (but with the benefit of us knowing the runtime environment) would be to add an effect for simple identifier expressions. * delete IsYarn util (vercel/turborepo#2668) * feat(docs): new authors & consistent filesnames (vercel/turborepo#2680) * Added caveat to environment variables docs (vercel/turborepo#2703) Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> * Fix publish workflow (vercel/turborepo#2681) * change from yarn to pnpm (vercel/turborepo#2686) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Reverted workflow changes * Fixing tests. Added run args to base * Trying to fix tests * Rewrote some logic around run args handling * Fixing up tests by adding flags and fixing parsing bugs * Hooked up RepoState to Go code * Fixing e2e tests * Fixing e2e * Gotta build shim, not turbo in package.json * Patched integration test * Reverted Cargo.toml * Cargo.lock too * Fixing tests * Moving turbo binary to shim * Fixed tests and CI * Check for TURBO_BINARY_PATH * Ported shell completions to Rust * Fixed logic issue with TURBO_BINARY_PATH * Created .gitignore file with generated rust and header files * Second try on cleaning up generated files * More CI fixes * Realized we still need some inference * Removed files that are edited by run-examples.sh * Switched order of `cargo fmt --check` and `cargo clippy` because `cargo clippy` generates files needed for `cargo fmt --check`. * Cleaning up changes. * Fix one thing break another * Accept integration changes * Deleting more unused code * Test fixes * No longer need this line now that src/ffi.rs is gitignored * PR feedback * Update cli/internal/run/run.go Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Fixing typo * Merged main * PR feedback * PR feedback * Merge main * Reverted workflow change * Error on invalid unicode instead of lossy conversion * PR feedback * Squashed commit of the following: commit 096b8b8b357abe985e4116108af8a87aaba968cb Author: David Barrat <david@barrat.io> Date: Mon Dec 5 15:29:41 2022 +0100 Docs: Add Authdog to Turbo Showcase page (vercel/turborepo#2921) [Authdog](https://www.authdog.com/) is an Identity and Access Management as a Service platform, built upon Serverless technologies (AWS Lambda, Vercel, Fastly and Cloudflare Workers). I started looking for alternatives to Nx, some times ago and experimented with Turbo, decided to migrate some projects to this tool, awesome stuff! commit 35f5ddd Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:23:40 2022 +0100 enable id reusing (vercel/turborepo#2895) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 72e5974 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:53 2022 +0100 Reduce wrapper tasks by eagerly resolving Vcs (vercel/turborepo#2933) * resolve codegenerateable before calling it * eagerly resolve some constructors to avoid creating many wrapper tasks Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit b49617e Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 15:22:32 2022 +0100 Share TaskInputs between task cache and task (vercel/turborepo#2923) Move bound task function into TaskState to allow unloading Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> commit 45166d8 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 14:32:24 2022 +0100 make sure that removing collectibles will cleanup helper entries (vercel/turborepo#2872) commit 11bca9d Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 13:27:22 2022 +0100 Reduce the number of Strings and wrapper tasks (vercel/turborepo#2834) * use Cow to avoid creating Strings for trait function names * trait calls avoid the resolve trait wrapper task when called on a resolved VC * eagerly resolve some Vc that would otherwise create a lot of wrapper tasks Depends on vercel/turborepo#2416 commit 4a0491e Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 11:00:10 2022 +0100 reduce number of allocations (vercel/turborepo#2833) VecDeque::new always allocates 7 elements commit 4f247be94b03f44765ac8bd334194545cd992b9b Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Mon Dec 5 15:39:15 2022 +0800 Upgrade to Next.js 13 (vercel/turborepo#2906) This gets our site updated to Next.js 13 and Nextra 2. As a bonus, this should help prevent some of the issues we're seeing in Sentry. commit b4e8415 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Mon Dec 5 07:42:19 2022 +0100 shrink lists and sets that are stored in Tasks (vercel/turborepo#2873) Reduces memory usage by 14% commit 06b577c Author: Ahab <ahabhgk@gmail.com> Date: Sun Dec 4 13:23:26 2022 +0800 make lazy bundling for dynamic import more lazy (vercel/turborepo#2918) For example: ```js // index.js setTimeout(() => { import('./async.js').then(() => console.log('async.js loaded')) }, 1000) ``` ```js // async.js import './async.css'; console.log('async.js content') ``` For now the graph generated by above code will be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 22 24" src="https://user-images.githubusercontent.com/42857895/205442932-ebfd5126-ef3d-4205-b5b5-434126ad46f7.png"> The `ChunkGroup_async` will be a async chunk group of `ChunkGroup_index`, pushed at [turbopack-core/src/chunk/mod.rs#L462](https://github.com/vercel/turbo/blob/43289f8f036a51c6e8d27473c2a775c253ebdbfa/crates/turbopack-core/src/chunk/mod.rs#L462), and it will have a reference between `ChunkGroup_index` and `ChunkGroup_async`, but `ChunkGroup_async` will also be a chunk group of `ChunkGroup_async-manifest-chunk` created at [turbopack-ecmascript/src/chunk/loader.rs#L165](https://github.com/vercel/turbo/blob/43289f8f036a51c6e8d27473c2a775c253ebdbfa/crates/turbopack-ecmascript/src/chunk/loader.rs#L165), and will have a reference between `ChunkGroup_async-manifest-chunk` and `ChunkGroup_async`. This leads to when the browser request '/_a8a837.js', turbopack will compile chunks in `ChunkGroup_index` ('/_a8a837.js'), `ChunkGroup_async-manifest-chunk` ('/src_async.js_manifest-chunk.js'), and also chunks in `ChunkGroup_async` ('/src_async.js', '/src_async.css'), because of the reference between `ChunkGroup_index` and `ChunkGroup_async`. But the expected behavior is only compile chunks in `ChunkGroup_index` and `ChunkGroup_async-manifest-chunk`, so this PR deleted the reference between `ChunkGroup_index` and `ChunkGroup_async`, makes the graph be like this: <img width="1461" alt="Screen Shot 2022-12-03 at 21 50 29" src="https://user-images.githubusercontent.com/42857895/205444165-7b266dce-9aa6-4829-b8dc-d2bf74642aff.png"> And makes chunks in `ChunkGroup_async` to be compiled only when the browser request '/src_async.js_manifest-chunk.js'. commit fd09f2e7cba7bcff030c1f10f31fc0155dd055fe Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 4 03:26:37 2022 +0000 chore(deps): update dependency @types/node to v18.11.10 (vercel/turborepo#2928) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit 429e91eae5c313556fe8cb0bde87ab521e28d7cf Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 22:21:26 2022 -0500 chore(deps): update dependency @babel/core to v7.20.5 (vercel/turborepo#2919) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 800adb5 Author: Tobias Koppers <tobias.koppers@googlemail.com> Date: Sat Dec 3 22:11:10 2022 +0100 update chromiumoxide (vercel/turborepo#2916) updating in hope that this fixes the random errors in test runs commit 43289f8 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sat Dec 3 08:54:50 2022 +0000 chore(deps): update rust crate futures to 0.3.25 (vercel/turborepo#2915) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dev-dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.21` -> `0.3.25` | | [futures](https://rust-lang.github.io/futures-rs) ([source](https://togithub.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.24` -> `0.3.25` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rust-lang/futures-rs</summary> ### [`v0.3.25`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0325---2022-10-20) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.24...0.3.25) - Fix soundness issue in `join!` and `try_join!` macros ([#​2649](https://togithub.com/rust-lang/futures-rs/issues/2649)) - Implement `Clone` for `sink::Drain` ([#​2650](https://togithub.com/rust-lang/futures-rs/issues/2650)) ### [`v0.3.24`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0324---2022-08-29) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.23...0.3.24) - Fix incorrect termination of `select_with_strategy` streams ([#​2635](https://togithub.com/rust-lang/futures-rs/issues/2635)) ### [`v0.3.23`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0323---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.22...0.3.23) - Work around MSRV increase due to a cargo bug. ### [`v0.3.22`](https://togithub.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0322---2022-08-14) [Compare Source](https://togithub.com/rust-lang/futures-rs/compare/0.3.21...0.3.22) - Fix `Sync` impl of `BiLockGuard` ([#​2570](https://togithub.com/rust-lang/futures-rs/issues/2570)) - Fix partial iteration in `FuturesUnordered` ([#​2574](https://togithub.com/rust-lang/futures-rs/issues/2574)) - Fix false detection of inner panics in `Shared` ([#​2576](https://togithub.com/rust-lang/futures-rs/issues/2576)) - Add `Mutex::lock_owned` and `Mutex::try_lock_owned` ([#​2571](https://togithub.com/rust-lang/futures-rs/issues/2571)) - Add `io::copy_buf_abortable` ([#​2507](https://togithub.com/rust-lang/futures-rs/issues/2507)) - Remove `Unpin` bound from `TryStreamExt::into_async_read` ([#​2599](https://togithub.com/rust-lang/futures-rs/issues/2599)) - Make `run_until_stalled` handle self-waking futures ([#​2593](https://togithub.com/rust-lang/futures-rs/issues/2593)) - Use `FuturesOrdered` in `try_join_all` ([#​2556](https://togithub.com/rust-lang/futures-rs/issues/2556)) - Fix orderings in `LocalPool` waker ([#​2608](https://togithub.com/rust-lang/futures-rs/issues/2608)) - Fix `stream::Chunk` adapters size hints ([#​2611](https://togithub.com/rust-lang/futures-rs/issues/2611)) - Add `push_front` and `push_back` to `FuturesOrdered` ([#​2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Deprecate `FuturesOrdered::push` in favor of `FuturesOrdered::push_back` ([#​2591](https://togithub.com/rust-lang/futures-rs/issues/2591)) - Performance improvements ([#​2583](https://togithub.com/rust-lang/futures-rs/issues/2583), [#​2626](https://togithub.com/rust-lang/futures-rs/issues/2626)) - Documentation improvements ([#​2579](https://togithub.com/rust-lang/futures-rs/issues/2579), [#​2604](https://togithub.com/rust-lang/futures-rs/issues/2604), [#​2613](https://togithub.com/rust-lang/futures-rs/issues/2613)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/vercel/turbo). commit 93222f2b22d43bd9c1d917350f810e5398ca9d49 Author: Anthony Shew <anthony.shew@vercel.com> Date: Fri Dec 2 16:36:55 2022 -0800 feat(docs): document topology outside of a task (vercel/turborepo#2879) * Docs for topology outside of a task Documentation for behavior in #2855! * Minor cleanup. * Some copy updates and add image. Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> commit f8aaf81cb7c833f672001eb36d30d700e1cf6cc9 Author: Will Binns-Smith <wbinnssmith@gmail.com> Date: Fri Dec 2 16:32:35 2022 -0800 Link to Turbopack's architecture.md from CONTRIBUTING.md (vercel/turborepo#2913) commit 07231701892cbca7b73e35bfb490f2514770628e Author: Thomas Knickman <tom.knickman@vercel.com> Date: Fri Dec 2 16:40:08 2022 -0500 feat(docs): add github (vercel/turborepo#2912) commit 7ad988b Author: OJ Kwon <1210596+kwonoj@users.noreply.github.com> Date: Fri Dec 2 11:58:55 2022 -0800 build(cargo): update swc_core, dependencies to resolve circular deps (vercel/turborepo#2869) * build(cargo): bump up swc_core * build(cargo): unpin indexmap * build(cargo): update dependencies * style(cargo): adjust format commit 80699ec Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 19:42:05 2022 +0100 set correct cwd for server renderer (vercel/turborepo#2886) commit 1c4732b Author: Leah <github.leah@hrmny.sh> Date: Fri Dec 2 18:27:02 2022 +0100 fix dynamic paths (vercel/turborepo#2884) commit eead9063968a3b8571e3ba2c7a897522f890e2fc Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 16:09:08 2022 +0800 Fix the missing links. (vercel/turborepo#2707) This PR does three things: 1. Prevents double redirects by setting the correct destination the first time. 2. Redirects URLs accidentally recreated in the new scope. 🤦♂️ 3. Removes a catch-all to trigger any additional missing links to appear. Changes are easy to review commit-by-commit. commit b8c0c3c74636fd4b0586951011919bc05e1f651d Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 14:37:03 2022 +0800 Update lint-staged behavior. (vercel/turborepo#2904) Before #2859: `eslint --quiet --fix` After #2859: `pnpm run lint --quiet --fix --` => `eslint . --ext js,jsx,ts,tsx --quiet --fix --` After this: `eslint --ext js,jsx,ts,tsx --quiet --fix --` Removes the sneaky `.`. commit 336ea22098ff8825e83baa2561d8ec0acf5b52af Author: Nathan Hammond <nathan.hammond@vercel.com> Date: Fri Dec 2 08:33:21 2022 +0800 Add additional detailed warning message if no tasks were run. (vercel/turborepo#2778) This is a quality of life improvement output log so that you don't have to tease it out from the overall run summary and the situation is more-apparent. commit 1040108 Author: Leah <github.leah@hrmny.sh> Date: Thu Dec 1 21:02:33 2022 +0100 simplify `next-binding` (vercel/turborepo#2899) commit e65cc93 Author: Justin Ridgewell <justin@ridgewell.name> Date: Thu Dec 1 13:55:15 2022 -0500 Implement import.meta (vercel/turborepo#2816) I chose to have the `import.meta.url` to have the relative project path on disk. Webpack makes it the absolute system path, but that would make the JS output system dependent and I didn't like that. Vite doesn't bundle and uses the browser's behavior, which is the dev server path. I'm splitting this from the in-progress PR to implement `new URL(…, import.meta.url)` support. That requires a bunch of changes to the analysis code and a new FS content source, so it's taking longer to ship. Fixes WEB-137. commit 75a7d1ea450cdaa629920464b509f3098997ae06 Author: Thomas Knickman <tom.knickman@vercel.com> Date: Thu Dec 1 11:40:15 2022 -0500 fix(examples): cra pnpm fix (vercel/turborepo#2897) * Merged main * Reverting changes that snuck in * Fixing tests * Final fixes for tests * Moving shim to crates/turborepo * More refactoring * First pass at splitting up shim and cli * Fixing tests * Added detection for help flag so users can get help outside of a valid repo * Update crates/turborepo-lib/src/shim.rs Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * Update crates/turborepo/Cargo.toml Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> * PR feedback and test fixing * Set process's cwd * Have to do inference even with TURBO_BINARY_PATH * Comments * PR feedback * Moved single_package back to RunArgs * Removed print * Fixing bugs * Fixing rust tests * fixing bug with verbosity and Go tests * add local turbo version checking * remove ffi inclusion * Fixed integration tests * Linting fixes * Integrated local_turbo_supports_skip_shim * Fixed bug with cwd and restored yarn.lock * Okay back to setting current_dir * Fixed bug with canonicalization * Removed print starting Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com> Co-authored-by: Florentin / 珞辰 <ecklf@icloud.com> Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com> Co-authored-by: Thomas Knickman <tom.knickman@vercel.com> Co-authored-by: Matt Pocock <mattpocockvoice@gmail.com> Co-authored-by: Mehul Kar <mehul.kar@vercel.com> Co-authored-by: Yota Hada <hadayota33@gmail.com> Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move bound task function into TaskState to allow unloading
Fixes WEB-238
cuts memory usage by 9% and allows to unload more memory in case of GC