Export __N_SSG and __N_SSP from the error component #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 10 Ignored Deployments
|
Benchmark for ed19fb3
Click to view full benchmark
|
|
Benchmark for ed19fb3
Click to view full benchmark
|
alexkirsz
force-pushed
the
alexkirsz/web-539-navigating-to-a-404-doesnt-call
branch
from
90e4eb1
to
2dee8b5
Compare
Benchmark for 90c9acf
Click to view full benchmark
|
alexkirsz
force-pushed
the
alexkirsz/web-539-navigating-to-a-404-doesnt-call
branch
from
2dee8b5
to
8ea58f5
Compare
Benchmark for eb73576Click to view benchmark
|
alexkirsz
commented
Feb 6, 2023
| @@ -2,4 +2,5 @@ module.exports = { | |||
| experimental: { | |||
| appDir: true, | |||
| }, | |||
| transpilePackages: ["@turbo/pack-test-harness"], | |||
There was a problem hiding this comment.
Any idea why I need to include this for this test, but it's not necessary for the 404 test?
There was a problem hiding this comment.
This was because these two cases have a tsconfig.json that overrides the top-level tsconfig.json, which includes the test harness in its paths list (hence it's compiled without needing transpilePackages).
sokra
approved these changes
Feb 6, 2023
| @@ -2,4 +2,5 @@ module.exports = { | |||
| experimental: { | |||
| appDir: true, | |||
| }, | |||
| transpilePackages: ["@turbo/pack-test-harness"], | |||
alexkirsz
force-pushed
the
alexkirsz/web-539-navigating-to-a-404-doesnt-call
branch
from
925ee28
to
04e445b
Compare
Failing next.js integration test suitesCommit: c751091 Test summary
✅ Fixed tests: ❌ Newly failed tests: Full test report
Expand output● ReactRefresh › can edit a component without losing state ● ReactRefresh › cyclic dependencies
Expand output● i18n-ignore-rewrite-source-locale with basepath › get public file by skipping locale in rewrite, locale: ● i18n-ignore-rewrite-source-locale with basepath › get public file by skipping locale in rewrite, locale: /en ● i18n-ignore-rewrite-source-locale with basepath › get public file by skipping locale in rewrite, locale: /sv ● i18n-ignore-rewrite-source-locale with basepath › get public file by skipping locale in rewrite, locale: /nl ● i18n-ignore-rewrite-source-locale with basepath › call api by skipping locale in rewrite, locale: ● i18n-ignore-rewrite-source-locale with basepath › call api by skipping locale in rewrite, locale: /en ● i18n-ignore-rewrite-source-locale with basepath › call api by skipping locale in rewrite, locale: /sv ● i18n-ignore-rewrite-source-locale with basepath › call api by skipping locale in rewrite, locale: /nl ● i18n-ignore-rewrite-source-locale with basepath › get _next/static/ files by skipping locale in rewrite, locale: ● i18n-ignore-rewrite-source-locale with basepath › get _next/static/ files by skipping locale in rewrite, locale: /en ● i18n-ignore-rewrite-source-locale with basepath › get _next/static/ files by skipping locale in rewrite, locale: /sv ● i18n-ignore-rewrite-source-locale with basepath › get _next/static/ files by skipping locale in rewrite, locale: /nl
Expand output● Catches Missing getStaticProps › should catch it in dev mode
Expand output● ReactRefreshLogBox turbo › empty _app shows logbox ● ReactRefreshLogBox turbo › empty _document shows logbox ● ReactRefreshLogBox turbo › _app syntax error shows logbox ● ReactRefreshLogBox turbo › _document syntax error shows logbox
Expand output● app-dir alias handling › should handle typescript paths alias correctly ● app-dir alias handling › should resolve css imports from outside with src folder presented
Expand output● bigint API route support › dev mode › should return 200 ● bigint API route support › dev mode › should return the BigInt result text
Expand output● ReactRefresh › can edit a component without losing state ● ReactRefresh › cyclic dependencies
Expand output● i18n-ignore-rewrite-source-locale with basepath › get public file by skipping locale in rewrite, locale: ● i18n-ignore-rewrite-source-locale with basepath › get public file by skipping locale in rewrite, locale: /en ● i18n-ignore-rewrite-source-locale with basepath › get public file by skipping locale in rewrite, locale: /sv ● i18n-ignore-rewrite-source-locale with basepath › get public file by skipping locale in rewrite, locale: /nl ● i18n-ignore-rewrite-source-locale with basepath › call api by skipping locale in rewrite, locale: ● i18n-ignore-rewrite-source-locale with basepath › call api by skipping locale in rewrite, locale: /en ● i18n-ignore-rewrite-source-locale with basepath › call api by skipping locale in rewrite, locale: /sv ● i18n-ignore-rewrite-source-locale with basepath › call api by skipping locale in rewrite, locale: /nl ● i18n-ignore-rewrite-source-locale with basepath › get _next/static/ files by skipping locale in rewrite, locale: ● i18n-ignore-rewrite-source-locale with basepath › get _next/static/ files by skipping locale in rewrite, locale: /en ● i18n-ignore-rewrite-source-locale with basepath › get _next/static/ files by skipping locale in rewrite, locale: /sv ● i18n-ignore-rewrite-source-locale with basepath › get _next/static/ files by skipping locale in rewrite, locale: /nl
Expand output● Catches Missing getStaticProps › should catch it in dev mode
Expand output● ReactRefreshLogBox turbo › empty _app shows logbox ● ReactRefreshLogBox turbo › empty _document shows logbox ● ReactRefreshLogBox turbo › _app syntax error shows logbox ● ReactRefreshLogBox turbo › _document syntax error shows logbox
Expand output● app-dir alias handling › should handle typescript paths alias correctly ● app-dir alias handling › should resolve css imports from outside with src folder presented
Expand output● bigint API route support › dev mode › should return 200 ● bigint API route support › dev mode › should return the BigInt result text |
Benchmark for c751091Click to view benchmark
|
alexkirsz
added
the
pr: automerge
kodiakhq
bot
deleted the
alexkirsz/web-539-navigating-to-a-404-doesnt-call
branch
Benchmark for d09ee7d
Click to view full benchmark
|
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 10, 2023
…49736102+kodiakhq[bot]@users.noreply.github.com> # New Features - vercel/turborepo#3540 - vercel/turborepo#3549 - vercel/turborepo#3465 - vercel/turborepo#3550 - vercel/turborepo#3495 - vercel/turborepo#3624 - vercel/turborepo#3600 - vercel/turborepo#3676 - vercel/turborepo#3689 # Fixes - vercel/turborepo#3437 - vercel/turborepo#3542 - vercel/turborepo#3531 - vercel/turborepo#3552 - vercel/turborepo#3551 - vercel/turborepo#3597 - vercel/turborepo#3644 - vercel/turborepo#3623 - vercel/turborepo#3634 - vercel/turborepo#3574 - vercel/turborepo#3673 - vercel/turborepo#3675 - vercel/turborepo#3723 - vercel/turborepo#3677 - vercel/turborepo#3717 - vercel/turborepo#3701 # Performance Improvements - vercel/turborepo#3361 - vercel/turborepo#3619 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…#3574) `export *` would be preferable once supported.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…#3574) `export *` would be preferable once supported.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…#3574) `export *` would be preferable once supported.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…#3574) `export *` would be preferable once supported.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…#3574) `export *` would be preferable once supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export *would be preferable once supported.