Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show turbopack warnings in error overlay #3465

Merged
merged 7 commits into from
Feb 1, 2023
Merged

show turbopack warnings in error overlay #3465

merged 7 commits into from
Feb 1, 2023

Conversation

ForsakenHarmony
Copy link
Member

No description provided.

@ForsakenHarmony ForsakenHarmony requested a review from a team as a code owner January 25, 2023 14:48
@vercel
Copy link

vercel bot commented Jan 25, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ❌ Failed (Inspect) Feb 1, 2023 at 4:27PM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 4:27PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 4:27PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 1, 2023 at 4:27PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 1, 2023 at 4:27PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 4:27PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 1, 2023 at 4:27PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 4:27PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 4:27PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 1, 2023 at 4:27PM (UTC)

@ForsakenHarmony
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

sokra
sokra approved these changes Jan 25, 2023
View reviewed changes
crates/next-core/js/src/dev/hmr-client.ts Outdated Show resolved Hide resolved
crates/next-core/js/src/overlay/internal/ReactDevOverlay.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Rust tests
  • Rust benchmark tests
  • Formatting

See workflow summary for details

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-432-warnings-in-the-error-overlay branch from b2965b5 to fd5dba7 Compare January 25, 2023 16:06
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-432-warnings-in-the-error-overlay branch from fd5dba7 to 06b3173 Compare January 30, 2023 16:00
@ForsakenHarmony ForsakenHarmony enabled auto-merge (squash) January 30, 2023 16:16
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-432-warnings-in-the-error-overlay branch from 06b3173 to 34181dc Compare January 30, 2023 19:08
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-432-warnings-in-the-error-overlay branch from 34181dc to cfa8efd Compare February 1, 2023 16:23
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-432-warnings-in-the-error-overlay branch from cfa8efd to e523595 Compare February 1, 2023 16:26
@vercel vercel deleted a comment from github-actions bot Feb 1, 2023
@vercel vercel deleted a comment from github-actions bot Feb 1, 2023
@vercel vercel deleted a comment from github-actions bot Feb 1, 2023
@vercel vercel deleted a comment from github-actions bot Feb 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Benchmark for 2788d95

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8822.38µs ± 65.67µs 8801.25µs ± 80.16µs -0.24%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9210.77µs ± 58.35µs 9159.86µs ± 71.67µs -0.55%
bench_hmr_to_commit/Turbopack RSC/1000 modules 478.76ms ± 2.30ms 471.15ms ± 2.50ms -1.59%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9155.57µs ± 59.52µs 8998.85µs ± 85.16µs -1.71%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7944.96µs ± 41.53µs 8112.12µs ± 95.09µs +2.10%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8100.60µs ± 75.29µs 8210.94µs ± 63.20µs +1.36%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8206.44µs ± 63.49µs 8160.12µs ± 63.24µs -0.56%
bench_hydration/Turbopack RCC/1000 modules 3714.04ms ± 14.03ms 3703.88ms ± 21.81ms -0.27%
bench_hydration/Turbopack RSC/1000 modules 3224.32ms ± 14.60ms 3249.82ms ± 19.90ms +0.79%
bench_hydration/Turbopack SSR/1000 modules 3004.93ms ± 15.51ms 3036.26ms ± 11.18ms +1.04%
bench_startup/Turbopack CSR/1000 modules 2046.15ms ± 9.47ms 2065.62ms ± 21.26ms +0.95%
bench_startup/Turbopack RCC/1000 modules 2470.90ms ± 10.02ms 2470.15ms ± 6.19ms -0.03%
bench_startup/Turbopack RSC/1000 modules 2364.23ms ± 8.07ms 2367.27ms ± 7.97ms +0.13%
bench_startup/Turbopack SSR/1000 modules 2017.36ms ± 4.97ms 2021.93ms ± 3.41ms +0.23%

@ForsakenHarmony ForsakenHarmony merged commit 89d0100 into main Feb 1, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/web-432-warnings-in-the-error-overlay branch February 1, 2023 17:45
@jridgewell jridgewell mentioned this pull request Feb 10, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 10, 2023
@Brooooooklyn @kodiakhq
Update turbopack to 230209.02 (#45776)Co-authored-by: kodiakhq[bot] <…
946ccb0 
…49736102+kodiakhq[bot]@users.noreply.github.com>

# New Features
- vercel/turborepo#3540
- vercel/turborepo#3549
- vercel/turborepo#3465
- vercel/turborepo#3550
- vercel/turborepo#3495
- vercel/turborepo#3624
- vercel/turborepo#3600
- vercel/turborepo#3676
- vercel/turborepo#3689

# Fixes

- vercel/turborepo#3437
- vercel/turborepo#3542
- vercel/turborepo#3531
- vercel/turborepo#3552
- vercel/turborepo#3551
- vercel/turborepo#3597
- vercel/turborepo#3644
- vercel/turborepo#3623
- vercel/turborepo#3634
- vercel/turborepo#3574
- vercel/turborepo#3673
- vercel/turborepo#3675
- vercel/turborepo#3723
- vercel/turborepo#3677
- vercel/turborepo#3717
- vercel/turborepo#3701

# Performance Improvements

- vercel/turborepo#3361 
- vercel/turborepo#3619

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@ForsakenHarmony
show turbopack warnings in error overlay (vercel/turborepo#3465)
d518777
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@ForsakenHarmony
show turbopack warnings in error overlay (vercel/turborepo#3465)
0e28913
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@ForsakenHarmony
show turbopack warnings in error overlay (vercel/turborepo#3465)
48b76f7
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
show turbopack warnings in error overlay (vercel/turborepo#3465)
eb83a0d
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@ForsakenHarmony
show turbopack warnings in error overlay (vercel/turborepo#3465)
129d27b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@sokra sokra sokra approved these changes

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ForsakenHarmony @jridgewell @sokra @alexkirsz