Unwrap sequence await callee in analyzer #3623

Brooooooklyn · 2023-02-03T14:16:55Z

vercel · 2023-02-03T14:17:06Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
examples-cra-web	🔄 Building (Inspect)	Visit Preview	Feb 4, 2023 at 4:15PM (UTC)
examples-native-web	🔄 Building (Inspect)	Visit Preview	Feb 4, 2023 at 4:15PM (UTC)
examples-vite-web	🔄 Building (Inspect)	Visit Preview	Feb 4, 2023 at 4:15PM (UTC)

7 Ignored Deployments

Name	Status	Preview	Updated
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Feb 4, 2023 at 4:15PM (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Feb 4, 2023 at 4:15PM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Feb 4, 2023 at 4:15PM (UTC)
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Feb 4, 2023 at 4:15PM (UTC)
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Feb 4, 2023 at 4:15PM (UTC)
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Feb 4, 2023 at 4:15PM (UTC)
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Feb 4, 2023 at 4:15PM (UTC)

sokra

It would be great to have an node-file-trace test case for that

github-actions · 2023-02-03T16:35:40Z

Benchmark for `da6bfbb`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	9828.65µs ± 69.46µs	9905.36µs ± 50.58µs	+0.78%
bench_hmr_to_commit/Turbopack RCC/1000 modules	10.11ms ± 0.08ms	10.14ms ± 0.08ms	+0.25%
bench_hmr_to_commit/Turbopack RSC/1000 modules	497.36ms ± 2.53ms	502.01ms ± 1.87ms	+0.93%
bench_hmr_to_commit/Turbopack SSR/1000 modules	10.09ms ± 0.08ms	10.06ms ± 0.10ms	-0.28%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8753.73µs ± 50.35µs	8866.39µs ± 82.96µs	+1.29%
bench_hmr_to_eval/Turbopack RCC/1000 modules	9107.64µs ± 56.73µs	9156.80µs ± 58.53µs	+0.54%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8959.70µs ± 87.96µs	8973.73µs ± 85.52µs	+0.16%
bench_hydration/Turbopack RCC/1000 modules	4539.71ms ± 45.08ms	4478.87ms ± 35.92ms	-1.34%
bench_hydration/Turbopack RSC/1000 modules	4083.87ms ± 10.26ms	4058.69ms ± 12.25ms	-0.62%
bench_hydration/Turbopack SSR/1000 modules	3813.21ms ± 27.51ms	3787.69ms ± 36.01ms	-0.67%
bench_startup/Turbopack CSR/1000 modules	2704.02ms ± 4.87ms	2695.52ms ± 13.19ms	-0.31%
bench_startup/Turbopack RCC/1000 modules	2898.43ms ± 6.53ms	2898.41ms ± 5.93ms	-0.00%
bench_startup/Turbopack RSC/1000 modules	2831.72ms ± 7.04ms	2855.63ms ± 9.35ms	+0.84%
bench_startup/Turbopack SSR/1000 modules	2326.30ms ± 6.32ms	2323.90ms ± 7.36ms	-0.10%

github-actions · 2023-02-03T18:22:34Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests

See workflow summary for details

github-actions · 2023-02-04T14:48:40Z

Benchmark for `e741f7b`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	9986.10µs ± 77.99µs	10.07ms ± 0.08ms	+0.82%
bench_hmr_to_commit/Turbopack RCC/1000 modules	10.23ms ± 0.08ms	10.16ms ± 0.09ms	-0.70%
bench_hmr_to_commit/Turbopack RSC/1000 modules	500.31ms ± 2.45ms	500.31ms ± 3.26ms	-0.00%
bench_hmr_to_commit/Turbopack SSR/1000 modules	10.14ms ± 0.07ms	10.11ms ± 0.09ms	-0.30%
bench_hmr_to_eval/Turbopack CSR/1000 modules	9005.38µs ± 102.81µs	8945.31µs ± 67.92µs	-0.67%
bench_hmr_to_eval/Turbopack RCC/1000 modules	9224.00µs ± 78.03µs	9231.54µs ± 83.76µs	+0.08%
bench_hmr_to_eval/Turbopack SSR/1000 modules	9153.42µs ± 102.69µs	9121.11µs ± 64.71µs	-0.35%
bench_hydration/Turbopack RCC/1000 modules	4281.63ms ± 6.75ms	4295.94ms ± 11.51ms	+0.33%
bench_hydration/Turbopack RSC/1000 modules	3864.81ms ± 13.76ms	3872.09ms ± 14.44ms	+0.19%
bench_hydration/Turbopack SSR/1000 modules	3707.89ms ± 8.90ms	3698.98ms ± 10.36ms	-0.24%
bench_startup/Turbopack CSR/1000 modules	2806.06ms ± 9.97ms	2782.29ms ± 18.60ms	-0.85%
bench_startup/Turbopack RCC/1000 modules	2600.92ms ± 6.01ms	2593.96ms ± 6.57ms	-0.27%
bench_startup/Turbopack RSC/1000 modules	2490.75ms ± 10.59ms	2498.48ms ± 7.64ms	+0.31%
bench_startup/Turbopack SSR/1000 modules	2073.60ms ± 2.60ms	2073.13ms ± 2.65ms	-0.02%

github-actions · 2023-02-04T17:30:37Z

Benchmark for `31061cc`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	2804.68ms ± 12.10ms	2762.31ms ± 7.01ms	-1.51%	-0.15%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	9533.97µs ± 54.95µs	9562.18µs ± 68.45µs	+0.30%
bench_hmr_to_commit/Turbopack RCC/1000 modules	9755.89µs ± 94.88µs	9809.83µs ± 73.32µs	+0.55%
bench_hmr_to_commit/Turbopack RSC/1000 modules	491.86ms ± 1.80ms	491.05ms ± 1.60ms	-0.16%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9677.09µs ± 90.77µs	9656.61µs ± 98.86µs	-0.21%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8512.78µs ± 63.96µs	8573.82µs ± 86.51µs	+0.72%
bench_hmr_to_eval/Turbopack RCC/1000 modules	8810.12µs ± 79.22µs	8713.76µs ± 118.03µs	-1.09%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8604.99µs ± 75.48µs	8725.24µs ± 86.82µs	+1.40%
bench_hydration/Turbopack RCC/1000 modules	4224.39ms ± 10.99ms	4214.50ms ± 13.18ms	-0.23%
bench_hydration/Turbopack RSC/1000 modules	3830.04ms ± 9.97ms	3816.43ms ± 16.27ms	-0.36%
bench_hydration/Turbopack SSR/1000 modules	3671.11ms ± 5.37ms	3671.57ms ± 9.04ms	+0.01%
bench_startup/Turbopack CSR/1000 modules	2804.68ms ± 12.10ms	2762.31ms ± 7.01ms	-1.51%	-0.15%
bench_startup/Turbopack RCC/1000 modules	2569.14ms ± 6.68ms	2575.12ms ± 3.69ms	+0.23%
bench_startup/Turbopack RSC/1000 modules	2469.16ms ± 7.72ms	2460.56ms ± 8.15ms	-0.35%
bench_startup/Turbopack SSR/1000 modules	2058.09ms ± 2.46ms	2055.70ms ± 1.44ms	-0.12%

sokra · 2023-02-06T14:38:37Z

crates/turbopack-ecmascript/src/analyzer/graph.rs

@@ -449,6 +449,8 @@ impl EvalContext {
                SyntaxContext::empty(),
            )),

+            Expr::Await(AwaitExpr { arg, .. }) => self.eval(arg),


Technically it's not super correct. e. g. (await { then: () => ({ v: 42 }), v: 43 }).v evaluates to 43 instead of 42, but I'm fine with that for now...

…49736102+kodiakhq[bot]@users.noreply.github.com> # New Features - vercel/turbo#3540 - vercel/turbo#3549 - vercel/turbo#3465 - vercel/turbo#3550 - vercel/turbo#3495 - vercel/turbo#3624 - vercel/turbo#3600 - vercel/turbo#3676 - vercel/turbo#3689 # Fixes - vercel/turbo#3437 - vercel/turbo#3542 - vercel/turbo#3531 - vercel/turbo#3552 - vercel/turbo#3551 - vercel/turbo#3597 - vercel/turbo#3644 - vercel/turbo#3623 - vercel/turbo#3634 - vercel/turbo#3574 - vercel/turbo#3673 - vercel/turbo#3675 - vercel/turbo#3723 - vercel/turbo#3677 - vercel/turbo#3717 - vercel/turbo#3701 # Performance Improvements - vercel/turbo#3361 - vercel/turbo#3619 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Brooooooklyn requested a review from a team as a code owner February 3, 2023 14:16

github-actions bot added the area: turbopack label Feb 3, 2023

sokra requested changes Feb 3, 2023

View reviewed changes

Brooooooklyn force-pushed the sequence-callee branch from f2cb7cb to 7acbcdc Compare February 3, 2023 15:18

Brooooooklyn requested a review from sokra February 3, 2023 15:18

Brooooooklyn added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 3, 2023

vercel bot deployed to Preview – examples-vite-web February 4, 2023 13:32 View deployment

vercel bot deployed to Preview – examples-tailwind-web February 4, 2023 13:32 View deployment

vercel bot deployed to Preview – examples-basic-web February 4, 2023 13:32 View deployment

vercel bot deployed to Preview – examples-native-web February 4, 2023 13:32 View deployment

vercel bot deployed to Preview – examples-svelte-web February 4, 2023 13:32 View deployment

vercel bot deployed to Preview – examples-designsystem-docs February 4, 2023 13:32 View deployment

vercel bot deployed to Preview – examples-kitchensink-blog February 4, 2023 13:32 View deployment

vercel bot deployed to Preview – examples-cra-web February 4, 2023 13:32 View deployment

vercel bot deployed to Preview – examples-nonmonorepo February 4, 2023 13:33 View deployment

Brooooooklyn added 3 commits February 4, 2023 23:14

Unwrap sequence await callee in analyzer

d48018d

Add node-file-trace test cases

0685ab7

Update fixture

53193bd

Brooooooklyn force-pushed the sequence-callee branch from c614575 to 53193bd Compare February 4, 2023 15:53

vercel bot deployed to Preview – turbo-site February 4, 2023 15:54 View deployment

Clippy

2f1d688

sokra approved these changes Feb 6, 2023

View reviewed changes

Brooooooklyn merged commit ae76b11 into main Feb 6, 2023

Brooooooklyn deleted the sequence-callee branch February 6, 2023 16:54

jridgewell mentioned this pull request Feb 10, 2023

Update turbopack to 230209.02 vercel/next.js#45776

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unwrap sequence await callee in analyzer #3623

Unwrap sequence await callee in analyzer #3623

Brooooooklyn commented Feb 3, 2023

vercel bot commented Feb 3, 2023 •

edited

Loading

sokra left a comment

github-actions bot commented Feb 3, 2023

github-actions bot commented Feb 3, 2023 •

edited

Loading

github-actions bot commented Feb 4, 2023

github-actions bot commented Feb 4, 2023

sokra Feb 6, 2023

Unwrap sequence await callee in analyzer #3623

Unwrap sequence await callee in analyzer #3623

Conversation

Brooooooklyn commented Feb 3, 2023

vercel bot commented Feb 3, 2023 • edited Loading

sokra left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 3, 2023

Benchmark for da6bfbb

github-actions bot commented Feb 3, 2023 • edited Loading

⚠️ CI failed ⚠️

github-actions bot commented Feb 4, 2023

Benchmark for e741f7b

github-actions bot commented Feb 4, 2023

Benchmark for 31061cc

sokra Feb 6, 2023

Choose a reason for hiding this comment

vercel bot commented Feb 3, 2023 •

edited

Loading

Benchmark for `da6bfbb`

github-actions bot commented Feb 3, 2023 •

edited

Loading

Benchmark for `e741f7b`

Benchmark for `31061cc`