Next Router Middleware Support #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
|
Benchmark for 7452089
Click to view full benchmark
|
sokra
requested changes
Feb 8, 2023
sokra
requested changes
Feb 8, 2023
alexkirsz
approved these changes
Feb 8, 2023
jridgewell
force-pushed
the
jrl-middleware-compile
branch
from
24afad8
to
667421f
Compare
|
Added tests (and addressed some review comments), but the tests are failing because Next.js doesn't handle the middleware yet. |
Benchmark for 84aaa14
Click to view full benchmark
|
sokra
reviewed
Feb 9, 2023
Benchmark for c317177
Click to view full benchmark
|
jridgewell
force-pushed
the
jrl-middleware-compile
branch
from
fd6d752
to
5b6ccbe
Compare
Benchmark for e537c77
Click to view full benchmark
|
sokra
approved these changes
Feb 11, 2023
Benchmark for 3a15a31
Click to view full benchmark
|
ijjk
reviewed
Feb 15, 2023
| return await makeResolver(dir, nextConfig); | ||
| const edgeInfo = { | ||
| name: "edge", | ||
| paths: middlewareChunkGroup.map((chunk: string) => |
There was a problem hiding this comment.
Shouldn't this be called files and be relative to the distDir to match our middleware plugin
x-ref: https://github.com/vercel/next.js/blob/7d8f85bd8dbd767dfac0d92eed651877268e62cb/packages/next/src/build/webpack/plugins/middleware-plugin.ts#L35
There was a problem hiding this comment.
I copied this from
turbo/crates/next-core/js/src/entry/server-edge-api.tsx
Lines 53 to 59 in 805a5ae
There was a problem hiding this comment.
I aligned with the return value of getEdgeFunctionInfo, which converts the format in the manifest file into one with paths
So when this info object is provided it could skip calling getEdgeFunctionInfo.
There was a problem hiding this comment.
I see, yeah aligning on that return type seems alright
|
Removing the test case while we wait on Next to land the middleware changes. Once we update to the next release, I'll readd the test. |
jridgewell
force-pushed
the
jrl-middleware-compile
branch
from
782ac89
to
618617c
Compare
jridgewell
added
the
pr: automerge
Benchmark for f005173
Click to view full benchmark
|
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 21, 2023
…jjsweb.site> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> # New Features - vercel/turbo#3771 - vercel/turbo#3690 # Performance - vercel/turbo#3768 # Fixes - vercel/turbo#3795 - vercel/turbo#3746 - vercel/turbo#3832 - vercel/turbo#3827 - vercel/turbo#3847 # Other - vercel/turbo#3803 - vercel/turbo#3685 - vercel/turbo#3848 --------- Co-authored-by: JJ Kasper <jj@jjsweb.site> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our Next.js router, passing the
edgeInfomanifest generated from themiddleware.jsfile (or any other configured page extension).Fixes WEB-277
Fixes WEB-370