Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip UNC prefix on windows paths #3847

Merged
merged 2 commits into from
Feb 17, 2023
Merged

strip UNC prefix on windows paths #3847

merged 2 commits into from
Feb 17, 2023

Conversation

ForsakenHarmony
Copy link
Member

No description provided.

@ForsakenHarmony ForsakenHarmony requested review from a team as code owners February 16, 2023 21:25
@vercel
Copy link

vercel bot commented Feb 16, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

10 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 16, 2023 at 11:35PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 16, 2023 at 11:35PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 16, 2023 at 11:35PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 16, 2023 at 11:35PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 16, 2023 at 11:35PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 16, 2023 at 11:35PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 16, 2023 at 11:35PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 16, 2023 at 11:35PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 16, 2023 at 11:35PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 16, 2023 at 11:35PM (UTC)

jridgewell
jridgewell approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove is_windows_raw_path in crates/turbo-tasks-fs/src/lib.rs and replace it with dunce?

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-602-strip-unc-paths-on-windows branch from 600b2fe to 2fe4241 Compare February 16, 2023 21:34
@ForsakenHarmony
Copy link
Member Author

@jridgewell good point, I think we can and I just did

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-602-strip-unc-paths-on-windows branch from 74155da to 2e44857 Compare February 16, 2023 22:22
@ForsakenHarmony
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/web-602-strip-unc-paths-on-windows branch from 2e44857 to c5285d8 Compare February 16, 2023 23:34
@ForsakenHarmony ForsakenHarmony enabled auto-merge (squash) February 16, 2023 23:35
@ForsakenHarmony ForsakenHarmony merged commit c2dc79a into main Feb 17, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/web-602-strip-unc-paths-on-windows branch February 17, 2023 00:01
@github-actions
Copy link
Contributor

Benchmark for 065e993

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9402.66µs ± 58.24µs 9413.83µs ± 69.25µs +0.12%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.54ms ± 0.30ms 12.41ms ± 0.28ms -1.02%
bench_hmr_to_commit/Turbopack RSC/1000 modules 503.38ms ± 1.50ms 503.70ms ± 0.91ms +0.06%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9598.17µs ± 73.17µs 9589.32µs ± 102.24µs -0.09%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8482.82µs ± 79.04µs 8492.76µs ± 90.19µs +0.12%
bench_hmr_to_eval/Turbopack RCC/1000 modules 10.95ms ± 0.37ms 10.60ms ± 0.17ms -3.25%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8579.91µs ± 82.69µs 8605.81µs ± 73.80µs +0.30%
bench_hydration/Turbopack RCC/1000 modules 3770.72ms ± 28.25ms 3800.62ms ± 31.13ms +0.79%
bench_hydration/Turbopack RSC/1000 modules 3333.75ms ± 7.47ms 3345.79ms ± 15.10ms +0.36%
bench_hydration/Turbopack SSR/1000 modules 3453.39ms ± 14.90ms 3462.55ms ± 15.03ms +0.27%
bench_startup/Turbopack CSR/1000 modules 2708.91ms ± 9.93ms 2679.50ms ± 9.66ms -1.09%
bench_startup/Turbopack RCC/1000 modules 2237.37ms ± 4.05ms 2238.08ms ± 2.34ms +0.03%
bench_startup/Turbopack RSC/1000 modules 2169.37ms ± 6.14ms 2170.37ms ± 4.95ms +0.05%
bench_startup/Turbopack SSR/1000 modules 2058.15ms ± 1.43ms 2065.17ms ± 2.35ms +0.34%

@jridgewell jridgewell mentioned this pull request Feb 17, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 21, 2023
@jridgewell @ijjk @sokra
build(cargo): update turbopack (#46013)Co-authored-by: JJ Kasper <jj@…
a1abeaf 
…jjsweb.site> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>

# New Features
- vercel/turbo#3771
- vercel/turbo#3690

# Performance
- vercel/turbo#3768

# Fixes
- vercel/turbo#3795
- vercel/turbo#3746
- vercel/turbo#3832
- vercel/turbo#3827
- vercel/turbo#3847

# Other
- vercel/turbo#3803
- vercel/turbo#3685
- vercel/turbo#3848

---------

Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@sokra sokra mentioned this pull request Feb 21, 2023
Closed
@wbinnssmith wbinnssmith mentioned this pull request Feb 21, 2023
Merged
ijjk pushed a commit to vercel/next.js that referenced this pull request Feb 21, 2023
@wbinnssmith
Update Turbopack to turbopack-230221.3 (#46209
4bfb923 
# Performance Improvements:
* vercel/turbo#3849
* vercel/turbo#3878
* vercel/turbo#3864

# Misc:
* vercel/turbo#3847
* vercel/turbo#3865
* vercel/turbo#3850
* vercel/turbo#3861
* vercel/turbo#3823
* vercel/turbo#3882

# Contributing
* Update profiling instructions for macOS
([#3837](vercel/turbo#3837))
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@ForsakenHarmony
strip UNC prefix on windows paths (vercel/turbo#3847)
4882417
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@ForsakenHarmony
strip UNC prefix on windows paths (vercel/turbo#3847)
2f466eb
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@wbinnssmith wbinnssmith wbinnssmith approved these changes

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond was automatically assigned from vercel/turbo-oss

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski was automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ForsakenHarmony @jridgewell @wbinnssmith