Restore Issue Reporters #3803
Merged
Restore Issue Reporters #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
wbinnssmith
commented
Feb 14, 2023
jridgewell
approved these changes
Feb 14, 2023
wbinnssmith
added
the
pr: automerge
|
Benchmark for 05bd2cc
Click to view full benchmark
|
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 21, 2023
…jjsweb.site> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> # New Features - vercel/turbo#3771 - vercel/turbo#3690 # Performance - vercel/turbo#3768 # Fixes - vercel/turbo#3795 - vercel/turbo#3746 - vercel/turbo#3832 - vercel/turbo#3827 - vercel/turbo#3847 # Other - vercel/turbo#3803 - vercel/turbo#3685 - vercel/turbo#3848 --------- Co-authored-by: JJ Kasper <jj@jjsweb.site> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
This restores issue reporters, addressing a bug that prevented turbo-trace from completing. This moves `ConsoleUiVc::new` into an async block to prevent it from stalling. Test Plan: Verify `cargo run --bin node-file-trace -- print path/to/my/app` no longer stalls.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
This restores issue reporters, addressing a bug that prevented turbo-trace from completing. This moves `ConsoleUiVc::new` into an async block to prevent it from stalling. Test Plan: Verify `cargo run --bin node-file-trace -- print path/to/my/app` no longer stalls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores issue reporters, addressing a bug that prevented turbo-trace from completing. This moves
ConsoleUiVc::newinto an async block to prevent it from stalling.Test Plan: Verify
cargo run --bin node-file-trace -- print path/to/my/appno longer stalls.