Implement faster Rope equality #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optimizes for more reference equality checks. The old code allowed for this to happen for `Local(Bytes)` checks, but it didn't implement reference checks for `Shared(InnerRope)` shared data. Instead, it'd iterate every `RopeElem` inside the shared rope and perform quality on those.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
Benchmark for dcd962c
Click to view full benchmark
|
Benchmark for 53ad6e0
Click to view full benchmark
|
jridgewell
added
the
pr: automerge
Benchmark for ee27be7
Click to view full benchmark
|
|
Ping @alexkirsz for review, since you were unlucky enough to emoji the benchmarks 😉 |
alexkirsz
approved these changes
Feb 28, 2023
| @@ -22,10 +22,10 @@ static EMPTY_BUF: &[u8] = &[]; | |||
|
|
|||
| /// A Rope provides an efficient structure for sharing bytes/strings between | |||
| /// multiple sources. Cloning a Rope is extremely cheap (Arc and usize), and | |||
| /// the sharing contents of one Rope can be shared by just cloning an Arc. | |||
| /// the sharing contents of one Rope can be done by just cloning an Arc. | |||
There was a problem hiding this comment.
Suggested change
| /// the sharing contents of one Rope can be done by just cloning an Arc. | |
| /// sharing the contents of one Rope can be done by just cloning an Arc. |
| } | ||
|
|
||
| // At this point, we need to do slower contents equality. It's possible we'll | ||
| // still get some memory reference quality for Bytes. |
There was a problem hiding this comment.
Suggested change
| // still get some memory reference quality for Bytes. | |
| // still get some memory reference equality for Bytes. |
ijjk
added a commit
to vercel/next.js
that referenced
this pull request
Mar 2, 2023
# New Features * vercel/turbo#4011 # Performance Improvements * vercel/turbo#3955 * vercel/turbo#4018 # Bug Fixes * vercel/turbo#4037 * vercel/turbo#4028 # Other * vercel/turbo#3974 * vercel/turbo#4015 * vercel/turbo#3999 * vercel/turbo#4026 * vercel/turbo#4053 * vercel/turbo#3891 Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes for more reference equality checks. The old code allowed for this to happen for
Local(Bytes)checks, but it didn't implement reference checks forShared(InnerRope)shared data. Instead, it'd iterate everyRopeEleminside the shared rope and perform equality on those.