Split the ES chunk module into smaller, more focused modules #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Feb 27, 2023
🟢 CI successful 🟢Thanks |
alexkirsz
force-pushed
the
alexkirsz/web-616-split-ecmascript-modules
branch
2 times, most recently
from
9ec7680
to
a2a5e3e
Compare
alexkirsz
changed the base branch from
alexkirsz/web-616-remove-cell_local-in-favor-of-more
to
main
alexkirsz
force-pushed
the
alexkirsz/web-616-split-ecmascript-modules
branch
from
a2a5e3e
to
10de7af
Compare
sokra
approved these changes
Feb 27, 2023
alexkirsz
force-pushed
the
alexkirsz/web-616-split-ecmascript-modules
branch
from
8f76720
to
f1163f0
Compare
alexkirsz
added
the
pr: automerge
Benchmark for db50397Click to view benchmark
|
ijjk
added a commit
to vercel/next.js
that referenced
this pull request
Mar 2, 2023
# New Features * vercel/turbo#4011 # Performance Improvements * vercel/turbo#3955 * vercel/turbo#4018 # Bug Fixes * vercel/turbo#4037 * vercel/turbo#4028 # Other * vercel/turbo#3974 * vercel/turbo#4015 * vercel/turbo#3999 * vercel/turbo#4026 * vercel/turbo#4053 * vercel/turbo#3891 Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff splits the
turbopack-ecmascript/src/chunk/mod.rsandturbopack-ecmascript/src/loader.rsmodules into smaller modules, usually centered around one type.The goal of this PR is to make the ecmascript crate easier to navigate and review, as well as reduce the amount of merge conflicts that can arise from modifying imports in two separate diffs within the same module.
This PR also changes the visibility of most modules within the crate to be
pub(crate)so they're available to the generatedregisterfunction, but not accidentally leaked outside of the crate. The same is done on a per-type basis withpub(crate)orpub(super).