avoid bundling and execution of modules just of watching #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use completions to signal additional invalidations for evaluation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
alexkirsz
approved these changes
Mar 2, 2023
| vec![ | ||
| JsonValueVc::cell(request), | ||
| JsonValueVc::cell(dir.to_string_lossy().into()), | ||
| ], | ||
| routes_changed, | ||
| CompletionsVc::all(vec![next_config_changed, routes_changed]), |
There was a problem hiding this comment.
Unrelated to the current PR, but it feels like ::all should be a static method on CompletionVc instead of CompletionsVc.
| #[turbo_tasks::function] | ||
| pub async fn all(self) -> anyhow::Result<CompletionVc> { | ||
| pub fn all(completions: Vec<CompletionVc>) -> CompletionVc { |
There was a problem hiding this comment.
Unfortunate that we can't use [CompletionVc; N] here. This seems like a very easy mistake to make.
| /// Returns a completion that changes when the content of the given asset | ||
| /// changes. | ||
| #[turbo_tasks::function] | ||
| pub async fn content_changed(asset: AssetVc) -> Result<CompletionVc> { |
There was a problem hiding this comment.
I wouldn't mark this as pub until we have another use for it.
Benchmark for 444b11eClick to view benchmark
|
ijjk
added a commit
to vercel/next.js
that referenced
this pull request
Mar 2, 2023
# New Features * vercel/turbo#4011 # Performance Improvements * vercel/turbo#3955 * vercel/turbo#4018 # Bug Fixes * vercel/turbo#4037 * vercel/turbo#4028 # Other * vercel/turbo#3974 * vercel/turbo#4015 * vercel/turbo#3999 * vercel/turbo#4026 * vercel/turbo#4053 * vercel/turbo#3891 Co-authored-by: JJ Kasper <jj@jjsweb.site>
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…o#4053) ### Description * use completions to signal additional invalidations for evaluation * avoid adding these modules as runtime entries, since that will unnecessarily code generate, bundle and execute these modules * gets rid of the watch_files_hack ### Testing Instructions * change postcss.config, next.config.js, etc. -> changes will be reflected by the app and process restarts
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…o#4053) ### Description * use completions to signal additional invalidations for evaluation * avoid adding these modules as runtime entries, since that will unnecessarily code generate, bundle and execute these modules * gets rid of the watch_files_hack ### Testing Instructions * change postcss.config, next.config.js, etc. -> changes will be reflected by the app and process restarts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions