Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug print errors for nested vcs #4026

Merged
merged 2 commits into from
Mar 2, 2023
Merged

debug print errors for nested vcs #4026

merged 2 commits into from
Mar 2, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 1, 2023

Description

It's annoying to debug when the whole dbg will throw an error if any nested Vc is in error state.
Instead we want to print the errors here.

Testing Instructions

[X] Auto label

@sokra sokra requested a review from a team as a code owner March 1, 2023 11:04
@vercel
Copy link

vercel bot commented Mar 1, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-cra-web 🔄 Building (Inspect) Mar 2, 2023 at 7:50AM (UTC)
examples-native-web 🔄 Building (Inspect) Mar 2, 2023 at 7:50AM (UTC)
examples-tailwind-web 🔄 Building (Inspect) Mar 2, 2023 at 7:50AM (UTC)
7 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 2, 2023 at 7:50AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 2, 2023 at 7:50AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 2, 2023 at 7:50AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Mar 2, 2023 at 7:50AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Mar 2, 2023 at 7:50AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Mar 2, 2023 at 7:50AM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Mar 2, 2023 at 7:50AM (UTC)

@sokra sokra requested a review from alexkirsz March 1, 2023 11:04
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023 •
edited

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Benchmark for daeeeff

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 10.12ms ± 0.04ms 10.06ms ± 0.07ms -0.58%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.53ms ± 0.07ms 12.76ms ± 0.09ms +1.80%
bench_hmr_to_commit/Turbopack RSC/1000 modules 534.01ms ± 3.92ms 530.33ms ± 1.40ms -0.69%
bench_hmr_to_commit/Turbopack SSR/1000 modules 10.24ms ± 0.04ms 10.28ms ± 0.07ms +0.45%
bench_hmr_to_eval/Turbopack CSR/1000 modules 9075.99µs ± 56.31µs 9225.67µs ± 59.38µs +1.65%
bench_hmr_to_eval/Turbopack RCC/1000 modules 12.00ms ± 0.19ms 12.31ms ± 0.19ms +2.56%
bench_hmr_to_eval/Turbopack SSR/1000 modules 9155.62µs ± 50.95µs 9106.81µs ± 63.24µs -0.53%
bench_hydration/Turbopack RCC/1000 modules 3994.01ms ± 14.48ms 3951.66ms ± 22.00ms -1.06%
bench_hydration/Turbopack RSC/1000 modules 3622.44ms ± 12.66ms 3577.45ms ± 17.68ms -1.24%
bench_hydration/Turbopack SSR/1000 modules 3524.01ms ± 12.73ms 3528.04ms ± 14.45ms +0.11%
bench_startup/Turbopack CSR/1000 modules 2669.30ms ± 9.15ms 2673.58ms ± 11.04ms +0.16%
bench_startup/Turbopack RCC/1000 modules 2418.24ms ± 10.92ms 2394.19ms ± 8.56ms -0.99%
bench_startup/Turbopack RSC/1000 modules 2356.76ms ± 7.36ms 2369.81ms ± 13.91ms +0.55%
bench_startup/Turbopack SSR/1000 modules 2130.36ms ± 7.12ms 2114.18ms ± 5.00ms -0.76%

@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Mar 2, 2023
@kodiakhq kodiakhq bot merged commit 827df2e into main Mar 2, 2023
@kodiakhq kodiakhq bot deleted the sokra/dbg-with-errors branch March 2, 2023 08:09
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Benchmark for ab44c70

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8873.96µs ± 24.18µs 8851.05µs ± 67.65µs -0.26%
bench_hmr_to_commit/Turbopack RCC/1000 modules 13.09ms ± 0.15ms 12.95ms ± 0.07ms -1.09%
bench_hmr_to_commit/Turbopack RSC/1000 modules 485.46ms ± 0.94ms 483.83ms ± 0.91ms -0.34%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9090.36µs ± 27.14µs 9090.12µs ± 34.05µs -0.00%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7870.86µs ± 23.33µs 7910.37µs ± 54.48µs +0.50%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.90ms ± 0.21ms 12.06ms ± 0.16ms +1.33%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8102.78µs ± 50.87µs 8115.96µs ± 46.19µs +0.16%
bench_hydration/Turbopack RCC/1000 modules 3547.55ms ± 8.80ms 3533.18ms ± 10.77ms -0.41%
bench_hydration/Turbopack RSC/1000 modules 3190.58ms ± 13.19ms 3173.48ms ± 10.04ms -0.54%
bench_hydration/Turbopack SSR/1000 modules 3246.30ms ± 3.44ms 3239.34ms ± 8.96ms -0.21%
bench_startup/Turbopack CSR/1000 modules 2540.18ms ± 6.97ms 2529.16ms ± 7.14ms -0.43%
bench_startup/Turbopack RCC/1000 modules 2088.89ms ± 3.36ms 2084.56ms ± 4.20ms -0.21%
bench_startup/Turbopack RSC/1000 modules 2021.23ms ± 3.95ms 2023.37ms ± 8.93ms +0.11%
bench_startup/Turbopack SSR/1000 modules 2018.85ms ± 4.67ms 2009.27ms ± 4.19ms -0.47%

@alexkirsz alexkirsz mentioned this pull request Mar 2, 2023
Merged
ijjk added a commit to vercel/next.js that referenced this pull request Mar 2, 2023
@alexkirsz @ijjk
build(cargo): update turbopack (#46685)
111ef39 
# New Features
*  vercel/turbo#4011

# Performance Improvements
* vercel/turbo#3955
* vercel/turbo#4018

# Bug Fixes
* vercel/turbo#4037
* vercel/turbo#4028

# Other
* vercel/turbo#3974
* vercel/turbo#4015
* vercel/turbo#3999
* vercel/turbo#4026
* vercel/turbo#4053
* vercel/turbo#3891

Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sokra @alexkirsz