Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update swc_core to v0.90.33 #7987

Merged
merged 3 commits into from
Apr 19, 2024
Merged

build: Update swc_core to v0.90.33 #7987

merged 3 commits into from
Apr 19, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 16, 2024 •
edited by padmaia
Loading

Description

Update swc crates to swc-project/swc@0f07acb

Testing Instructions

See CI of next.js

Closes PACK-2968

@kdy1 kdy1 self-assigned this Apr 16, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 0:58am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 0:58am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 0:58am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 0:58am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 0:58am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 0:58am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 0:58am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 0:58am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 0:58am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 0:58am
turbo-turbo-tracing-next-plugin ❌ Failed (Inspect) Apr 18, 2024 0:58am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kdy1 kdy1 marked this pull request as ready for review April 18, 2024 00:50
@kdy1 kdy1 requested review from a team as code owners April 18, 2024 00:50
@kdy1 kdy1 marked this pull request as draft April 18, 2024 03:32
@kdy1
Copy link
Member Author

kdy1 commented Apr 18, 2024

Undrafting as swc-project/swc#8872 is not related to next.js

externalHelpers: true avoids this issue

@kdy1 kdy1 marked this pull request as ready for review April 18, 2024 04:32
@kdy1 kdy1 merged commit 07c8ac8 into main Apr 19, 2024
50 of 52 checks passed
@kdy1 kdy1 deleted the kdy1/swc-core-0-90-12 branch April 19, 2024 11:48
@kdy1 kdy1 mentioned this pull request Apr 19, 2024
Merged
kdy1 added a commit to vercel/next.js that referenced this pull request Apr 22, 2024
@kdy1
build: Update swc_core to v0.90.33 (#64553)
7552a7a 
# Turbopack

* vercel/turborepo#7992 <!-- hrmny -
build(turbo-repository): fix napi build with LLD -->
* vercel/turborepo#7765 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
* vercel/turborepo#7955 <!-- Donny/강동윤 - chore:
Update `styled-jsx` -->
* vercel/turborepo#7987 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.33` -->

### What?

Update swc crates to
swc-project/swc@0f07acb

### Why?

To keep in sync.

### How?

Closes PACK-2968
@kwonoj kwonoj mentioned this pull request Apr 22, 2024
Closed
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
@kdy1 @ForsakenHarmony
build: Update swc_core to v0.90.33 (#64553)
b7f42d0 
* vercel/turborepo#7992 <!-- hrmny -
build(turbo-repository): fix napi build with LLD -->
* vercel/turborepo#7765 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
* vercel/turborepo#7955 <!-- Donny/강동윤 - chore:
Update `styled-jsx` -->
* vercel/turborepo#7987 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.33` -->

Update swc crates to
swc-project/swc@0f07acb

To keep in sync.

Closes PACK-2968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgw bgw bgw approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees

@kdy1 kdy1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdy1 @bgw