Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test snapshots #5053

Merged
merged 1 commit into from
May 22, 2023
Merged

update test snapshots #5053

merged 1 commit into from
May 22, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented May 22, 2023

Description

follow up for #5049

CI didn't run as it was a lockfile only change

@sokra sokra requested a review from a team as a code owner May 22, 2023 12:26
@sokra sokra requested a review from kdy1 May 22, 2023 12:26
@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 0:27am
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 22, 2023 0:27am
examples-cra-web ⬜️ Ignored (Inspect) May 22, 2023 0:27am
examples-designsystem-docs ⬜️ Ignored (Inspect) May 22, 2023 0:27am
examples-gatsby-web ⬜️ Ignored (Inspect) May 22, 2023 0:27am
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 22, 2023 0:27am
examples-native-web ⬜️ Ignored (Inspect) May 22, 2023 0:27am
examples-nonmonorepo ⬜️ Ignored (Inspect) May 22, 2023 0:27am
examples-svelte-web ⬜️ Ignored (Inspect) May 22, 2023 0:27am
examples-tailwind-web ⬜️ Ignored (Inspect) May 22, 2023 0:27am
examples-vite-web ⬜️ Ignored (Inspect) May 22, 2023 0:27am

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for d0ca6eb

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 865.87ms ± 2.09ms 896.68ms ± 11.80ms +3.56% +0.35%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8694.15µs ± 218.41µs 8379.89µs ± 28.45µs -3.61%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7503.19µs ± 34.64µs 7930.09µs ± 421.90µs +5.69%
bench_startup/Turbopack CSR/1000 modules 865.87ms ± 2.09ms 896.68ms ± 11.80ms +3.56% +0.35%

@sokra sokra merged commit 8e9cc5b into main May 22, 2023
@sokra sokra deleted the sokra/update-snapshots branch May 22, 2023 12:50
@github-actions
Copy link
Contributor

MacOS Benchmark for d0ca6eb

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 28.71ms ± 2.03ms 50.88ms ± 1.52ms +77.18% +45.95%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 28.71ms ± 2.03ms 50.88ms ± 1.52ms +77.18% +45.95%
bench_hmr_to_eval/Turbopack CSR/1000 modules 29.81ms ± 4.69ms 25.31ms ± 0.26ms -15.11%
bench_startup/Turbopack CSR/1000 modules 2578.93ms ± 26.04ms 2592.59ms ± 29.51ms +0.53%

kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request May 23, 2023
### What?

adds `NEXT_TURBOPACK_TRACING` env var to enable tracing. Writes into `.next/trace.log`

There are 4 presets:

* `NEXT_TURBOPACK_TRACING=overview` gives a overview of requests and modules processed.
* `NEXT_TURBOPACK_TRACING=next` above plus details for next.js
* `NEXT_TURBOPACK_TRACING=turbopack` above plus details for turbopack
* `NEXT_TURBOPACK_TRACING=turbo-tasks` above plus details for turbo-tasks

Published release builds will only allow `overview` to work, since all detailed instrumentation is statically disabled.

see vercel/turborepo#4966 for more details

### Why?

get more insight into build times

### Turbopack changes

* vercel/turborepo#4995 
* vercel/turborepo#5049 
* vercel/turborepo#5053 
* vercel/turborepo#4966
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
### What?

adds `NEXT_TURBOPACK_TRACING` env var to enable tracing. Writes into `.next/trace.log`

There are 4 presets:

* `NEXT_TURBOPACK_TRACING=overview` gives a overview of requests and modules processed.
* `NEXT_TURBOPACK_TRACING=next` above plus details for next.js
* `NEXT_TURBOPACK_TRACING=turbopack` above plus details for turbopack
* `NEXT_TURBOPACK_TRACING=turbo-tasks` above plus details for turbo-tasks

Published release builds will only allow `overview` to work, since all detailed instrumentation is statically disabled.

see vercel/turborepo#4966 for more details

### Why?

get more insight into build times

### Turbopack changes

* vercel/turborepo#4995 
* vercel/turborepo#5049 
* vercel/turborepo#5053 
* vercel/turborepo#4966
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

follow up for vercel/turborepo#5049

CI didn't run as it was a lockfile only change
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

follow up for vercel/turborepo#5049

CI didn't run as it was a lockfile only change
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

follow up for vercel/turborepo#5049

CI didn't run as it was a lockfile only change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants