Store and retrieve timeSaved value from daemon #5101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
Currently stuck on: error[E0596]: cannot borrow `__self.times_saved` as mutable, as it is behind a `&` reference
--> crates/turborepo-lib/src/daemon/server.rs:261:9
|
256 | &self,
| ---- consider changing this binding's type to be: `&mut DaemonServer<T>`
...
261 | / self.times_saved
262 | | .insert(inner.hash.clone(), inner.time_saved);
| |_________________________________________________________^ `__self` is a `&` reference, so the data it refers to cannot be borrowed as mutable
error[E0382]: borrow of moved value: `inner.hash`
--> crates/turborepo-lib/src/daemon/server.rs:295:52
|
289 | &Arc::new(inner.hash),
| ---------- value moved here
...
295 | if let Some(value) = self.times_saved.get(&inner.hash.clone()) {
| ^^^^^^^^^^^^^^^^^^ value borrowed here after move |
|
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
mehulkar
requested review from
nathanhammond and
chris-olszewski
and removed request for
a team
|
Thanks for the suggestions and explanations @chris-olszewski , that helped a lot! Merging this into #4952 to get a final review, it looks like its working well and I can pass values back and forth from the daemon now |
mehulkar
merged commit 2f1b9fd
into
mehulkar/turbo-1000-runs-include-timesaved-for-local-runs
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.