Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove mopa dependency in turbo-tasks" #7573

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Mar 1, 2024

Reverts #7206

Closes PACK-2640

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 10:26pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 10:26pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 10:26pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 10:26pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 10:26pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 10:26pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 10:26pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 10:26pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 10:26pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 10:26pm

Copy link
Contributor

github-actions bot commented Mar 1, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Mar 1, 2024

⚠️ This change may fail to build next-swc.

Logs

packages/next-swc/crates/next-core/src/next_font/google/mod.rs:585:18: �[38;5;9merror[E0061]: this function takes 3 arguments but 2 arguments were supplied
error: could not compile `next-core` (lib) due to previous error

See job summary for details

Copy link
Contributor

github-actions bot commented Mar 1, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 7c1ae37 into main Mar 2, 2024
50 of 53 checks passed
@sokra sokra deleted the revert-7206-remove-mopa branch March 2, 2024 06:46
sokra added a commit that referenced this pull request Mar 2, 2024
sokra added a commit to vercel/next.js that referenced this pull request Mar 4, 2024
### What

* vercel/turborepo#7544 <!-- Tobias Koppers -
extract a turbopack-resolve crate -->
* vercel/turborepo#7547 <!-- Tobias Koppers - only
register once -->
* vercel/turborepo#7447 <!-- Leah - fix(turbopack):
catch invalid source map paths -->
* vercel/turborepo#7503 <!-- Leah -
fix(turbopack-node): don't bundle postcss config -->
* vercel/turborepo#7445 <!-- Tobias Koppers - allow
to set a name on the virtual file system -->
* vercel/turborepo#7552 <!-- Tobias Koppers - add
default_files, prefer_relative and fully_specified resolve options -->
* vercel/turborepo#7560 <!-- Tobias Koppers - remove
unused code -->
* vercel/turborepo#7562 <!-- Tobias Koppers - add
getResolve to webpack loader context -->
* vercel/turborepo#7564 <!-- Tobias Koppers - fix
serde deserialization -->
* vercel/turborepo#7566 <!-- Tobias Koppers - Revert
"add getResolve to webpack loader context" -->
* vercel/turborepo#7565 <!-- Tobias Koppers - Ignore
circular aliasing with alias field -->
* vercel/turborepo#7320 <!-- OJ Kwon -
feat(turbo-tasks-fetch): allow specifying a proxy -->
* vercel/turborepo#7573 <!-- OJ Kwon - Revert
"Remove mopa dependency in turbo-tasks" -->
* vercel/turborepo#7526 <!-- Alexander Lyon - Handle
logging story better on daemon -->

Closes PACK-2639

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants