-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pnpm): support pnpm lockfile v9 #7994
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would kind of like to see prysk tests with fixtures in addition to unit test, just to see a full e2e validation, but it's not blocking by any means
{ | ||
integrity: sha512-D/RRtqHch0I5q/Pod7mgLPGrvjcDpvBe95yp5hNy59+ZSyKHlkDrm/pQaA/+6mdjHEQB8eIL/18nrKx/B5qduA==, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
umm.. what is this?? json inside yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They did in fact add JSON to YAML: https://www.yaml.info/learn/flowstyle.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look-how-theyve-massacred-my-boy.jpg
Description
Closes #7993
Only thing that required updating is that as of
9.0.0-rc.0
the lockfile version was updated to9.0
instead of7.0
that was used from9.0.0-alpha.0
-9.0.0-beta.3
. I believe this was the only change made since I added support for lockfile v7 in #7853.Testing Instructions
Added roundtrip test along with unit test for package resolution.
Manual test with repro provided in #7993
Closes TURBO-2826