Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(turborepo): use biome to parse package.json #8255

Merged
merged 6 commits into from
Jun 20, 2024
Merged

feat(turborepo): use biome to parse package.json #8255

merged 6 commits into from
Jun 20, 2024

Conversation

NicholasLYang
Copy link
Contributor

@NicholasLYang NicholasLYang commented May 30, 2024 •
edited
Loading

Description

Uses biome_deserialize to parse package.json files. This gives us span info, and better parse error messages.

Testing Instructions

The existing tests for package.json should suffice.

@vercel Vercel
Copy link

vercel bot commented May 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 5:03pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 5:03pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 5:03pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 5:03pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 5:03pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 5:03pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 5:03pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 5:03pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 5:03pm
rust-docs ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 5:03pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 30, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 30, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@NicholasLYang NicholasLYang force-pushed the nicholasyang/biome-package-json branch from f321f2d to 065963e Compare May 30, 2024 17:37
@NicholasLYang NicholasLYang force-pushed the nicholasyang/biome-package-json branch from 065963e to 649fd8b Compare June 4, 2024 14:54
@NicholasLYang NicholasLYang force-pushed the nicholasyang/biome-package-json branch from 649fd8b to 479c28e Compare June 4, 2024 15:00
@NicholasLYang NicholasLYang marked this pull request as ready for review June 4, 2024 15:12
@NicholasLYang NicholasLYang requested review from a team as code owners June 4, 2024 15:12
@NicholasLYang NicholasLYang force-pushed the nicholasyang/biome-package-json branch from 479c28e to 0915267 Compare June 4, 2024 15:19
@NicholasLYang NicholasLYang mentioned this pull request Jun 4, 2024
Draft
@NicholasLYang NicholasLYang force-pushed the nicholasyang/biome-package-json branch from 0915267 to 5a52ff6 Compare June 4, 2024 19:10
@NicholasLYang NicholasLYang mentioned this pull request Jun 4, 2024
Merged
chris-olszewski
chris-olszewski requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern is with adding more round-trip testing since prune depends on this behavior.

crates/turborepo-repository/src/package_json.rs Show resolved Hide resolved
@NicholasLYang NicholasLYang force-pushed the nicholasyang/biome-package-json branch from 5e41591 to b0c8574 Compare June 17, 2024 19:30
@NicholasLYang NicholasLYang force-pushed the nicholasyang/biome-package-json branch from b0c8574 to 7343bf7 Compare June 18, 2024 18:38
@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@NicholasLYang NicholasLYang force-pushed the nicholasyang/biome-package-json branch from a13d923 to 5e25077 Compare June 18, 2024 20:21
@NicholasLYang NicholasLYang force-pushed the nicholasyang/biome-package-json branch from 5e25077 to 792c898 Compare June 20, 2024 17:03
@NicholasLYang NicholasLYang merged commit 29d4f41 into main Jun 20, 2024
67 of 69 checks passed
@NicholasLYang NicholasLYang deleted the nicholasyang/biome-package-json branch June 20, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@Zertsov Zertsov Awaiting requested review from Zertsov Zertsov is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci created-by: turborepo owned-by: turbopack owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicholasLYang @chris-olszewski