Release LSP 2.0 #8538
Merged
Release LSP 2.0 #8538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
Merged
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
arlyon
force-pushed
the
arlyon/lsp-2-release
branch
from
d2f2fed
to
a489946
Compare
NicholasLYang
approved these changes
Jun 20, 2024
chris-olszewski
approved these changes
Jun 20, 2024
Co-authored-by: Nicholas Yang <nicholas.yang@vercel.com>
arlyon
added a commit
that referenced
this pull request
Jun 24, 2024
A reciprocal of #8538 for the 1.x branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small fix to surface an error in UI if there is a version mismatch in turbo, as well as updating the LSP to support the new protocol version.
This also updates the lsp CI to use our setup-rust workflow rather than hand rolling one
Testing Instructions
Open up a project with 2.0 of the extension, with turbo 1.0. Observe a nice error message, instead of returning an internal error. Observe that LSP features don't 'work' but at least gracefully degrade.