Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: existing secret #100

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Feat: existing secret #100

merged 1 commit into from
Jun 7, 2022

Conversation

LoicGombeaud
Copy link
Contributor

Allows for injection of environment variables contained in an externally-defined secret.

Related issue: #99

@juanpicado juanpicado requested a review from a team June 7, 2022 07:47
Copy link
Collaborator

@rblaine95 rblaine95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Thank you for the contribution! 🚀

Side note: Have you taken a look at the Helm Secrets Plugin? At my workplace use this with AWS KMS keys to encrypt secrets.

Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoicGombeaud
Copy link
Contributor Author

Side note: Have you taken a look at the Helm Secrets Plugin? At my workplace use this with AWS KMS keys to encrypt secrets.

Thanks for the tip, I hadn't heard of this plugin! (although I'm familiar with the underlying sops driver - great stuff)

We use sealed-secrets at the moment and are quite happy with it, but I'll keep the helm secrets plugin in mind if we ever need to change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants