Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

update date fns to v2 #232

Merged
merged 3 commits into from
Oct 30, 2019
Merged

update date fns to v2 #232

merged 3 commits into from
Oct 30, 2019

Conversation

ayusharma
Copy link
Member

@ayusharma ayusharma commented Oct 28, 2019

Type: build

The following has been addressed in the PR:

  • There is a related issue?
  • Unit or Functional tests are included in the PR

Description:
date-fns@2

Resolves https://github.com/verdaccio/ui/issues/226

@ayusharma ayusharma changed the title 226 update date fns to v2 update date fns to v2 Oct 28, 2019
juanpicado
juanpicado previously approved these changes Oct 28, 2019
@juanpicado
Copy link
Member

Test are failing ...

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   88.56%   88.56%           
=======================================
  Files         119      119           
  Lines         883      883           
  Branches      160      141   -19     
=======================================
  Hits          782      782           
- Misses         87       90    +3     
+ Partials       14       11    -3
Impacted Files Coverage Δ
src/utils/package.ts 95.65% <100%> (ø) ⬆️
src/utils/styles/media.ts 81.81% <0%> (ø) ⬆️
src/components/DetailSidebar/DetailSidebar.tsx 85% <0%> (ø) ⬆️

@verdacciobot
Copy link

Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes:

npm install @verdaccio/ui-theme@v0.3.5-93a03c9-pr232.0 --registry https://registry.verdaccio.org

@juanpicado juanpicado merged commit a4cdd14 into master Oct 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the 226-update-date-fns-to-v2 branch October 30, 2019 06:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update date-fns@2.x
3 participants