This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Merged
Conversation
juanpicado
previously approved these changes
Oct 28, 2019
Member
|
Test are failing ... |
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 119 119
Lines 883 883
Branches 160 141 -19
=======================================
Hits 782 782
- Misses 87 90 +3
+ Partials 14 11 -3
|
|
Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes: |
juanpicado
approved these changes
Oct 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: build
The following has been addressed in the PR:
Description:
date-fns@2
Resolves https://github.com/verdaccio/ui/issues/226