This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
Avatar Component - Introduced ForwardRef #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 83.01% 83.04% +0.03%
==========================================
Files 98 99 +1
Lines 936 938 +2
Branches 149 149
==========================================
+ Hits 777 779 +2
Misses 146 146
Partials 13 13
Continue to review full report at Codecov.
|
|
@priscilawebdev conflict ⬆️ |
juanpicado
reviewed
Oct 6, 2019
juanpicado
previously approved these changes
Oct 6, 2019
There was a problem hiding this comment.
🚀 great, I was not pretty aware of this https://reactjs.org/docs/forwarding-refs.html React.forwardRef good to know.
juanpicado
approved these changes
Oct 6, 2019
delete-merged-branch
bot
deleted the
refactor/162_add_forwardRef_avatar
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Refactor
The following has been addressed in the PR: https://github.com/verdaccio/ui/issues/162
Unit or Functional tests are included in the PR? Not yet
Description:
Wrapped Material UI Avatar component with ForwardRef