This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
Not Found Component #170
Merged
Not Found Component #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 88.2% 88.75% +0.55%
==========================================
Files 113 113
Lines 924 916 -8
Branches 147 162 +15
==========================================
- Hits 815 813 -2
+ Misses 96 89 -7
- Partials 13 14 +1
|
juanpicado
reviewed
Oct 10, 2019
juanpicado
reviewed
Oct 10, 2019
juanpicado
reviewed
Oct 10, 2019
juanpicado
reviewed
Oct 10, 2019
juanpicado
approved these changes
Oct 12, 2019
delete-merged-branch
bot
deleted the
refactor/update_not_found_component
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Refactor
The following has been addressed in the PR: There is not issue for this PR
Description: I had to refactor this component to correct the testing of the Version page. I ended up simplifying the component.