-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upstream search not work with gzip #170
Conversation
lib/up-storage.js
Outdated
res.on('end', () => { | ||
|
||
// See https://github.com/request/request#requestoptions-callback | ||
// Request library will not decode gzip stream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this fix a gzip issue. How can I reproduce it with the latest version published?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanpicado Use registry.yarnpkg.com as upstream, then search with npm cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll try out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You really reply me at 22 hours ago? i have receive notification email at 1 hours ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not press the "submit review" 😅😅😅😅 .. doh ... 😊 my bad. I'll need a few days to review this. I'm 🚅ling these days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Meeeeow I messed up your PR :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will resolve conflicts later, busy with work...
Done @juanpicado |
Thanks dude I'll release a new version soon |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Also fixed a small bug.