Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upstream search not work with gzip #170

Merged
merged 2 commits into from
May 8, 2017
Merged

Fix upstream search not work with gzip #170

merged 2 commits into from
May 8, 2017

Conversation

AvailCat
Copy link
Member

Also fixed a small bug.

res.on('end', () => {

// See https://github.com/request/request#requestoptions-callback
// Request library will not decode gzip stream.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this fix a gzip issue. How can I reproduce it with the latest version published?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanpicado Use registry.yarnpkg.com as upstream, then search with npm cli

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll try out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You really reply me at 22 hours ago? i have receive notification email at 1 hours ago

Copy link
Member

@juanpicado juanpicado Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not press the "submit review" 😅😅😅😅 .. doh ... 😊 my bad. I'll need a few days to review this. I'm 🚅ling these days.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Meeeeow I messed up your PR :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will resolve conflicts later, busy with work...

@AvailCat
Copy link
Member Author

AvailCat commented May 8, 2017

Done @juanpicado

@juanpicado juanpicado merged commit f4058bb into verdaccio:master May 8, 2017
@juanpicado
Copy link
Member

Thanks dude I'll release a new version soon

@juanpicado juanpicado added this to the Future milestone May 8, 2017
@juanpicado juanpicado modified the milestones: 2.1.6, Future May 12, 2017
@AvailCat AvailCat deleted the fix_yarn_upstream branch June 21, 2017 17:12
@lock
Copy link

lock bot commented May 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants