fix: avoid setting body for GET requests #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making a GET request to certain uplinks, such as https://registry.npmmirror.com, setting the body field can result in a 413 error. Previously, the code was setting the body field for all requests, including GET requests. This commit fixes the issue by checking the request method and avoiding setting the body field for GET requests. This ensures that GET requests are not affected by the issue and can be made without error. Fixes verdaccio#3601
juanpicado
reviewed
Feb 22, 2023
src/lib/up-storage.ts
Outdated
| @@ -228,6 +227,11 @@ class ProxyStorage implements IProxy { | |||
| agentOptions: this.agent_options, | |||
| }; | |||
|
|
|||
| // GET requests should not have a body, otherwise the request might fail(return 413 status code) | |||
| if (method.toUpperCase() !== 'GET') { | |||
There was a problem hiding this comment.
great you found a solution, also thanks for the comment, would you mind add some test, here you can star looking at test/unit/modules/uplinks/up-storage.spec.ts if you have questions let me know
You can run the test yarn test test/unit/modules/uplinks/up-storage.spec.ts
note: first get my latest changes from the branch 5.x
There was a problem hiding this comment.
I'll fix the code format and add some unit tests.
|
Format is not correct, you can run |
Cause thers is a bug in `isObject` function from `@verdaccio/core`, when `options.json` is `true` GET request body will be string 'true', some uplinks might return 413 status code such as https://registry.npmmirror.com fix verdaccio#3601
melodyVoid
commented
Feb 23, 2023
|
@melodyVoid please feel free to update the dependency in your branch |
I updated the dependency, please check it out. |
juanpicado
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a GET request to certain uplinks, such as https://registry.npmmirror.com, setting the body field can result in a 413 error. Previously, the code was setting the body field for all requests, including GET requests.
This commit fixes the issue by checking the request method and avoiding setting the body field for GET requests. This ensures that GET requests are not affected by the issue and can be made without error.
Fixes #3601