This repository has been archived by the owner on Oct 21, 2023. It is now read-only.
webui: new item filter #1143
Merged
webui: new item filter #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verdie-g
reviewed
Jul 12, 2023
or2e
commented
Jul 14, 2023
verdie-g
suggested changes
Jul 14, 2023
src/WebUI/locales/en.yml
Outdated
| @@ -1101,6 +1101,10 @@ item: | |||
| title: 'Rank' | |||
| description: '' | |||
|
|
|||
| new: | |||
| title: 'New items only' | |||
| description: 'Show items added within {days} days' | |||
There was a problem hiding this comment.
Suggested change
| description: 'Show items added within {days} days' | |
| description: 'Show items added or reworked within the last {days} days' |
Same for CN/RU
| @@ -195,12 +197,13 @@ const itemToFlat = (item: Item): ItemFlat => { | |||
| ]; | |||
|
|
|||
| // Banning the use of large shields on horseback | |||
| if (isLargeShield(item)) { | |||
| if (item.type === ItemType.Shield && isLargeShield(item)) { | |||
There was a problem hiding this comment.
That check is already done in isLargeShield
verdie-g
approved these changes
Jul 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "Show only new items" filter
The item is considered new if it was added not earlier than 30 days
Value is changed in
item-service, I did not move it inconstants.jsonScreenshot
Changed the dropdown behavior of additional filters.
Now it closes after selecting
Also made the open button more visible
Demo
additional-filters-dropdown.mp4
Fixed auto-tests related to search service and indexer