This repository has been archived by the owner on Oct 21, 2023. It is now read-only.
mod: only enable rating in battle #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conquest can be a cluster fuck and rating gains/loses are not very relevant so I suggest to disable it. Rating will still be used for team balancing though.
namidaka
suggested changes
Jul 13, 2023
|
The OnScoreHit is actually done in CrpgRewardServer, you can see I'm using the boolean in that method. |
namidaka
approved these changes
Jul 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conquest can be a cluster fuck and rating gains/loses are not very relevant so I suggest to disable it. Rating will still be used for team balancing though.