-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[verifiable-credential]: verify credential using an external context #170
Comments
- Add static to getResolver and verifyPresentation methods - Modified share-credential test #170
@tahpot , I have been able to refactor the see commit 2442b6c Here are questions I want to ask
see test case reference
cc @nick-verida |
That looks good, I have added one comment regarding the unit tests.
I see what you mean. In reality, Can you create an issue for this?
There is some documentation here, however it doesn't mention how to open an external context. Here's an example of that: Use Can you add an issue in the documentation for us to improve this? |
@tahpot, I have added the following tickets.
|
@pranavburnwal it'd be worth you getting across this work. Michael is away for a couple more days but even if you could get it to the point you can replicate what he's seeing I think it might be helpful as preparation for taking some of this stuff off @tahpot . |
Leaving notes here after talking to @nick-verida. PS: I plan to add things like this in Dev Documentation. Anatomy of shared credential URL. Initial URL:
Take out the Token and BASE64 decode
Also add ref: https://github.com/verida/documentation/blob/develop/docs/tutorial/verifiable_credentials.xxx |
After a call with @cmcWebCode40,He is using the context.openData and context.openExternalDatabase interchangeably. |
I have been able to modify the utils function |
* feat: refactored Credential Class - Add static to getResolver and verifyPresentation methods - Modified share-credential test #170 * feat: updated all test case credential class methods #170 * fix: modified parameter of fetchVeridaUri utils functions #170 * fix: updated branch #170 changes #170 * fix: removed hard coded did reg. url and refactored util method fetchVeridaUri #170 * fix: refactored did-resolver packages to use enviromnent #170 * fix:moved getClientContext and connectAccount methods to utils file #170 * fix:moved getClientContext and connectAccount methods to utils file #170 * fix: moved methods in utils to utils file in vc folder #170 * Don't expose utils * fix: update utils file path #170 * Fix did-resolver import
Todo
Users should be able to verify a credential URI from the account explorer demo without having to login in by using an external
context
.see @tahpot suggestion to fix this issue :
https://discord.com/channels/664594912460668960/929954765021011978/953902907974107176
The text was updated successfully, but these errors were encountered: