Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Verida Connect modal is not cleaned from the DOM and can even be added multiple times #371

Closed
aurelticot opened this issue Dec 1, 2023 · 1 comment · Fixed by #355
Assignees

Comments

@aurelticot
Copy link
Member

The Verida Connect modal is injected in the DOM when a connection is triggered. Whether the connection goes through or not, the elements are not cleaned from the DOM. If a connection is triggered again, the modal is added again.

There is no apparent conflict but it's not optimised and clean.

Screenshot 2023-12-01 at 2 13 59 pm
@tahpot
Copy link
Member

tahpot commented Dec 12, 2023

Fixed with 9c78f29

Prevents duplicate DOM entries, but does leave the existing DOM entry there as it won't do any harm.

@tahpot tahpot mentioned this issue Dec 12, 2023
@aurelticot aurelticot linked a pull request Dec 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants