You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the Verida Connect modal is injected in the DOM, a class of either mobile or desktop is also added, to the Body tag, apparently because the modal is styled according to this classes.
When the modal is closed, it is simply hidden, not removed from the DOM. See #371 and the class stays there as well.
The class should not be added and left to the Body tag because it can impact the whole application style.
At least, the class should be removed when the modal is closed.
Even better the class should be applied to the modal element itself rather than the body, so it doesn't impact the rest of the application.
Even better, the modal should have a better styling that doesn't rely on the userAgent. Also, a stronger UX would provide both the deep link and the QR code to the user so they can use the most appropriate. The modal would merely emphasise one or the other (but not hide neither) depending on the available space (assuming narrow window prefers deep link and large window prefers QR code). But this is the topic for another ticket.
The text was updated successfully, but these errors were encountered:
When the Verida Connect modal is injected in the DOM, a class of either
mobile
ordesktop
is also added, to theBody
tag, apparently because the modal is styled according to this classes.When the modal is closed, it is simply hidden, not removed from the DOM. See #371 and the class stays there as well.
The class should not be added and left to the
Body
tag because it can impact the whole application style.The text was updated successfully, but these errors were encountered: