Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Verida Connect modal should not add a mobile or desktop class to the body in the DOM #372

Open
aurelticot opened this issue Dec 1, 2023 · 1 comment
Assignees

Comments

@aurelticot
Copy link
Member

When the Verida Connect modal is injected in the DOM, a class of either mobile or desktop is also added, to the Body tag, apparently because the modal is styled according to this classes.

When the modal is closed, it is simply hidden, not removed from the DOM. See #371 and the class stays there as well.

Screenshot 2023-12-01 at 2 23 29 pm

The class should not be added and left to the Body tag because it can impact the whole application style.

  • At least, the class should be removed when the modal is closed.
  • Even better the class should be applied to the modal element itself rather than the body, so it doesn't impact the rest of the application.
  • Even better, the modal should have a better styling that doesn't rely on the userAgent. Also, a stronger UX would provide both the deep link and the QR code to the user so they can use the most appropriate. The modal would merely emphasise one or the other (but not hide neither) depending on the available space (assuming narrow window prefers deep link and large window prefers QR code). But this is the topic for another ticket.
@tahpot
Copy link
Member

tahpot commented Dec 12, 2023

@aurelticot I think you are best placed to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants