Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parform] gzip compression doesn't work #3

Closed
tueda opened this issue Oct 4, 2013 · 3 comments
Closed

[parform] gzip compression doesn't work #3

tueda opened this issue Oct 4, 2013 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@tueda
Copy link
Collaborator

tueda commented Oct 4, 2013

"On compress, gzip, n" can lead an abnormal termination with the parallelization of ParFORM.

@vermaseren
Copy link
Owner

Hi Takahiro,

I guess that Misha never got around debugging that properly.
That was supposed to be his terrain. I never did any of the ParFORM
programming.
Do you think that you can have a look at this? Otherwise it will be best
to wait till you are in Amsterdam. Unless of course there is a big pressure
to get this fixed up. But I never run ParFORM here and I have no experience
debugging it.

Cheers

Jos

Quoting Takahiro Ueda notifications@github.com:

"On compress, gzip, n" can lead an abnormal termination with the
parallelization of ParFORM.


Reply to this email directly or view it on GitHub:
#3

@tueda
Copy link
Collaborator Author

tueda commented Oct 9, 2013

My impression is that it's due to missing initialization of buffers for the compression on the master process, and the buffers should be setup at some point around EndSort or PF_EndSort. I'll look into it.

@vermaseren
Copy link
Owner

Hi Takahiro,

Thanks!

Jos

Quoting Takahiro Ueda notifications@github.com:

My impression is that it's due to missing initialization of buffers
for the compression on the master process, and the buffers should be
setup at some point around EndSort or PF_EndSort. I'll look into it.


Reply to this email directly or view it on GitHub:
#3 (comment)

@ghost ghost assigned tueda Oct 10, 2013
tueda added a commit that referenced this issue Oct 25, 2013
The gzip compression should be switched off for the output file during
the final sorting on the master.
@tueda tueda closed this as completed Oct 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants