Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce name-addr syntax usage in From/To/Contact #61

Closed
ibc opened this issue Feb 17, 2013 · 0 comments
Closed

Enforce name-addr syntax usage in From/To/Contact #61

ibc opened this issue Feb 17, 2013 · 0 comments

Comments

@ibc
Copy link
Member

ibc commented Feb 17, 2013

In From/To/Contact always use name-addr format regardless there is display-name or not. A SIP URI allows ":" in a UR param value, but if such a URI appears in a header allowing name-addr/spec-addr like header (To/From/Contact/) then the URI must be enclposed between < > (so name-addr format is required).

Also do it in Contact within the new ua.contact.toString(anonymous=false) mechanism. I would suggest that such a toString method ALWAYS returns a name-addr style Contact value, so if you need to pass ;ob to the URI do it by passing some kind of optional argument to contact.toString() method:

ua.contact.toStrking({
  anynomous: true,
  outbound: true   // this would add ";ob" in Contact URI params
});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant