Forward TMMBR and TMMBN packets #91
Conversation
|
Question: should we also check possible TMMB packets into received RTCP compound packets? |
|
Also, this depends on #89 |
|
NOTE: I do know that the PR is wrong, as it must extract all the items from the TMMB packet and get the |
| } | ||
|
|
||
| break; | ||
| } | ||
|
|
||
| case RTCP::FeedbackRtp::MessageType::TMMBR: | ||
| case RTCP::FeedbackRtp::MessageType::TMMBN: | ||
| { |
There was a problem hiding this comment.
TMMBR is sent by a remote receiver as a feedback to the sender of the indicated SSRC.
TMMBN is sent by the remote sender as response to the previous one.
They cannot be threaten the same way.
There was a problem hiding this comment.
Wow, that's also right... disaster... I will just cancel this PR and delete the branch (I will copy the logs improvement into master branch).
Compound packets are decomposed on reception, just when parsing. After parsing them Mediasoup does not know whether they came in a compound or separately. It just processes the packets separatelly. |
|
Yes, right... I always forget that our RTCP design is so cool :) |
Forward TMMBR and TMMBN feedback packets to the corresponding
RtpReceiver.