Fix errors caused by mutations on certain elements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my use case, we are having to modify the `d` attribute on a `path` element inside of an `svg` tag. This is triggering the MutationObserver. However, the `Node` object returned by the `path` element in javascript is not compatible with the expectations in this observer. It still has a `className` property, but it is not a string type but a `SVGAnimatedString`. This `SVGAnimatedString` type does not have an `includes` property causing these calls to error out. While it may not be the most elegant fix, adding in a check to see if the includes property is defined fixes this error in my specific use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use case, we are having to modify the
dattribute on apathelement inside of ansvgtag. This is triggering the MutationObserver. However, theNodeobject returned by thepathelement in javascript is not compatible with the expectations in this observer. It still has aclassNameproperty, but it is not a string type but aSVGAnimatedString. ThisSVGAnimatedStringtype does not have anincludesproperty causing these calls to error out.While it may not be the most elegant fix, adding in a check to see if the includes property is defined fixes this error in my specific use case.