feat: multi-window support #109

wusyong · 2024-08-08T06:11:16Z

This PRs adds initial multi-window support.

There are some known issues we might open in follow up issues:

Closing x11 window can cause Xerror and even crashs.
Closing macOS window will segfault due to fix(macos): add reference count to layer to prevent use after free servo/surfman#304
Wayland spawning new window in the same window.
CreateOrUpdateWebView may change to old pipeline, but we won't update it to "loaded"

src/verso.rs

src/webview.rs

Taym95 · 2024-08-08T10:58:48Z

src/window.rs

@@ -78,20 +92,67 @@ impl Window {
        )
    }

-    /// Handle Winit window event.
+    /// Create a Verso window with the rendering context.
+    pub fn new_with_compositor(


this code looks duplicated with pub fn new(evl: &EventLoopWindowTarget<()>) -> (Self, RenderingContext)

The current limitation is that RenderingContext still needs a surface which means it needs an existing window to create. Do you have any suggestions for the abstract?

src/window.rs

tensor-programming · 2024-08-08T17:25:49Z

Seems to work on windows though even with a basic page like google.com, it hits dom binding errors which cause it to crash. Otherwise, you can spawn as many windows as you want (I ended up spawning about 100 of them though without any web content loaded; took about 6 gigs of memory though).

src/compositor.rs

wusyong · 2024-08-09T09:21:34Z

We opened #112 #113 #114 #115 for follow-up issue tracking.

wusyong and others added 20 commits August 3, 2024 16:06

Init window after event loop inited

04cc422

Fix typo

b960945

Fix resize event

3277dda

Return boolean after resize

276c0b9

Update verso to hold hashmap of windows

92b79d5

Improve shutdown logic

ae0943c

Fix scale factor on Linux

ee65d84

Present directly after composite

7e38b23

Merge branch 'main' into multi

b23070c

Add some fields to prepare for multisurface

57923bf

Add initial multi-surface support

9289541

Add document ID field in window

20c6c58

Update to latest servo

1e7f842

Create correct window spawning order

465af4e

Create separate display list for different surface

045490b

Fix flashing

cea58a1

Improve set_painting_order safety

c3f0211

Improve webview creation flow

33c9b99

Update unsupported log to trace

5ae8d65

Fix resize and add more debug logs

30ba3c8

wusyong changed the title ~~Multi~~ feat: multi-window support Aug 8, 2024

Remove unecessary step

dd6b759

wusyong marked this pull request as ready for review August 8, 2024 09:12