Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VERSUM-3787] Sentry errors #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[VERSUM-3787] Sentry errors #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/Calendar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,7 @@ export default class Calendar {
if (
!this.isHandlingWindowResize &&
this.component && // why?
(ev as any).target === window // not a jqui resize event
(ev && (ev as any).target === window) // not a jqui resize event
) {
this.isHandlingWindowResize = true
this.updateSize()
Expand Down
6 changes: 4 additions & 2 deletions packages/core/src/component/event-rendering.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,13 @@ export function filterSegsViaEls(context: ComponentContext, segs: Seg[], isMirro
}

function setElSeg(el: HTMLElement, seg: Seg) {
(el as any).fcSeg = seg
if (el) {
(el as any).fcSeg = seg
}
}

export function getElSeg(el: HTMLElement): Seg | null {
return (el as any).fcSeg || null
return el ? (el as any).fcSeg : null
}


Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/component/event-splitting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export default abstract class Splitter<PropsType extends SplittableProps = Split
let splitHashes: { [key: string]: EventUiHash } = {}

for (let defId in eventUiBases) {
if (defId) { // not the '' key
if (defId && defKeys && defKeys[defId]) { // not the '' key
for (let key of defKeys[defId]) {

if (!splitHashes[key]) {
Expand Down
2 changes: 1 addition & 1 deletion packages/interaction/src/interactions/HitDragging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export default class HitDragging {
let component = droppableStore[id].component
let offsetTracker = offsetTrackers[id]

if (offsetTracker.isWithinClipping(offsetLeft, offsetTop)) {
if (offsetTracker && offsetTracker.isWithinClipping(offsetLeft, offsetTop)) {
let originLeft = offsetTracker.computeLeft()
let originTop = offsetTracker.computeTop()
let positionLeft = offsetLeft - originLeft
Expand Down