Issue #29 : jvm-npm.js: Resolve near module dependencies inside node_… #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e node_modules dir within zip archive
…e node_modules dir within zip archive
|
The added test for this feature is running in its own thread for which the TCCL is set, and the thread goes away once the test has finished. So the main thread running all the other tests is not affected by the CL changes, no? |
|
Yes, you are right. So it looks good. @vietj what do you think ? |
cescoffier
added a commit
that referenced
this pull request
Aug 12, 2015
Issue #29 : jvm-npm.js: Resolve near module dependencies inside node_…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…modules dir within zip archive. This will also enable java-like deployment of zipped npm style verticles via the vertx-http-service-factory, e.g. https://myserver.net/myverticle.zip::package - no need to extract the archive contents.