Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BodyHandler default body limit change #2452

Closed
vietj opened this issue Jul 21, 2023 · 1 comment · Fixed by #2503
Closed

BodyHandler default body limit change #2452

vietj opened this issue Jul 21, 2023 · 1 comment · Fixed by #2503
Assignees
@tsegismont
Labels
enhancement
Milestone
4.5.0

Comments

@vietj
Copy link
Contributor

vietj commented Jul 21, 2023

Currently the default body is -1, we should have actually a bounded value here.
@vietj vietj added this to the 4.5.0 milestone Jul 21, 2023
@tsegismont tsegismont self-assigned this Nov 6, 2023
tsegismont added a commit to tsegismont/vertx-web that referenced this issue Nov 6, 2023
@tsegismont
Set BodyHandler default limit to 10 megabytes
541b55d 
See vert-x3#2452

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue Nov 6, 2023
Merged
tsegismont added a commit to tsegismont/vertx-web that referenced this issue Nov 6, 2023
@tsegismont
Set BodyHandler default limit to 10 megabytes
187be51 
See vert-x3#2452

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue Nov 6, 2023
Merged
@tsegismont tsegismont linked a pull request Nov 6, 2023 that will close this issue
Set BodyHandler default limit to 10 megabytes #2503
Merged
tsegismont added a commit to tsegismont/vertx-web that referenced this issue Nov 7, 2023
@tsegismont
Set BodyHandler default limit to 10 megabytes
eba7d05 
See vert-x3#2452

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to tsegismont/vertx-web that referenced this issue Nov 7, 2023
@tsegismont
Set BodyHandler default limit to 10 megabytes
0b689e1 
See vert-x3#2452

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit that referenced this issue Nov 7, 2023
@tsegismont
Set BodyHandler default limit to 10 megabytes (#2502)
c5f6970 
* Set BodyHandler default limit to 10 megabytes

See #2452

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

* BodyHandlerTest#testMultiFileUpload does not pass with default limit

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

---------

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit that referenced this issue Nov 7, 2023
@tsegismont
Set BodyHandler default limit to 10 megabytes (#2503)
7591152 
* Set BodyHandler default limit to 10 megabytes

See #2452

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

* BodyHandlerTest#testMultiFileUpload does not pass with default limit

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

---------

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont
Copy link
Contributor

Resolved by #2503

@michael72 michael72 mentioned this issue Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsegismont tsegismont

Labels
enhancement
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

Set BodyHandler default limit to 10 megabytes tsegismont/vertx-web
2 participants
@vietj @tsegismont