Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BodyHandler should not be added before the ProxyHandler #2614

Closed
tsegismont opened this issue May 23, 2024 · 3 comments
Closed

BodyHandler should not be added before the ProxyHandler #2614

tsegismont opened this issue May 23, 2024 · 3 comments
Assignees
@tsegismont
Labels
component/webproxy documentation enhancement
Milestone
4.5.10

Comments

@tsegismont
Copy link
Contributor

tsegismont commented May 23, 2024 •
edited
Loading

The BodyHandler should not be added before the ProxyHandler. Otherwise, the request may hang indefinitely.

We should at least document this.
@tsegismont tsegismont added this to the 4.5.8 milestone May 23, 2024
@tsegismont tsegismont self-assigned this May 23, 2024
@tsegismont tsegismont mentioned this issue May 23, 2024
Closed
@vietj
Copy link
Contributor

vietj commented May 23, 2024

@tsegismont may hang ?

@tsegismont
Copy link
Contributor Author

@tsegismont may hang ?

Fixed the description

@vietj vietj modified the milestones: 4.5.8, 4.5.9 May 24, 2024
tsegismont added a commit to tsegismont/vertx-web that referenced this issue May 24, 2024
@tsegismont
BodyHandler should not be added before the ProxyHandler
c6143a1 
See vert-x3#2614

Added documentation and make ProxyHandler fail fast if the BodyHandler has been seen.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue May 24, 2024
Merged
tsegismont added a commit to tsegismont/vertx-web that referenced this issue May 31, 2024
@tsegismont
BodyHandler should not be added before the ProxyHandler
ab4a5bb 
See vert-x3#2614

Added documentation and make ProxyHandler fail fast if the BodyHandler has been seen.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@vietj vietj modified the milestones: 4.5.9, 4.5.10 Jul 17, 2024
tsegismont added a commit to tsegismont/vertx-web that referenced this issue Aug 28, 2024
@tsegismont
BodyHandler should not be added before the ProxyHandler
3ca3ace 
See vert-x3#2614

Added documentation and make ProxyHandler fail fast if the BodyHandler has been seen.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit that referenced this issue Aug 28, 2024
@tsegismont
BodyHandler should not be added before the ProxyHandler (#2616)
fb6153b 
See #2614

Added documentation and make ProxyHandler fail fast if the BodyHandler has been seen.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit that referenced this issue Aug 28, 2024
@tsegismont
BodyHandler should not be added before the ProxyHandler (#2616)
4446eb5 
See #2614

Added documentation and make ProxyHandler fail fast if the BodyHandler has been seen.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont
Copy link
Contributor Author

Fixed by 4446eb5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsegismont tsegismont

Labels
component/webproxy documentation enhancement
Milestone
4.5.10
Development

No branches or pull requests
2 participants
@vietj @tsegismont