Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-client doesn't expose raw method #845

Closed
ylemoigne opened this issue Feb 21, 2018 · 4 comments
Closed

http-client doesn't expose raw method #845

ylemoigne opened this issue Feb 21, 2018 · 4 comments
Assignees
Milestone

Comments

@ylemoigne
Copy link

Version

  • vert.x core: 3.5.1
  • vert.x web: 3.5.1

Context

Trying to create a webdav client from vertx http client. I can't make request with non-standard method (PROPFIND, MOVE, etc.).

Please consider adding a rawMethod(String) on HttpRequest interface (Or any other mean to specify custom method).

@etourdot
Copy link

It seems already possible to handle raw methods on v3.5.1:

yourRouter.route().handler(routingContext -> {
  String method = rc.request().rawMethod();
  if ("PROPFIND".equals(method) {
   ...
  }
});

@ylemoigne
Copy link
Author

Yes. On server side. The issue is about vertx-web client : https://vertx.io/docs/vertx-web-client/java/

@vietj
Copy link
Contributor

vietj commented Aug 14, 2018

@ylemoigne is that something you could contribute ?

@vietj vietj added this to the 3.6.0 milestone Aug 14, 2018
@ylemoigne
Copy link
Author

I think I can. Last time I was willing to contribute, I stopped at CLA (did not took the time then forgot). So let's start by this, can you give me again the link/procedure to sign it ?

@vietj vietj modified the milestones: 3.6.0, 4.0.0 Nov 29, 2018
@slinkydeveloper slinkydeveloper self-assigned this Jun 11, 2019
pmlopes added a commit that referenced this issue Jun 14, 2019
Implemented support for custom HTTP methods in Web Client
@slinkydeveloper slinkydeveloper modified the milestones: 4.0.0, 3.8.0 Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants