Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plot] Enhancements + Bug Fixes #1301

Merged
merged 5 commits into from
Oct 4, 2024
Merged

[Plot] Enhancements + Bug Fixes #1301

merged 5 commits into from
Oct 4, 2024

Conversation

oualib
Copy link
Member

@oualib oualib commented Oct 3, 2024

 - multiple corrections
 - it is now possible to draw plots without agg

Should close:
 -
@oualib oualib added Bug Something isn't working. Plotting - Base Plots in-DB Computations. labels Oct 3, 2024
@oualib oualib added this to the VerticaPy 1.1.0 milestone Oct 3, 2024
@oualib oualib requested a review from mail4umar October 3, 2024 20:35
@oualib oualib self-assigned this Oct 3, 2024
Copy link
Member Author

@oualib oualib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments to resolve before merging the PR.

@@ -251,6 +251,10 @@ def bar(
q Quantile of the
:py:class:`~vDataColumns` ``of``
(ex: 50% to get the median).
- None:
No Aggregations. Parameter ``of``
must not be empty, otherwise it
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error it should be empty.

@@ -529,6 +541,10 @@ def barh(
q Quantile of the
:py:class:`~vDataColumns` ``of``
(ex: 50% to get the median).
- None:
No Aggregations. Parameter ``of``
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error it should be empty

@@ -2163,6 +2187,11 @@ def hexbin(
q Quantile of the
:py:class:`~vDataColumns` ``of``
(ex: 50% to get the median).
- None:
No Aggregations. Parameter ``of``
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just: No Aggregation here.


.. warning::

SQL code generation will be slower if the
vDataFrame has been transformed multiple
times, so it's better practice to use this
method when first preparing your data.
It is even recommended to use directly
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, we need to make it clearer?

@oualib oualib merged commit d70b7b2 into master Oct 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. Plotting - Base Plots in-DB Computations.
Projects
None yet
2 participants