-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plot] Enhancements + Bug Fixes #1301
Conversation
- multiple corrections - it is now possible to draw plots without agg Should close: -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments to resolve before merging the PR.
@@ -251,6 +251,10 @@ def bar( | |||
q Quantile of the | |||
:py:class:`~vDataColumns` ``of`` | |||
(ex: 50% to get the median). | |||
- None: | |||
No Aggregations. Parameter ``of`` | |||
must not be empty, otherwise it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error it should be empty.
@@ -529,6 +541,10 @@ def barh( | |||
q Quantile of the | |||
:py:class:`~vDataColumns` ``of`` | |||
(ex: 50% to get the median). | |||
- None: | |||
No Aggregations. Parameter ``of`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error it should be empty
@@ -2163,6 +2187,11 @@ def hexbin( | |||
q Quantile of the | |||
:py:class:`~vDataColumns` ``of`` | |||
(ex: 50% to get the median). | |||
- None: | |||
No Aggregations. Parameter ``of`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just: No Aggregation here.
|
||
.. warning:: | ||
|
||
SQL code generation will be slower if the | ||
vDataFrame has been transformed multiple | ||
times, so it's better practice to use this | ||
method when first preparing your data. | ||
It is even recommended to use directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe, we need to make it clearer?
Should close: