Handling responses with 204 status code #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the issue started by ashic (#9) regardless responses that do not contain the body, I have also run into similar problem. Although his point of handling 201 and 202 codes with no body is not necessarily valid, a 204 code is commonly used as a response to DELETE operations. As 204 response explicitly prohibits a body, it causes the executed actions to fail with MalformedSirenError, which in my opinion is incorrect, as technically there is no entity to parse in a first place (similarly to 404). This pull request is a simple mod that makes actions that get 204 response succeed.