Update pull_request_template.md #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wey-gu
reviewed
Dec 29, 2021
Aiee
approved these changes
Dec 30, 2021
Shylock-Hg
reviewed
Dec 31, 2021
| Tests: | ||
| - [ ] Unit test(positive and negative cases) | ||
| - [ ] Function test | ||
| - [ ] Perfomance test |
There was a problem hiding this comment.
Now we don't have performance test in ci.
There was a problem hiding this comment.
emmm, but i think we need test it by others.
There was a problem hiding this comment.
Yes, in my mind, I think we could add it to CI or a lightweight performance test.
There was a problem hiding this comment.
Will do it in test platform.
yixinglu
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
In order to review more efficiently, update the PR template.
Which issue(s)/PR(s) this PR relates to?
N/A
Special notes for your reviewer, ex. impact of this fix, etc:
N/A
Additional context/ Design document:
N/A
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: