-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pull_request_template.md #3589
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a27681b
Update pull_request_template.md
Sophie-Xie bf25efe
Update pull_request_template.md
Sophie-Xie 92fe937
Update pull_request_template.md
Sophie-Xie 50d82e9
Merge branch 'master' into pr-template
Sophie-Xie 6d58dd6
Merge branch 'master' into pr-template
Sophie-Xie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,42 @@ | ||
| <!-- | ||
| Thanks for your contributing! | ||
| In order to review PR more efficiently, please add information according to the template. | ||
| --> | ||
|
|
||
| #### What type of PR is this? | ||
| - [ ] bug | ||
| - [ ] feature | ||
| - [ ] enhancement | ||
|
|
||
| #### What does this PR do? | ||
| #### What problem does this PR slove? | ||
| Issue(s) number: | ||
|
|
||
| Description: | ||
|
|
||
| #### Which issue(s)/PR(s) this PR relates to? | ||
|
|
||
| #### Special notes for your reviewer, ex. impact of this fix, etc: | ||
| #### How do you slove it? | ||
|
|
||
|
|
||
|
|
||
| #### Special notes for your reviewer, ex. impact of this fix, design document, etc: | ||
|
|
||
| #### Additional context/ Design document: | ||
|
|
||
|
|
||
| #### Checklist: | ||
| Tests: | ||
| - [ ] Unit test(positive and negative cases) | ||
| - [ ] Function test | ||
| - [ ] Perfomance test | ||
| - [ ] N/A | ||
|
|
||
| Affects: | ||
| - [ ] Documentation affected (Please add the label if documentation needs to be modified.) | ||
| - [ ] Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.） | ||
| - [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.） | ||
| - [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).) | ||
| - [ ] Performance impacted: Consumes more CPU/Memory | ||
|
|
||
|
|
||
| #### Release notes: | ||
|
|
||
| Please confirm whether to be reflected in release notes and how to describe: | ||
| > ` | ||
| > ex. Fixed the bug ..... | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we don't have performance test in ci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emmm, but i think we need test it by others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in my mind, I think we could add it to CI or a lightweight performance test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do it in test platform.