Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify raft error code #3620

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Unify raft error code #3620

merged 3 commits into from
Jan 4, 2022

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Jan 4, 2022 •
edited

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:
This is a prepare to adjust log level later. Previously we have an extra ErrorCode in raftex.thrift, which is unified to common.ErrorCode as well. And there in another "code" (notorious AppendLogResult) in RaftPart, this PR also removed it.

All raft error code is unified now.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

No related

@critical27 critical27 added ready-for-testing PR: ready for the CI test cherry-pick-v3.0 PR: need cherry-pick to this version labels Jan 4, 2022
panda-sheep
panda-sheep approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@yixinglu yixinglu merged commit f51fbbd into vesoft-inc:master Jan 4, 2022
@critical27 critical27 deleted the unify_raft_error_code branch January 5, 2022 02:00
@Shylock-Hg Shylock-Hg mentioned this pull request Jan 6, 2022
Merged
11 tasks
@jamieliu1023 jamieliu1023 mentioned this pull request Jan 8, 2022
Closed
Sophie-Xie pushed a commit that referenced this pull request Jan 10, 2022
@critical27 @Sophie-Xie
Unify raft error code (#3620)
2753b1c
critical27 added a commit that referenced this pull request Jan 10, 2022
@Sophie-Xie @Aiee
@czpmango @nevermore3 @darionyaphet @HarrisChu @yixinglu @critical27 @SuperYoko @heroicNeZha @liuyu85cn @cangfengzhs @jackwener @CPWstatic
Cherry pick to v3.0.0（0110） (#3669)
a9d4713 
* Fix typos (#3615)

Co-authored-by: kyle.cao <kyle.cao@vesoft.com>

* fix fetch edges tostring (#3613)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>

* fix create space assign offline host (#3583)

* fix create space

* fix test case

Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>

* Disable ARM version docker image since related third party not ready (#3618)

* Unify raft error code (#3620)

* Meta upgrader v3 (#3540)

* Replace group when create space

* Support white list

* fix test case

* support zone operations

* fix

* Support meta upgrade v3

* add more check about parse host result (#3628)

* Ut fix (#3611)

* Enable ut and fix chaindelete

* Add mock server default worker

* fix service crash (#3616)

* Cleanup branch param in package script (#3622)

* fix crash when the expression exceed the depth (#3606)

* Enhance login password check (#3629)

* fix_batch_insert_problem (#3627)

* filter data before batch insert

* add test cases

* add more testcase

* add notifyStop() for metaClient (#3621)

* add notifyStop() for metaClient

* do clean

* Fix removeSession() (#3651)

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>

* Issue3373 storage exit crash (#3553)

* use rcu replace thread local

fix storage exit crash

format

address some comment

* fix bug

* fix bug

* Fix coalesce bug (#3653)

* fix coalesce

* fix test

* add test

* add tck

* fix

* fix

* fix

* delete double check agg in where clause (#3647)

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>

* fix meta crash after create space (#3660)

Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>

Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com>
Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com>
Co-authored-by: endy.li <25311962+heroicNeZha@users.noreply.github.com>
Co-authored-by: lionel.liu@vesoft.com <52276794+liuyu85cn@users.noreply.github.com>
Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@panda-sheep panda-sheep panda-sheep approved these changes

@SuperYoko SuperYoko SuperYoko approved these changes

@kikimo kikimo Awaiting requested review from kikimo

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

@Nivras Nivras Awaiting requested review from Nivras

@wenhaocs wenhaocs Awaiting requested review from wenhaocs

@cangfengzhs cangfengzhs Awaiting requested review from cangfengzhs

@liwenhui-soul liwenhui-soul Awaiting requested review from liwenhui-soul

@liuyu85cn liuyu85cn Awaiting requested review from liuyu85cn

@pengweisong pengweisong Awaiting requested review from pengweisong

Assignees
No one assigned
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@critical27 @yixinglu @panda-sheep @SuperYoko