Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix meta crash after create space #3660

Merged
merged 4 commits into from
Jan 8, 2022
Merged

fix meta crash after create space #3660

merged 4 commits into from
Jan 8, 2022

Conversation

darionyaphet
Copy link
Contributor

@darionyaphet darionyaphet commented Jan 7, 2022 •
edited by Shylock-Hg

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@darionyaphet darionyaphet added the ready-for-testing PR: ready for the CI test label Jan 7, 2022
@Shylock-Hg Shylock-Hg linked an issue Jan 7, 2022 that may be closed by this pull request
metad crash when create space #3659
Closed
@Shylock-Hg Shylock-Hg added cherry-pick-v3.0 PR: need cherry-pick to this version type/bug Type: something is unexpected labels Jan 7, 2022
@HarrisChu
Copy link
Contributor

fix #3624

@Shylock-Hg Shylock-Hg mentioned this pull request Jan 7, 2022
Closed
@Shylock-Hg Shylock-Hg removed the cherry-pick-v3.0 PR: need cherry-pick to this version label Jan 7, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.0 PR: need cherry-pick to this version label Jan 7, 2022
@Sophie-Xie Sophie-Xie linked an issue Jan 7, 2022 that may be closed by this pull request
meta crash after create space #3624
Closed
@critical27 critical27 merged commit 5e20c45 into vesoft-inc:master Jan 8, 2022
@darionyaphet darionyaphet deleted the fix-3624-0 branch January 9, 2022 13:49
Sophie-Xie pushed a commit that referenced this pull request Jan 10, 2022
@darionyaphet @Aiee @Sophie-Xie
fix meta crash after create space (#3660)
505e07d 
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
critical27 added a commit that referenced this pull request Jan 10, 2022
@Sophie-Xie @Aiee
@czpmango @nevermore3 @darionyaphet @HarrisChu @yixinglu @critical27 @SuperYoko @heroicNeZha @liuyu85cn @cangfengzhs @jackwener @CPWstatic
Cherry pick to v3.0.0（0110） (#3669)
a9d4713 
* Fix typos (#3615)

Co-authored-by: kyle.cao <kyle.cao@vesoft.com>

* fix fetch edges tostring (#3613)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>

* fix create space assign offline host (#3583)

* fix create space

* fix test case

Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>

* Disable ARM version docker image since related third party not ready (#3618)

* Unify raft error code (#3620)

* Meta upgrader v3 (#3540)

* Replace group when create space

* Support white list

* fix test case

* support zone operations

* fix

* Support meta upgrade v3

* add more check about parse host result (#3628)

* Ut fix (#3611)

* Enable ut and fix chaindelete

* Add mock server default worker

* fix service crash (#3616)

* Cleanup branch param in package script (#3622)

* fix crash when the expression exceed the depth (#3606)

* Enhance login password check (#3629)

* fix_batch_insert_problem (#3627)

* filter data before batch insert

* add test cases

* add more testcase

* add notifyStop() for metaClient (#3621)

* add notifyStop() for metaClient

* do clean

* Fix removeSession() (#3651)

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>

* Issue3373 storage exit crash (#3553)

* use rcu replace thread local

fix storage exit crash

format

address some comment

* fix bug

* fix bug

* Fix coalesce bug (#3653)

* fix coalesce

* fix test

* add test

* add tck

* fix

* fix

* fix

* delete double check agg in where clause (#3647)

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>

* fix meta crash after create space (#3660)

Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>

Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com>
Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com>
Co-authored-by: endy.li <25311962+heroicNeZha@users.noreply.github.com>
Co-authored-by: lionel.liu@vesoft.com <52276794+liuyu85cn@users.noreply.github.com>
Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
@jamieliu1023 jamieliu1023 mentioned this pull request Jan 15, 2022
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@critical27 @darionyaphet @Aiee
Damn create space (vesoft-inc#468)
1390b96 
* add more check about parse host result (vesoft-inc#3628)

* fix meta crash after create space (vesoft-inc#3660)

Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>

* fix test case...

Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com>
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

Assignees
No one assigned
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metad crash when create space meta crash after create space
6 participants
@darionyaphet @HarrisChu @critical27 @Shylock-Hg @Sophie-Xie @Aiee