add notifyStop() for metaClient #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
previously approved these changes
Jan 4, 2022
|
fix #3476 |
liuyu85cn
force-pushed
the
meta-client-stop
branch
from
e464911
to
e5786f1
Compare
panda-sheep
reviewed
Jan 5, 2022
| @@ -363,6 +363,9 @@ void StorageServer::notifyStop() { | |||
| serverStatus_ = STATUS_STOPPED; | |||
| cvStop_.notify_one(); | |||
| } | |||
| if (metaClient_) { | |||
| metaClient_->notifyStop(); | |||
| } | |||
Sophie-Xie
pushed a commit
that referenced
this pull request
Jan 10, 2022
* add notifyStop() for metaClient * do clean
critical27
added a commit
that referenced
this pull request
Jan 10, 2022
* Fix typos (#3615) Co-authored-by: kyle.cao <kyle.cao@vesoft.com> * fix fetch edges tostring (#3613) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com> * fix create space assign offline host (#3583) * fix create space * fix test case Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com> * Disable ARM version docker image since related third party not ready (#3618) * Unify raft error code (#3620) * Meta upgrader v3 (#3540) * Replace group when create space * Support white list * fix test case * support zone operations * fix * Support meta upgrade v3 * add more check about parse host result (#3628) * Ut fix (#3611) * Enable ut and fix chaindelete * Add mock server default worker * fix service crash (#3616) * Cleanup branch param in package script (#3622) * fix crash when the expression exceed the depth (#3606) * Enhance login password check (#3629) * fix_batch_insert_problem (#3627) * filter data before batch insert * add test cases * add more testcase * add notifyStop() for metaClient (#3621) * add notifyStop() for metaClient * do clean * Fix removeSession() (#3651) Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> * Issue3373 storage exit crash (#3553) * use rcu replace thread local fix storage exit crash format address some comment * fix bug * fix bug * Fix coalesce bug (#3653) * fix coalesce * fix test * add test * add tck * fix * fix * fix * delete double check agg in where clause (#3647) Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com> * fix meta crash after create space (#3660) Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com> Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com> Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com> Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com> Co-authored-by: endy.li <25311962+heroicNeZha@users.noreply.github.com> Co-authored-by: lionel.liu@vesoft.com <52276794+liuyu85cn@users.noreply.github.com> Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com> Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com> Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
It is reported if not "add host" metaClient will stuck at "waitForMetaready()" and can't stop.
This pr try to fix this.
How do you solve it?
waitForMetaready() will detect a flag in each loop, before retry. Set this flag.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Because no UT call metaClient.notifyStop() before, and it is hard to know which UT will affect by this, just run CI
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: